Return HTTP 201 on GameServerAllocation

[markmandel]

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

The standard for CRD creation is to return a HTTP 201 response. The Go client is more flexible and was happy with a 200 response, but the C# client will error out if anything but a 201 response.

This fixes things so we send the correct HTTP response code when creating a GameServerAllocation.

Which issue(s) this PR fixes:

Closes #2108

Special notes for your reviewer:

N/A

[markmandel]

Testing with kubectl as well:

$ kubectl -v 9 create -f ./examples/simple-game-server/gameserverallocation.yaml -o yaml
....
I0526 20:22:28.749263    1257 request.go:1068] Request Body: {"apiVersion":"allocation.agones.dev/v1","kind":"GameServerAllocation","metadata":{"namespace":"default"},"spec":{"required":{"matchLabels":{"agones.dev/fleet":"simple-game-server"}}}}
I0526 20:22:28.749302    1257 round_trippers.go:424] curl -k -v -XPOST  -H "Content-Type: application/json" -H "User-Agent: kubectl/v1.18.15 (linux/amd64) kubernetes/73dd5c8" -H "Accept: application/json" 'https://34.83.43.189/apis/allocation.agones.dev/v1/namespaces/default/gameserverallocations'
I0526 20:22:28.911903    1257 round_trippers.go:444] POST https://34.83.43.189/apis/allocation.agones.dev/v1/namespaces/default/gameserverallocations 201 Created in 162 milliseconds

You can see the 201 on the last line 🥳

[agones-bot]

Build Succeeded 👏

Build Id: 55ecdd05-a60f-4170-94f7-8c959dfcbbb1

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.15.0-98ead5a
• image: gcr.io/agones-images/agones-ping:1.15.0-98ead5a
• Linux C++ SDK (build): agonessdk-1.15.0-98ead5a-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.15.0-98ead5a.zip

A preview of the website (the last 30 builds are retained):

• https://98ead5a-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/2110/head:pr_2110 && git checkout pr_2110
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.15.0-98ead5a

[agones-bot]

Build Succeeded 👏

Build Id: f37838a2-d591-45e7-85d9-387c4d7eb847

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.15.0-04cd13b
• image: gcr.io/agones-images/agones-ping:1.15.0-04cd13b
• Linux C++ SDK (build): agonessdk-1.15.0-04cd13b-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.15.0-04cd13b.zip

A preview of the website (the last 30 builds are retained):

• https://04cd13b-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/2110/head:pr_2110 && git checkout pr_2110
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.15.0-04cd13b

[roberthbailey]

We shouldn't block this bug fix merging, but it seems like we have a test that covers the other two case statements (using the metav1 status and returning a http.StatusOK).

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment