Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Client SDK page to Third Party SDKs #2094

Merged
merged 1 commit into from
May 6, 2021

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

Wanted to make the third party SDKs more discoverable, in case the supported set didn't match a user's needs.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Wanted to make the third party SDKs more discoverable, in case the
supported set didn't match a user's needs.
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: bf755fe1-c438-435a-8ad3-b5932aa82d65

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

Seems like e2e is being a bit flaky again. Seeing GameServers that aren't moving to Ready.

time="2021-05-06 20:08:22.118" level=info msg="fleet preferred-lnvbl has 0/1 ready replicas"
time="2021-05-06 20:08:24.119" level=info msg="fleet preferred-lnvbl has 0/1 ready replicas"
time="2021-05-06 20:08:26.120" level=info msg="fleet preferred-lnvbl has 0/1 ready replicas"
time="2021-05-06 20:08:26.159" level=info msg="fleet preferred-lnvbl has 0/1 ready replicas"
time="2021-05-06 20:08:26.159" level=info msg="error waiting for fleet condition" error="timed out waiting for the condition" fleet=preferred-lnvbl
--- FAIL: TestGameServerAllocationPreferredSelection (391.77s)
    gameserverallocation_test.go:379: error waiting for fleet condition on fleet preferred-lnvbl
FAIL
time="2021-05-06 20:08:26.417" level=info msg="sent UDP packet" address="34.82.230.193:7082" test=TestGameServerUnhealthyAfterReadyCrash
time="2021-05-06 20:08:26.532" level=info msg="Namespace 1620331204 is deleted"
FAIL	agones.dev/agones/test/e2e	502.532s
FAIL

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d0c425d2-72a8-4855-ad96-9766c1319c73

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2094/head:pr_2094 && git checkout pr_2094
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.15.0-83b1a50

@roberthbailey roberthbailey added the kind/documentation Documentation for Agones label May 6, 2021
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit d29d314 into googleforgames:main May 6, 2021
@markmandel markmandel deleted the docs/client-third branch May 19, 2021 22:59
@sawagh sawagh added this to the 1.15.0 milestone Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants