Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rust SDK functionality table #2082

Merged
merged 3 commits into from
Apr 30, 2021
Merged

Add rust SDK functionality table #2082

merged 3 commits into from
Apr 30, 2021

Conversation

domgreen
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Adding tables for Rust SDK

Special notes for your reviewer:

@domgreen
Copy link
Contributor Author

I think we can also add a table of all SDKs somewhere once ive made a first pass of the remaining ones 👍 which can be a one stop shop.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 94428d1b-d763-498d-8bb1-bc73af38819e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2082/head:pr_2082 && git checkout pr_2082
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.15.0-430e660

@roberthbailey
Copy link
Member

The table lgtm. @markmandel - can you confirm that the Rust SDK does implement all of these functions?

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: domgreen, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 8ab5a97a-854b-47f6-810d-5028f45e758b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2082/head:pr_2082 && git checkout pr_2082
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.15.0-f61ea57

@markmandel markmandel added the kind/documentation Documentation for Agones label Apr 30, 2021
@markmandel markmandel merged commit 16362ca into googleforgames:main Apr 30, 2021
@sawagh sawagh added this to the 1.15.0 milestone Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants