Testing functions for resource events #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I kept writing the same two select statements a lot, so I pulled it into the central testing library for reuse.
markmandel
added
kind/cleanup
enocom
reviewed
May 18, 2018
| select { | ||
| case e := <-events: | ||
| assert.Contains(t, e, contains) | ||
| case <-time.After(3 * time.Second): |
There was a problem hiding this comment.
Should this duration be configurable?
There was a problem hiding this comment.
I've never had a need to change it. The event action is usually (always?) synchronous in testing, 3 seconds is really a "just in case" - it could probably be dropped lower.
enocom
approved these changes
May 18, 2018
|
Build Succeeded 👏 Build Id: efa3d9f8-1fd1-4ce6-8cda-6898c56f35b5 The following development artifacts have been built, and will exist for the next 30 days:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept writing the same two select statements a lot, so I pulled it into the central testing library for reuse.