Rename MetaPatch to Metadata for AllocationRequest #2070

lambertwang · 2021-04-21T20:58:34Z

What type of PR is this?
/kind cleanup

What this PR does / Why we need it:
Renames the metaPatch field in AllocationRequest to metadata while retaining backwards compatibility.

Which issue(s) this PR fixes:
Closes #2042

Special notes for your reviewer:

agones-bot · 2021-04-21T21:06:50Z

Build Failed 😱

Build Id: 76bfde66-487f-42c6-889f-fdbaf541a8d5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2021-04-21T21:10:50Z

Build Failed 😱

Build Id: 7de2fe15-0560-4891-98f8-6ba066977236

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2021-04-21T21:10:50Z

Build Failed 😱

Build Id: 7de2fe15-0560-4891-98f8-6ba066977236

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2021-04-21T23:07:38Z

Build Failed 😱

Build Id: 1c04efe0-80fe-4ba9-b06a-c5a09653ddc3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2021-04-21T23:07:38Z

Build Failed 😱

Build Id: 1c04efe0-80fe-4ba9-b06a-c5a09653ddc3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

pkg/allocation/converters/converter.go

agones-bot · 2021-04-22T21:01:11Z

Build Succeeded 👏

Build Id: fbaa18fd-5193-4cae-bd42-fa2bcd54d402

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.14.0-77882ee
image: gcr.io/agones-images/agones-ping:1.14.0-77882ee
Linux C++ SDK (build): agonessdk-1.14.0-77882ee-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.14.0-77882ee.zip

A preview of the website (the last 30 builds are retained):

https://77882ee-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2070/head:pr_2070 && git checkout pr_2070
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-77882ee

agones-bot · 2021-04-22T21:51:47Z

Build Succeeded 👏

Build Id: 32720a14-2500-4c5a-b021-a67760a2d77c

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.14.0-a1277c0
image: gcr.io/agones-images/agones-ping:1.14.0-a1277c0
Linux C++ SDK (build): agonessdk-1.14.0-a1277c0-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.14.0-a1277c0.zip

A preview of the website (the last 30 builds are retained):

https://a1277c0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2070/head:pr_2070 && git checkout pr_2070
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-a1277c0

site/content/en/docs/Advanced/allocator-service.md

test/e2e/allocator_test.go

pkg/allocation/converters/converter.go

test/e2e/allocator_test.go

agones-bot · 2021-04-23T21:51:19Z

Build Failed 😱

Build Id: 862aa4f8-495a-4142-af5b-b56b108afcfd

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2021-04-23T21:51:22Z

Build Failed 😱

Build Id: 862aa4f8-495a-4142-af5b-b56b108afcfd

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2021-04-26T19:02:26Z

Build Succeeded 👏

Build Id: eb50bba2-ca9d-4a02-9a80-28720c13aadd

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.14.0-babc4ac
image: gcr.io/agones-images/agones-ping:1.14.0-babc4ac
Linux C++ SDK (build): agonessdk-1.14.0-babc4ac-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.14.0-babc4ac.zip

A preview of the website (the last 30 builds are retained):

https://babc4ac-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2070/head:pr_2070 && git checkout pr_2070
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-babc4ac

pkg/allocation/converters/converter_test.go

agones-bot · 2021-05-05T21:19:38Z

Build Failed 😱

Build Id: 56f5413f-d11c-4a8d-818e-7104a78906ba

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2021-05-05T21:19:38Z

Build Failed 😱

Build Id: 56f5413f-d11c-4a8d-818e-7104a78906ba

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2021-05-05T22:02:08Z

LGTM! @pooneh-m anything on your end?

pkg/allocation/converters/converter.go

agones-bot · 2021-05-05T22:26:08Z

Build Succeeded 👏

Build Id: f5280c74-a35f-4717-a84b-c3188d368686

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.15.0-47e0b16
image: gcr.io/agones-images/agones-ping:1.15.0-47e0b16
Linux C++ SDK (build): agonessdk-1.15.0-47e0b16-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.15.0-47e0b16.zip

A preview of the website (the last 30 builds are retained):

https://47e0b16-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2070/head:pr_2070 && git checkout pr_2070
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.15.0-47e0b16

…/metapatch-rename

agones-bot · 2021-05-07T21:35:57Z

Build Succeeded 👏

Build Id: 734c2592-10eb-4511-8853-23943251107a

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.14.0-5b95961
image: gcr.io/agones-images/agones-ping:1.14.0-5b95961
Linux C++ SDK (build): agonessdk-1.14.0-5b95961-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.14.0-5b95961.zip

A preview of the website (the last 30 builds are retained):

https://5b95961-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2070/head:pr_2070 && git checkout pr_2070
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-5b95961

agones-bot · 2021-05-07T21:47:10Z

Build Succeeded 👏

Build Id: 7dd8922d-5f31-4255-9dde-a510047c189d

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.15.0-1e60af7
image: gcr.io/agones-images/agones-ping:1.15.0-1e60af7
Linux C++ SDK (build): agonessdk-1.15.0-1e60af7-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.15.0-1e60af7.zip

A preview of the website (the last 30 builds are retained):

https://1e60af7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2070/head:pr_2070 && git checkout pr_2070
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.15.0-1e60af7

pooneh-m

Thanks for the change.

google-oss-robot · 2021-05-07T22:40:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lambert-wang, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot requested review from dzlier-gcp and markmandel April 21, 2021 20:58

google-cla bot added the cla: yes label Apr 21, 2021

google-oss-robot added the size/M label Apr 21, 2021

roberthbailey added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Apr 22, 2021

google-oss-robot added size/L and removed size/M labels Apr 22, 2021

pooneh-m reviewed Apr 22, 2021

View reviewed changes

pkg/allocation/converters/converter.go Outdated Show resolved Hide resolved

markmandel reviewed Apr 23, 2021

View reviewed changes

site/content/en/docs/Advanced/allocator-service.md Outdated Show resolved Hide resolved

markmandel reviewed Apr 23, 2021

View reviewed changes

test/e2e/allocator_test.go Show resolved Hide resolved

pooneh-m reviewed Apr 23, 2021

View reviewed changes

pkg/allocation/converters/converter.go Outdated Show resolved Hide resolved

test/e2e/allocator_test.go Show resolved Hide resolved

google-oss-robot added size/XXL and removed size/L labels Apr 23, 2021

markmandel reviewed Apr 26, 2021

View reviewed changes

pkg/allocation/converters/converter_test.go Outdated Show resolved Hide resolved

pkg/allocation/converters/converter_test.go Outdated Show resolved Hide resolved

roberthbailey removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Apr 28, 2021

Updated tests for allocation changes

1270ba9

lambertwang force-pushed the lambertw/metapatch-rename branch from babc4ac to 1270ba9 Compare May 5, 2021 20:51

google-oss-robot added size/L and removed size/XXL labels May 5, 2021

lambertwang requested a review from markmandel May 5, 2021 21:00

lambertwang requested a review from pooneh-m May 5, 2021 21:00

pooneh-m reviewed May 5, 2021

View reviewed changes

pkg/allocation/converters/converter.go Show resolved Hide resolved

roberthbailey assigned pooneh-m May 6, 2021

Added double write for both metapatch and metadata

5b95961

lambertwang force-pushed the lambertw/metapatch-rename branch from 47e0b16 to 5b95961 Compare May 7, 2021 21:09

Merge branch 'main' of github.com:googleforgames/agones into lambertw…

1e60af7

…/metapatch-rename

lambertwang requested a review from pooneh-m May 7, 2021 21:54

pooneh-m approved these changes May 7, 2021

View reviewed changes

google-oss-robot added the lgtm label May 7, 2021

google-oss-robot added the approved label May 7, 2021

pooneh-m merged commit 27d1004 into googleforgames:main May 7, 2021

sawagh added this to the 1.15.0 milestone Jun 1, 2021

sawagh added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/cleanup Refactoring code, fixing up documentation, etc labels Jun 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename MetaPatch to Metadata for AllocationRequest #2070

Rename MetaPatch to Metadata for AllocationRequest #2070

lambertwang commented Apr 21, 2021 •

edited

Loading

agones-bot commented Apr 21, 2021

agones-bot commented Apr 21, 2021

agones-bot commented Apr 21, 2021

agones-bot commented Apr 21, 2021

agones-bot commented Apr 21, 2021

agones-bot commented Apr 22, 2021

agones-bot commented Apr 22, 2021

agones-bot commented Apr 23, 2021

agones-bot commented Apr 23, 2021

agones-bot commented Apr 26, 2021

agones-bot commented May 5, 2021

agones-bot commented May 5, 2021

markmandel commented May 5, 2021

agones-bot commented May 5, 2021

agones-bot commented May 7, 2021

agones-bot commented May 7, 2021

pooneh-m left a comment

google-oss-robot commented May 7, 2021

Rename MetaPatch to Metadata for AllocationRequest #2070

Rename MetaPatch to Metadata for AllocationRequest #2070

Conversation

lambertwang commented Apr 21, 2021 • edited Loading

agones-bot commented Apr 21, 2021

agones-bot commented Apr 21, 2021

agones-bot commented Apr 21, 2021

agones-bot commented Apr 21, 2021

agones-bot commented Apr 21, 2021

agones-bot commented Apr 22, 2021

agones-bot commented Apr 22, 2021

agones-bot commented Apr 23, 2021

agones-bot commented Apr 23, 2021

agones-bot commented Apr 26, 2021

agones-bot commented May 5, 2021

agones-bot commented May 5, 2021

markmandel commented May 5, 2021

agones-bot commented May 5, 2021

agones-bot commented May 7, 2021

agones-bot commented May 7, 2021

pooneh-m left a comment

Choose a reason for hiding this comment

google-oss-robot commented May 7, 2021

lambertwang commented Apr 21, 2021 •

edited

Loading