Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js dependencies and remove bundled sub-dependency #2040

Merged

Conversation

steven-supersolid
Copy link
Collaborator

@steven-supersolid steven-supersolid commented Apr 1, 2021

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind documentation
/kind feature
/kind hotfix

/kind cleanup

What this PR does / Why we need it:

  • Routine update of dependencies, especially fixed dependencies
  • There is no longer a warning about installing google-auth-library. This is not imported by the SDK code and is included grpc-js so has been removed as a direct dependency
  • This includes the security update in Bump the y18n nodejs dependency to 4.0.1 to fix CVE-2020-7774 #2038. Hopefully merging goes ok

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@google-cla google-cla bot added the cla: yes label Apr 1, 2021
@steven-supersolid steven-supersolid changed the title Update dependencies and remove bundled sub-dependency Update Node.js dependencies and remove bundled sub-dependency Apr 1, 2021
@steven-supersolid
Copy link
Collaborator Author

/cc @roberthbailey
/cc @markmandel

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0df73ca9-7c5e-4a68-a877-ea3cb4f15f75

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2040/head:pr_2040 && git checkout pr_2040
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-65b38f7

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roberthbailey, steven-supersolid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit eab955b into googleforgames:main Apr 1, 2021
@markmandel markmandel added this to the 1.14.0 milestone Apr 15, 2021
@roberthbailey roberthbailey added kind/cleanup Refactoring code, fixing up documentation, etc area/security Issues pertaining to security area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Apr 20, 2021
@steven-supersolid steven-supersolid deleted the nodejs-dependency-bump branch August 24, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/security Issues pertaining to security area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc cla: yes kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants