Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove K8s API reference links from yaml examples #1923

Merged
merged 3 commits into from
Dec 9, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

This PR removes the K8s API reference from the yaml files and redirects users to look at the website reference, which has links to those API docs.

Which issue(s) this PR fixes:

Work on #1824

Special notes for your reviewer:

This is to reduce toil as we increment supported Kubernetes version numbers, as it is now far easier to edit the supported K8s version throughout the entire website docs through config variables.

This PR removes the K8s API reference from the yaml files and redirects
users to look at the website reference, which has links to those API
docs.

This is to reduce toil as we increment supported Kubernetes version
numbers, as it is now far easier to edit the supported K8s version
throughout the entire website docs through config variables.

Work on googleforgames#1824
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/examples Examples. Usually found in the `examples` directory labels Dec 9, 2020
@google-cla google-cla bot added the cla: yes label Dec 9, 2020
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0cda425f-fc61-4fad-b06b-04b50af083e1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 90d5f1c1-dfca-4a79-8e3b-1aeede928536

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1923/head:pr_1923 && git checkout pr_1923
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-e8e389b

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0ac918c5-9900-4a5c-b6ed-4d0b6fd10417

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3dba95b7-6c61-4109-9562-1a424a22edb1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1923/head:pr_1923 && git checkout pr_1923
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-f4d44d9

@markmandel markmandel merged commit 322696c into googleforgames:master Dec 9, 2020
@markmandel markmandel added this to the 1.11.0 milestone Dec 9, 2020
@markmandel markmandel deleted the cleanup/examples-1.17 branch December 9, 2020 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/examples Examples. Usually found in the `examples` directory cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants