-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove K8s API reference links from yaml examples #1923
Remove K8s API reference links from yaml examples #1923
Conversation
This PR removes the K8s API reference from the yaml files and redirects users to look at the website reference, which has links to those API docs. This is to reduce toil as we increment supported Kubernetes version numbers, as it is now far easier to edit the supported K8s version throughout the entire website docs through config variables. Work on googleforgames#1824
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Build Failed 😱 Build Id: 0cda425f-fc61-4fad-b06b-04b50af083e1 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 90d5f1c1-dfca-4a79-8e3b-1aeede928536 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Failed 😱 Build Id: 0ac918c5-9900-4a5c-b6ed-4d0b6fd10417 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 3dba95b7-6c61-4109-9562-1a424a22edb1 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
This PR removes the K8s API reference from the yaml files and redirects users to look at the website reference, which has links to those API docs.
Which issue(s) this PR fixes:
Work on #1824
Special notes for your reviewer:
This is to reduce toil as we increment supported Kubernetes version numbers, as it is now far easier to edit the supported K8s version throughout the entire website docs through config variables.