Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move apiregistration & admissionregistration to v1 #1918

Merged

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

This moves our APIService, ValidatingWebhookConfiguration and MutatingWebhookConfiguration from v1betav1 to v1

Which issue(s) this PR fixes:

Work on #1799
Closes #1891

Special notes for your reviewer:

This includes moving the Go library references as well.

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/breaking Breaking change area/operations Installation, updating, metrics etc labels Dec 9, 2020
@google-cla google-cla bot added the cla: yes label Dec 9, 2020
This moves our APIService, ValidatingWebhookConfiguration and
MutatingWebhookConfiguration from v1betav1 to v1

This includes moving the Go library references as well.

Work on googleforgames#1799
@markmandel markmandel force-pushed the cleanup/extensions-v1 branch from b2b326f to 18f9968 Compare December 9, 2020 00:19
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4a688a8c-2fd4-4e34-9dbe-ce13f4945376

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1918/head:pr_1918 && git checkout pr_1918
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-b2b326f

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ffac93bb-97ff-471b-9b20-d510c949e93c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1918/head:pr_1918 && git checkout pr_1918
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-18f9968

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e6a60418-eed6-4386-9f4e-f8b6d0df8898

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1918/head:pr_1918 && git checkout pr_1918
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-d7c50e7

@roberthbailey roberthbailey merged commit df18f48 into googleforgames:master Dec 9, 2020
@markmandel markmandel deleted the cleanup/extensions-v1 branch December 9, 2020 07:19
@markmandel markmandel added this to the 1.11.0 milestone Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/operations Installation, updating, metrics etc cla: yes kind/breaking Breaking change kind/cleanup Refactoring code, fixing up documentation, etc size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validations.agones.dev and mutations.agones.dev don't declare side effects
4 participants