Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client-go to 0.17.14 #1913

Merged

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

This PR updates client-go to 0.17.14 to support Kubernetes 1.17.x.

Which issue(s) this PR fixes:

Work on #1824

Special notes for your reviewer:

This also includes a run of make gen-crd-client, which produced no change in the generated code.

This PR updates client-go to 0.17.14 to support Kubernetes 1.17.x.

This also includes a run of `make gen-crd-client`, which produced no
change in the generated code.

Work on googleforgames#1824
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/breaking Breaking change labels Dec 2, 2020
@google-cla google-cla bot added the cla: yes label Dec 2, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 43c854d8-2e3e-454a-a499-a33c91399825

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1913/head:pr_1913 && git checkout pr_1913
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-a89d347

@markmandel
Copy link
Member Author

Gentle bump on review @roberthbailey @pooneh-m please

@roberthbailey
Copy link
Member

It looks like you changed the go version to 1.14 as well, which is worth mentioning in the PR title.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f469565f-f7b5-481e-ada6-596a3cb59abc

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1913/head:pr_1913 && git checkout pr_1913
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-619bf7f

@roberthbailey roberthbailey merged commit 0ca6ded into googleforgames:master Dec 8, 2020
@markmandel markmandel deleted the cleanup/go-client-0.17.14 branch December 8, 2020 18:15
@markmandel markmandel added this to the 1.11.0 milestone Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cla: yes kind/breaking Breaking change kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants