Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kind on GameServerAllocation converter #1876

Merged
merged 2 commits into from
Nov 2, 2020

Conversation

pooneh-m
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / Why we need it:
Kind was not correctly set for "GameServerAllocation" on gRPC to GameServerAllocation response converter.

Which issue(s) this PR fixes:
Closes #1864

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0af32197-4c04-4a1d-9052-9400d99db911

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1876/head:pr_1876 && git checkout pr_1876
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-1eed5a1

@pooneh-m pooneh-m requested review from markmandel and removed request for dzlier-gcp October 29, 2020 20:42
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6bdef3f0-2f27-45d5-aa24-b899392b6a10

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1876/head:pr_1876 && git checkout pr_1876
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-e595c3a

Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pooneh-m pooneh-m merged commit 6d775cb into googleforgames:master Nov 2, 2020
@markmandel markmandel added this to the 1.10.0 milestone Nov 3, 2020
@markmandel markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/bug These are bugs. labels Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc cla: yes kind/bug These are bugs. lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allocating multicluster using GameServerAllocation API fails with missing Kind
5 participants