Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiCluster Allocation: Cleanup on error logs #1862

Merged
merged 3 commits into from
Oct 22, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Just switching to .WithError() on the failure for multi cluster allocation, primarily to make it easier to use structured logs to catch
this specific use case.

Also fixed a typo.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Just switching to .WithError() on the failure for multi cluster
allocation, primarily to make it easier to use structured logs to catch
this specific use case.

Also fixed a typo.
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Oct 22, 2020
@markmandel markmandel requested a review from pooneh-m October 22, 2020 17:58
@google-cla google-cla bot added the cla: yes label Oct 22, 2020
Copy link
Contributor

@pooneh-m pooneh-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 39e66ff0-ec1a-48ce-987f-0cb2562a628b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b977e7fe-7f4b-4017-af5c-9534dee99469

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1862/head:pr_1862 && git checkout pr_1862
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-a0578d3

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7f6c8a31-add8-4097-9013-4f8070b55f1a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1862/head:pr_1862 && git checkout pr_1862
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-5a38315

@markmandel markmandel merged commit 76fde07 into googleforgames:master Oct 22, 2020
@markmandel markmandel deleted the cleanup/error-multi branch October 22, 2020 22:06
@markmandel markmandel added this to the 1.10.0 milestone Oct 22, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Just switching to .WithError() on the failure for multi cluster
allocation, primarily to make it easier to use structured logs to catch
this specific use case.

Also fixed a typo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants