-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiCluster Allocation: Cleanup on error logs #1862
MultiCluster Allocation: Cleanup on error logs #1862
Conversation
Just switching to .WithError() on the failure for multi cluster allocation, primarily to make it easier to use structured logs to catch this specific use case. Also fixed a typo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, pooneh-m The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Failed 😱 Build Id: 39e66ff0-ec1a-48ce-987f-0cb2562a628b To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
New changes are detected. LGTM label has been removed. |
Build Succeeded 👏 Build Id: b977e7fe-7f4b-4017-af5c-9534dee99469 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: 7f6c8a31-add8-4097-9013-4f8070b55f1a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Just switching to .WithError() on the failure for multi cluster allocation, primarily to make it easier to use structured logs to catch this specific use case. Also fixed a typo.
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Just switching to .WithError() on the failure for multi cluster allocation, primarily to make it easier to use structured logs to catch
this specific use case.
Also fixed a typo.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer: