Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useful Unreal links #1846

Merged
merged 7 commits into from
Oct 16, 2020
Merged

Useful Unreal links #1846

merged 7 commits into from
Oct 16, 2020

Conversation

domgreen
Copy link
Contributor

What type of PR is this?
/kind documentation

What this PR does / Why we need it:
Adding some useful links for digging deeper into Unreal engine and how it might integrate with Agones. These links have been helpful for me understanding how to hook into the engine and how to build out better servers.

Which issue(s) this PR fixes:
Relates to #1821

Special notes for your reviewer:
Would be good to get some Unreal peeps tagged to review 👍

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: eb3a4215-a8e9-4df4-bdd2-325b78b5ed49

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 7596f94f-6074-4b89-be5d-adfae96b5d40

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member

The site test is failing with

panic: parse (https://en.wikipedia.org/wiki/Game_engine): first path segment in URL cannot contain colon

@@ -19,6 +19,25 @@ Check the [Client SDK Documentation]({{< relref "_index.md" >}}) for more detail
Download the source from the [Releases Page](https://github.com/googleforgames/agones/releases)
or {{< ghlink href="sdks/unreal" >}}directly from GitHub{{< /ghlink >}}.

## Prerequisite Knowledge

[Unreal](https://www.unrealengine.com/) is a [game engine]((https://en.wikipedia.org/wiki/Game_engine)) that is used by anyone from hobbiests all the way thought to huge AAA Game Stuidos.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the test may be failing due to the extra set of parenthesis for the game engine link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks will fix when I get back to the laptops 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, waiting for build to confirm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if im reading the build error correctly but looks like the e2e tests are now the issue:

ERROR: build step 22 "e2e-runner" failed: step exited with non-zero status: 1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That step has been a bit flaky. Is new - very odd.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sue on etiquette on resolving issues, normally let the reporter do it but I think this is fixed.

@domgreen
Copy link
Contributor Author

Was also thinking based on the discussion on the other thread around engines and pre-req knowledge should this be an additional learning rather than pre-req?

As @roberthbailey and @markmandel discussed you can get a simple version of unreal running on agones without this info but when it comes to debugging and running in prod you will probably need to know much much more.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1d0da484-3efc-4a91-9500-76a1966739b4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1846/head:pr_1846 && git checkout pr_1846
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-0fadaa5

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: fee4e154-b026-4a6c-83ed-f4e3fc669a09

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

markmandel commented Oct 14, 2020

Was also thinking based on the discussion on the other thread around engines and pre-req knowledge should this be an additional learning rather than pre-req?

As @roberthbailey and @markmandel discussed you can get a simple version of unreal running on agones without this info but when it comes to debugging and running in prod you will probably need to know much much more.

I love the text description, maybe we switch the heading to something like "Resources" rather than "Pre-req" ? WDYT?

Otherwise, this sounds like a great addition.

Should we also point to https://docs.unrealengine.com/en-US/Gameplay/Networking/HowTo/DedicatedServers/index.html ?

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0a4ba4d5-af0d-4eb8-9592-49fc3dc6d7d1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1846/head:pr_1846 && git checkout pr_1846
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-7251af7

@markmandel
Copy link
Member

@domgreen
Copy link
Contributor Author

I love the text description, maybe we switch the heading to something like "Resources" rather than "Pre-req" ? WDYT?

Otherwise, this sounds like a great addition.

Should we also point to https://docs.unrealengine.com/en-US/Gameplay/Networking/HowTo/DedicatedServers/index.html ?

Yep, agree on moving it to Resources ... will add that link as well as its good for first run thru of creating a DGS.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1c24babd-0d67-49c4-bbc8-c0b6477efab8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1846/head:pr_1846 && git checkout pr_1846
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-f149bf7

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 03c38ab1-2827-44b3-91f2-149e7dac2ef7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1846/head:pr_1846 && git checkout pr_1846
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-d579a7f

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: domgreen, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3d9e8956-0105-41fa-89bd-c10b98ebae1a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1846/head:pr_1846 && git checkout pr_1846
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-7506135

@markmandel markmandel added this to the 1.10.0 milestone Oct 16, 2020
@markmandel markmandel merged commit 6c60741 into googleforgames:master Oct 16, 2020
@markmandel markmandel added kind/documentation Documentation for Agones kind/feature New features for Agones labels Oct 16, 2020
@domgreen domgreen deleted the unreal_docs branch October 17, 2020 13:01
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
* useful unreal links
* Update site/content/en/docs/Guides/Client SDKs/unreal.md

Co-authored-by: Mark Mandel <[email protected]>
Co-authored-by: Scott Beca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cla: yes kind/documentation Documentation for Agones kind/feature New features for Agones size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants