Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Mark multicluster allocation feature as stable #1831

Merged
merged 2 commits into from
Oct 7, 2020
Merged

[Doc] Mark multicluster allocation feature as stable #1831

merged 2 commits into from
Oct 7, 2020

Conversation

pooneh-m
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind documentation

What this PR does / Why we need it:
Changing the multicluster allocation version to stable

Closes #1780

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 39f20dd5-7aed-43bc-a847-bc8664399542

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1831/head:pr_1831 && git checkout pr_1831
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-7392d57

@markmandel markmandel added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Sep 24, 2020
@markmandel
Copy link
Member

Freezing this, since I think we likely don't want to move something to stable while between RC+Stable releases.

@pooneh-m pooneh-m removed the request for review from dzlier-gcp September 24, 2020 20:32
@markmandel markmandel removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Sep 29, 2020
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 267e8118-9cac-4e87-8a4a-b6283d619f31

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b792f906-a584-4fa3-b3e8-d671c473c5e3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1831/head:pr_1831 && git checkout pr_1831
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-09f285d

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pooneh-m pooneh-m merged commit c575f40 into googleforgames:master Oct 7, 2020
@roberthbailey
Copy link
Member

After I clicked approve I realized that both of these changes to the website should be gated behind our next agones release (so that they don't become retroactively stable)

@pooneh-m
Copy link
Contributor Author

pooneh-m commented Oct 7, 2020

I'll send a followup PR to release gate it.

pooneh-m added a commit that referenced this pull request Oct 7, 2020
@pooneh-m
Revert "[Doc] Mark multicluster allocation feature as stable (#1831)"
81ff013 
This reverts commit c575f40.
@pooneh-m pooneh-m mentioned this pull request Oct 7, 2020
Merged
pooneh-m added a commit that referenced this pull request Oct 7, 2020
@pooneh-m
Revert "[Doc] Mark multicluster allocation feature as stable" (#1842)
5c5f752 
* Revert "[Doc] Mark multicluster allocation feature as stable (#1831)"

This reverts commit c575f40.

* Update multi-cluster-allocation.md

* Update multi-cluster-allocation.md

* Update feature-stages.md

* Update multi-cluster-allocation.md

* Update feature-stages.md
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@pooneh-m @ilkercelikyilmaz
[Doc] Mark multicluster allocation feature as stable (googleforgames#…
a99ccf5 
…1831)
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@pooneh-m @ilkercelikyilmaz
Revert "[Doc] Mark multicluster allocation feature as stable" (google…
d69a5d5 
…forgames#1842)

* Revert "[Doc] Mark multicluster allocation feature as stable (googleforgames#1831)"

This reverts commit c575f40.

* Update multi-cluster-allocation.md

* Update multi-cluster-allocation.md

* Update feature-stages.md

* Update multi-cluster-allocation.md

* Update feature-stages.md
@markmandel markmandel added this to the 1.10.0 milestone Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@markmandel markmandel Awaiting requested review from markmandel

Assignees

@roberthbailey roberthbailey

Labels
approved cla: yes lgtm size/XS
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

Change the multi-cluster allocation feature to stable version
6 participants
@pooneh-m @agones-bot @markmandel @google-oss-robot @roberthbailey @googlebot