Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Update allocator service & multi-cluster allocation documentation #1802

Merged
merged 3 commits into from
Sep 16, 2020
Merged

[Doc] Update allocator service & multi-cluster allocation documentation #1802

merged 3 commits into from
Sep 16, 2020

Conversation

pooneh-m
Copy link
Contributor

@pooneh-m pooneh-m commented Sep 9, 2020

What type of PR is this?

/kind documentation

What this PR does / Why we need it:
Add a note in the doc for (1) priority number interpretation in multi-cluster; (2) emphasize on configuring cert-manager certificate based on the underlying system; (3) prereq for cmd-line tool installation in allocator doc.

Which issue(s) this PR fixes:

Closes #1781 and #1582

Special notes for your reviewer:

@pooneh-m pooneh-m changed the title Update allocator service documentation [Doc] Update allocator service & multi-cluster allocation documentation Sep 9, 2020
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: e4ee45d9-b6a9-43a5-8bde-c294ac632b4d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4314d2ac-4fc4-4dca-9764-f7a682bf7f0b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1802/head:pr_1802 && git checkout pr_1802
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-724c0e4

@roberthbailey roberthbailey self-assigned this Sep 12, 2020
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 903876fc-76ba-4610-b6d1-d6af28f58afc

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 6fc9e09b-52a7-4e4f-a758-d376e012b346

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 05b980a3-2f1a-4923-aa58-1ac1fb37a37f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1802/head:pr_1802 && git checkout pr_1802
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-b4def89

roberthbailey
roberthbailey approved these changes Sep 16, 2020
View reviewed changes
site/content/en/docs/Advanced/allocator-service.md

Here is an example of using a self-signed `ClusterIssuer` for configuring allocator-tls `Secret`:

```bash
#!/bin/bash
# Create a self-signed ClusterIssuer
cat <<EOF | kubectl apply -f -
apiVersion: cert-manager.io/v1alpha2
apiVersion: cert-manager.io/v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you ack that it is ok to publish these changes for the existing release (vs. gating them on the next agones release)? I think that it should be ok, but want to double check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are ok, unless a cluster is using an old version of cert-manager, which is independent to Agones version.
I manually tested it on Agones v1.6 cluster.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3b950929-1f5d-4d38-8a92-1de2d5315464

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1802/head:pr_1802 && git checkout pr_1802
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-fbda2a7

@roberthbailey roberthbailey merged commit b51dc03 into googleforgames:master Sep 16, 2020
@roberthbailey
Copy link
Member

And I submitted without getting an ack.... oops.

@aLekSer aLekSer added the area/site The website itself - including redirects, styling, search, etc label Sep 16, 2020
@markmandel markmandel added this to the 1.9.0 milestone Sep 22, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@pooneh-m @aLekSer
@roberthbailey @ilkercelikyilmaz
Update allocator service documentation (googleforgames#1802)
356f094 
Co-authored-by: Alexander Apalikov <[email protected]>
Co-authored-by: Robert Bailey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

Assignees

@roberthbailey roberthbailey

Labels
approved area/site The website itself - including redirects, styling, search, etc cla: yes size/M
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

[Doc] add a caveat on setting expiration for cert-manager certificate resources
7 participants
@pooneh-m @agones-bot @google-oss-robot @roberthbailey @markmandel @googlebot @aLekSer