Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Troubleshooting - namespace stuck terminating #1795

Merged
merged 6 commits into from
Sep 11, 2020
Merged

Troubleshooting - namespace stuck terminating #1795

merged 6 commits into from
Sep 11, 2020

Conversation

domgreen
Copy link
Contributor

@domgreen domgreen commented Sep 5, 2020

What type of PR is this?
/kind documentation

What this PR does / Why we need it:

Adding documentation around what to do if you accidentally get your namespace stuck in terminating.

Which issue(s) this PR fixes:

Links #1778
Links #1783

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2465aacf-238b-4f44-968a-ca75083393ff

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1795/head:pr_1795 && git checkout pr_1795
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-bd87a93

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c493679c-f579-4a35-9b32-d6f8e7b3bb78

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0e321109-2e36-4996-ba44-b184b8104905

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 3884cc38-5a5b-4a59-adaf-0b9ef7fcf736

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@domgreen domgreen requested a review from aLekSer September 10, 2020 16:30
Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the instructions you added, they actually was helpful. Please fix the JSON. I get an error when I am trying to use "finalizers: " with an empty value:

curl -k -H "Content-Type: application/json" -X PUT --data-binary @tmp.json http://127.0.0.1:8001/api/v1/namespaces/agones-system/finalize
{
  "kind": "Status",
  "apiVersion": "v1",
  "metadata": {

  },
  "status": "Failure",
  "message": "the object provided is unrecognized (must be of type Namespace): couldn't get version/kind; json parse error: invalid character '}' looking for beginning of value ({\n    \"apiVersion\": \"v1\",\n     ...)",
  "reason": "BadRequest",
  "code": 400

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, domgreen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel
Copy link
Member

@aLekSer just wanted to check - I was about to merge this, but I'm not sure if you mean for changes to be made before getting merged?

@domgreen
Copy link
Contributor Author

@aLekSer just wanted to check - I was about to merge this, but I'm not sure if you mean for changes to be made before getting merged?

Think I need to fix up the JSON ... Will look this morning 👍

@aLekSer
Copy link
Collaborator

aLekSer commented Sep 11, 2020

Yes, overall look great, but a small nit is a not valid JSON without a value, which looks not perfect when someone read the docs. I will merge this after this small update.

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 889b9693-f628-4462-a58b-7e99e631b6fe

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1795/head:pr_1795 && git checkout pr_1795
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-294a581

@domgreen
Copy link
Contributor Author

Thanks @aLekSer missed that it was a GH recommendation otherwise I would have clicked it last night :/

@markmandel once were green I think were good to merge 👍

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6daaf06b-4b4f-4b9d-9831-dc157691f1e7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1795/head:pr_1795 && git checkout pr_1795
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-bf22501

@aLekSer aLekSer merged commit 697a9ca into googleforgames:master Sep 11, 2020
@markmandel markmandel added this to the 1.9.0 milestone Sep 11, 2020
@markmandel markmandel added kind/documentation Documentation for Agones kind/feature New features for Agones labels Sep 11, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
* adding troubleshooting for terminating namespace

* Update site/content/en/docs/Guides/troubleshooting.md

Co-authored-by: Alexander Apalikov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cla: yes kind/documentation Documentation for Agones kind/feature New features for Agones size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants