-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Troubleshooting - namespace stuck terminating #1795
Troubleshooting - namespace stuck terminating #1795
Conversation
Build Succeeded 👏 Build Id: 2465aacf-238b-4f44-968a-ca75083393ff The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Co-authored-by: Alexander Apalikov <[email protected]>
Build Failed 😱 Build Id: c493679c-f579-4a35-9b32-d6f8e7b3bb78 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: 0e321109-2e36-4996-ba44-b184b8104905 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: 3884cc38-5a5b-4a59-adaf-0b9ef7fcf736 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified the instructions you added, they actually was helpful. Please fix the JSON. I get an error when I am trying to use "finalizers: "
with an empty value:
curl -k -H "Content-Type: application/json" -X PUT --data-binary @tmp.json http://127.0.0.1:8001/api/v1/namespaces/agones-system/finalize
{
"kind": "Status",
"apiVersion": "v1",
"metadata": {
},
"status": "Failure",
"message": "the object provided is unrecognized (must be of type Namespace): couldn't get version/kind; json parse error: invalid character '}' looking for beginning of value ({\n \"apiVersion\": \"v1\",\n ...)",
"reason": "BadRequest",
"code": 400
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aLekSer, domgreen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@aLekSer just wanted to check - I was about to merge this, but I'm not sure if you mean for changes to be made before getting merged? |
Think I need to fix up the JSON ... Will look this morning 👍 |
Yes, overall look great, but a small nit is a not valid JSON without a value, which looks not perfect when someone read the docs. I will merge this after this small update. |
New changes are detected. LGTM label has been removed. |
Build Succeeded 👏 Build Id: 889b9693-f628-4462-a58b-7e99e631b6fe The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Co-authored-by: Alexander Apalikov <[email protected]>
Thanks @aLekSer missed that it was a GH recommendation otherwise I would have clicked it last night :/ @markmandel once were green I think were good to merge 👍 |
Build Succeeded 👏 Build Id: 6daaf06b-4b4f-4b9d-9831-dc157691f1e7 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
* adding troubleshooting for terminating namespace * Update site/content/en/docs/Guides/troubleshooting.md Co-authored-by: Alexander Apalikov <[email protected]>
What type of PR is this?
/kind documentation
What this PR does / Why we need it:
Adding documentation around what to do if you accidentally get your namespace stuck in terminating.
Which issue(s) this PR fixes:
Links #1778
Links #1783