Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option to hardcode load balancer IP for allocator. #1766

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Added option to hardcode load balancer IP for allocator. #1766

merged 2 commits into from
Aug 21, 2020

Conversation

devloop0
Copy link
Contributor

@devloop0 devloop0 commented Aug 20, 2020 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:
Adds an agones.allocator.http.loadBalancerIP Helm configuration parameter to hardcode load balancer IP (if provided).

Which issue(s) this PR fixes:

Closes #1709

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 4b4f561c-c147-4583-a3f8-5c2f068a0bff

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 30aab2de-b9e9-4977-a0dc-a1ee8b7460d7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1766/head:pr_1766 && git checkout pr_1766
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-1fc5fc2

pooneh-m
pooneh-m reviewed Aug 20, 2020
View reviewed changes
Copy link
Contributor

@pooneh-m pooneh-m left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your change. Did you verify manually that it works for GKE? I can't think of any way to e2e test it.

install/helm/agones/values.yaml Show resolved Hide resolved
@devloop0
Copy link
Contributor Author

I manually tested this change as follows:

  1. Created a new cluster following the directions here: https://agones.dev/site/docs/installation/creating-cluster/gke/

  2. Reserved a static, regional IP for a load balancer in the same region as my cluster

  3. helm upgrade --install --namespace=agones-system --set agones.image.tag=1.9.0-1fc5fc2 --set agones.allocator.http.loadBalancerIP="<LB-IP>" agones ./install/helm/agones/
    (The image tag corresponds to the previous successful build for this PR)

  4. Waited to make sure that the external IP of the agones-allocator load balancer matched

  5. Generated a client cert that the allocator would recognize from here: https://agones.dev/site/docs/advanced/allocator-service/#client-certificate

  6. Just extracted the existing CA crt (Reversing the last command from here: https://agones.dev/site/docs/advanced/allocator-service/#server-tls-certificate)
    kubectl get secret allocator-tls-ca -o json -n agones-system | jq '.data["tls-ca.crt"]' -r | base64 -d > ca.crt

  7. Confirmed that allocating using the client gave no cert errors (as detailed here: https://agones.dev/site/docs/advanced/allocator-service/#send-allocation-request)

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 537f1f66-4308-40f1-aca9-05043422501e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1766/head:pr_1766 && git checkout pr_1766
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-500cb7b

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devloop0, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pooneh-m
Copy link
Contributor

Looks great! Thank you.

@pooneh-m pooneh-m merged commit 638a7fd into googleforgames:master Aug 21, 2020
@markmandel markmandel added this to the 1.9.0 milestone Sep 22, 2020
@markmandel markmandel added area/operations Installation, updating, metrics etc kind/feature New features for Agones labels Sep 22, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@devloop0 @nathreya-google @ilkercelikyilmaz
Added option to hardcode load balancer IP for allocator. (googleforga…
d6a377e 
…mes#1766)

* Added option to hardcode load balancer IP for allocator.

* Updated documentation and manually tested change.

Co-authored-by: Nikhil Athreya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pooneh-m pooneh-m pooneh-m approved these changes

@markmandel markmandel Awaiting requested review from markmandel

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees

@pooneh-m pooneh-m

Labels
approved area/operations Installation, updating, metrics etc cla: yes kind/feature New features for Agones lgtm size/S
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Helm chart: allow to specify loadBalancerIP
7 participants
@devloop0 @agones-bot @google-oss-robot @pooneh-m @markmandel @googlebot @nathreya-google