Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best practices for game server shutdown #1752

Merged
merged 2 commits into from
Aug 17, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

Based on conversations in Slack, it was not clear on best practices on how to handle graceful shutdown in the game server process.

Wrote some docs that both point to the Kubernetes documentation, but also provides a rule of thumb that should apply for most all cases.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
N/A

@markmandel markmandel added kind/documentation Documentation for Agones kind/cleanup Refactoring code, fixing up documentation, etc labels Aug 14, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 67eaf1ea-c280-4d4a-84de-27bf5e09612f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1752/head:pr_1752 && git checkout pr_1752
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-0a3df89

It's worth reading the [Termination of Pods](https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-termination)
Kubernetes documentation, to understand the termination process, and the related configuration options.

As a rule of thumb, implement a graceful shutdown in you game sever process when it receives the TERM signal

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo: shutdown in you game sever; should be "your"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 Thanks!

Based on conversations in Slack, it was not clear on best practices on
how to handle graceful shutdown in the game server process.

Wrote some docs that both point to the Kubernetes documentation, but
also provides a rule of thumb that should apply for most all cases.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f7224dcf-f1bf-4eb2-81f3-917e2289ef9a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1752/head:pr_1752 && git checkout pr_1752
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-a4d9437

Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful links were added.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 366fd241-55ec-404e-8866-cda1f53487bf

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1752/head:pr_1752 && git checkout pr_1752
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-7236ece

@aLekSer aLekSer merged commit da6cc1b into googleforgames:master Aug 17, 2020
@markmandel markmandel deleted the docs/shutdown branch August 17, 2020 19:59
@markmandel markmandel added this to the 1.8.0 milestone Aug 17, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Based on conversations in Slack, it was not clear on best practices on
how to handle graceful shutdown in the game server process.

Wrote some docs that both point to the Kubernetes documentation, but
also provides a rule of thumb that should apply for most all cases.

Co-authored-by: Alexander Apalikov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cla: yes kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants