-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Best practices for game server shutdown #1752
Conversation
Build Succeeded 👏 Build Id: 67eaf1ea-c280-4d4a-84de-27bf5e09612f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
It's worth reading the [Termination of Pods](https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-termination) | ||
Kubernetes documentation, to understand the termination process, and the related configuration options. | ||
|
||
As a rule of thumb, implement a graceful shutdown in you game sever process when it receives the TERM signal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typo: shutdown in you game sever
; should be "your"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦 Thanks!
Based on conversations in Slack, it was not clear on best practices on how to handle graceful shutdown in the game server process. Wrote some docs that both point to the Kubernetes documentation, but also provides a rule of thumb that should apply for most all cases.
0a3df89
to
a4d9437
Compare
Build Succeeded 👏 Build Id: f7224dcf-f1bf-4eb2-81f3-917e2289ef9a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Useful links were added.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aLekSer, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Build Succeeded 👏 Build Id: 366fd241-55ec-404e-8866-cda1f53487bf The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Based on conversations in Slack, it was not clear on best practices on how to handle graceful shutdown in the game server process. Wrote some docs that both point to the Kubernetes documentation, but also provides a rule of thumb that should apply for most all cases. Co-authored-by: Alexander Apalikov <[email protected]>
What type of PR is this?
/kind documentation
What this PR does / Why we need it:
Based on conversations in Slack, it was not clear on best practices on how to handle graceful shutdown in the game server process.
Wrote some docs that both point to the Kubernetes documentation, but also provides a rule of thumb that should apply for most all cases.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A