Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added several tests for metrics package #1735

Merged
merged 3 commits into from
Aug 7, 2020

Conversation

akremsa
Copy link
Contributor

@akremsa akremsa commented Aug 4, 2020

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:
Added several tests for metrics package, improved log messages.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 38f9b2b4-2526-4e61-b533-7e5a9ddb87cf

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@akremsa akremsa force-pushed the tests-update-metrics branch from b58031b to fc5e723 Compare August 4, 2020 12:57
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: dd6475c1-e513-4e76-bc76-06ade81167e3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1735/head:pr_1735 && git checkout pr_1735
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-fc5e723

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 4a5f233b-571e-4740-b8b5-57e68f52afc0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 8ea9b18c-e3a2-4dd3-9058-d065d37291dd

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1735/head:pr_1735 && git checkout pr_1735
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-16990ad

@markmandel markmandel merged commit b756a1d into googleforgames:master Aug 7, 2020
@markmandel markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc labels Aug 7, 2020
@markmandel markmandel added this to the 1.8.0 milestone Aug 7, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants