-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added several tests for metrics package #1735
Added several tests for metrics package #1735
Conversation
Build Failed 😱 Build Id: 38f9b2b4-2526-4e61-b533-7e5a9ddb87cf To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
b58031b
to
fc5e723
Compare
Build Succeeded 👏 Build Id: dd6475c1-e513-4e76-bc76-06ade81167e3 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akremsa, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Build Failed 😱 Build Id: 4a5f233b-571e-4740-b8b5-57e68f52afc0 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 8ea9b18c-e3a2-4dd3-9058-d065d37291dd The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Co-authored-by: Mark Mandel <[email protected]>
What type of PR is this?
What this PR does / Why we need it:
Added several tests for metrics package, improved log messages.