Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests update: gameserversets-controllers added missing test cases #1727

Merged
merged 3 commits into from
Aug 4, 2020
Merged

Tests update: gameserversets-controllers added missing test cases #1727

merged 3 commits into from
Aug 4, 2020

Conversation

akremsa
Copy link
Contributor

@akremsa akremsa commented Jul 30, 2020

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / Why we need it:
Added several missing test cases.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 75f706cd-f6a0-41b7-9cce-6b09141d0180

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1727/head:pr_1727 && git checkout pr_1727
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-74628a9

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0b1b660e-f912-43f1-818e-5d1240e33076

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1727/head:pr_1727 && git checkout pr_1727
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-3abf24c

markmandel
markmandel approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e7ce6cd5-619b-4cf0-a2b4-328db543a32b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1727/head:pr_1727 && git checkout pr_1727
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-7aedbd5

@markmandel markmandel added this to the 1.8.0 milestone Aug 4, 2020
@markmandel markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc labels Aug 4, 2020
@markmandel markmandel merged commit bd396dd into googleforgames:master Aug 4, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@alexey-kremsa-globant @markmandel @ilkercelikyilmaz
Tests update: gameserversets-controllers added missing test cases (go…
b1db8b2 
…ogleforgames#1727)

* gameserversets-controllers added missing test cases
* use require to avoid nil pointer exceptions

Co-authored-by: Mark Mandel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees

@markmandel markmandel

Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/L
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
6 participants
@akremsa @agones-bot @google-oss-robot @markmandel @googlebot @alexey-kremsa-globant