CI: increase lock time to 1 hour #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aLekSer
added
the
area/build-tools
remove deprecated -try syntax
aLekSer
force-pushed
the
ci/increase-consul-lock
branch
from
1306abd to
6ac379d
Compare
aLekSer
commented
Jul 28, 2020
| @@ -256,7 +256,7 @@ test-e2e-integration: $(ensure-build-image) | |||
| --gameserver-image=$(GS_TEST_IMAGE) \ | |||
| --pullsecret=$(IMAGE_PULL_SECRET) \ | |||
| --feature-gates=$(FEATURE_GATES) \ | |||
| --namespace=$(GAMESERVERS_NAMESPACE) \ | |||
| --namespace=$(GAMESERVERS_NAMESPACE) | |||
There was a problem hiding this comment.
This is done to fix ordering of messages.
Just to compare:
go test -mod=vendor -race -parallel=64 agones.dev/agones/test/e2e --kubeconfig /root/.kube/config \
--gameserver-image=gcr.io/agones-images/udp-server:0.21 \
--pullsecret= \
--feature-gates="" \
--namespace="" \
echo "Finishing e2e integration test!"
ok agones.dev/agones/test/e2e 261.472s
make[1]: Leaving directory '/workspace/build'
make test-e2e-failure
make[1]: Entering directory '/workspace/build'
echo "starting e2e controller failure test"
starting e2e controller failure test
go test -mod=vendor -race -parallel=1 agones.dev/agones/test/e2e/controller --kubeconfig /root/.kube/config \
--gameserver-image=gcr.io/agones-images/udp-server:0.21 \
--pullsecret=
ok agones.dev/agones/test/e2e/controller 14.000s
echo "Finishing e2e controller failure test!"
Finishing e2e controller failure test!
|
Build Succeeded 👏 Build Id: 2a4b23fe-99fd-4720-bd17-b89e4b082edd The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Build Succeeded 👏 Build Id: 297ce237-32ef-43fc-b6a3-61c6e7b95c4f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Build Succeeded 👏 Build Id: e192e056-98eb-4203-b865-cea8ef96c298 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
markmandel
approved these changes
Jul 28, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aLekSer, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
markmandel
added
area/tests
ilkercelikyilmaz
pushed a commit
to ilkercelikyilmaz/agones
that referenced
this pull request
Oct 23, 2020
* CI: increase lock time to 1 hour * Finishing message should be after test results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove deprecated -try syntax
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer: