Supports Rust Alpha SDK #1717

yoshd · 2020-07-25T18:08:51Z

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Add Rust Alpha SDK. This makes it easy to use the feature gate for player tracking in the Rust SDK.

For example, GetPlayerCount can be called like this:

let sdk = agones::Sdk::new()?;
let player_count = sdk.alpha().get_player_count()?;

Special notes for your reviewer:

Relates to #1033

yoshd · 2020-07-25T18:11:24Z

/assign @roberthbailey

agones-bot · 2020-07-25T18:28:20Z

Build Succeeded 👏

Build Id: 26463400-ef72-4203-aedc-822e8e27cf63

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.8.0-c357d8d
image: gcr.io/agones-images/agones-sdk:1.8.0-c357d8d
image: gcr.io/agones-images/agones-ping:1.8.0-c357d8d
Linux C++ SDK (build): agonessdk-1.8.0-c357d8d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.8.0-c357d8d.zip

A preview of the website (the last 30 builds are retained):

https://c357d8d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1717/head:pr_1717 && git checkout pr_1717
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-c357d8d

test/sdk/rust/src/main.rs

agones-bot · 2020-07-27T12:55:34Z

Build Succeeded 👏

Build Id: 48d7e9f9-dc94-473c-bacd-7a760ab6c58c

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.8.0-8b4c100
image: gcr.io/agones-images/agones-sdk:1.8.0-8b4c100
image: gcr.io/agones-images/agones-ping:1.8.0-8b4c100
Linux C++ SDK (build): agonessdk-1.8.0-8b4c100-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.8.0-8b4c100.zip

A preview of the website (the last 30 builds are retained):

https://8b4c100-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1717/head:pr_1717 && git checkout pr_1717
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-8b4c100

roberthbailey · 2020-07-27T18:09:15Z

I am definitely a rust noobie and I think @markmandel has been writing some more rust lately so I'll let him take a look.

markmandel

Yay! More Rust! 😄

Added some notes, but I think it's minor type cleanup stuff. Thanks for doing this work!

markmandel · 2020-07-27T18:19:41Z

build/includes/sdk.mk

@@ -165,7 +165,7 @@ run-sdk-conformance-test-go:
 	$(MAKE) run-sdk-conformance-no-build SDK_FOLDER=go GRPC_PORT=9001 HTTP_PORT=9101 FEATURE_GATES=PlayerTracking=true TESTS=$(DEFAULT_CONFORMANCE_TESTS),$(ALPHA_CONFORMANCE_TESTS)

 run-sdk-conformance-test-rust:
-	$(MAKE) run-sdk-conformance-test SDK_FOLDER=rust
+	$(MAKE) run-sdk-conformance-test SDK_FOLDER=rust FEATURE_GATES=PlayerTracking=true TESTS=$(DEFAULT_CONFORMANCE_TESTS),$(ALPHA_CONFORMANCE_TESTS)


This should probably follow what Go is doing - which is running one without the flag, and then one with:

agones/build/includes/sdk.mk

Line 163 in 8b4c100

$(MAKE) run-sdk-conformance-test SDK_FOLDER=go GRPC_PORT=9001 HTTP_PORT=9101

Thank you for the review.
OK. As far as I can see, it seems better not to duplicate ports between tests in each language.
I'll fix it like that.

I fixed it.

sdks/rust/src/alpha.rs

markmandel · 2020-07-27T18:29:40Z

test/sdk/rust/src/main.rs

@@ -112,6 +112,69 @@ fn run() -> Result<(), String> {
    sdk.set_label("test-label", &creation_ts.to_string())
        .map_err(|e| format!("Could not run SetLabel(): {}. Exiting!", e))?;

+    println!("Setting player capacity...");


We could do a simple string comparison to see if "PlayerTracking=true" is contained in the FEATURE_GATES environment variable as a way to determine whether to run these tests or not?

Keep things simple, WDYT?

OK. It seems easy to implement so I'll fix.

I fixed it.

…t variable contains PlayerTracking=true

agones-bot · 2020-07-28T14:26:35Z

Build Succeeded 👏

Build Id: eedfc6e8-4d95-4c56-86e3-16a95792517f

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.8.0-c2a3600
image: gcr.io/agones-images/agones-sdk:1.8.0-c2a3600
image: gcr.io/agones-images/agones-ping:1.8.0-c2a3600
Linux C++ SDK (build): agonessdk-1.8.0-c2a3600-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.8.0-c2a3600.zip

A preview of the website (the last 30 builds are retained):

https://c2a3600-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1717/head:pr_1717 && git checkout pr_1717
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-c2a3600

yoshd · 2020-07-28T17:52:39Z

/assign @markmandel

markmandel

Looks great! love it!

google-oss-robot · 2020-07-28T23:55:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, yoshd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2020-07-28T23:55:44Z

New changes are detected. LGTM label has been removed.

agones-bot · 2020-07-29T00:12:50Z

Build Succeeded 👏

Build Id: df14540a-632f-4177-b51b-187d2c6185ff

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.8.0-4c8e95f
image: gcr.io/agones-images/agones-sdk:1.8.0-4c8e95f
image: gcr.io/agones-images/agones-ping:1.8.0-4c8e95f
Linux C++ SDK (build): agonessdk-1.8.0-4c8e95f-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.8.0-4c8e95f.zip

A preview of the website (the last 30 builds are retained):

https://4c8e95f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1717/head:pr_1717 && git checkout pr_1717
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-4c8e95f

* Supports Rust Alpha SDK Co-authored-by: Mark Mandel <[email protected]>

Supports Rust Alpha SDK

c357d8d

google-oss-robot requested review from dzlier-gcp and markmandel July 25, 2020 18:08

googlebot added the cla: yes label Jul 25, 2020

google-oss-robot added the size/XXL label Jul 25, 2020

google-oss-robot assigned roberthbailey Jul 25, 2020

aLekSer reviewed Jul 27, 2020

View reviewed changes

test/sdk/rust/src/main.rs Outdated Show resolved Hide resolved

aLekSer reviewed Jul 27, 2020

View reviewed changes

test/sdk/rust/src/main.rs Outdated Show resolved Hide resolved

Fix typo in Rust SDK Test

8b4c100

roberthbailey assigned markmandel and unassigned roberthbailey Jul 27, 2020

markmandel reviewed Jul 27, 2020

View reviewed changes

yoshd added 2 commits July 28, 2020 22:56

Fix Rust SDK tests to run both with and without feature flags

96ab468

Fix Rust SDK PlayerTracking test to run when FEATURE_GATES environmen…

c2a3600

…t variable contains PlayerTracking=true

markmandel approved these changes Jul 28, 2020

View reviewed changes

google-oss-robot added the lgtm label Jul 28, 2020

google-oss-robot added the approved label Jul 28, 2020

Merge branch 'master' into rust-alpha-sdk

4c8e95f

google-oss-robot removed the lgtm label Jul 28, 2020

markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones labels Jul 29, 2020

markmandel added this to the 1.8.0 milestone Jul 29, 2020

markmandel merged commit b320b49 into googleforgames:master Jul 29, 2020

ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020

Supports Rust Alpha SDK (googleforgames#1717)

5a0fc51

* Supports Rust Alpha SDK Co-authored-by: Mark Mandel <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Supports Rust Alpha SDK #1717

Supports Rust Alpha SDK #1717

yoshd commented Jul 25, 2020 •

edited

Loading

yoshd commented Jul 25, 2020

agones-bot commented Jul 25, 2020

agones-bot commented Jul 27, 2020

roberthbailey commented Jul 27, 2020

markmandel left a comment

markmandel Jul 27, 2020

yoshd Jul 28, 2020

yoshd Jul 28, 2020

markmandel Jul 27, 2020

yoshd Jul 28, 2020

yoshd Jul 28, 2020

agones-bot commented Jul 28, 2020

yoshd commented Jul 28, 2020

markmandel left a comment

google-oss-robot commented Jul 28, 2020

google-oss-robot commented Jul 28, 2020

agones-bot commented Jul 29, 2020

Supports Rust Alpha SDK #1717

Supports Rust Alpha SDK #1717

Conversation

yoshd commented Jul 25, 2020 • edited Loading

yoshd commented Jul 25, 2020

agones-bot commented Jul 25, 2020

agones-bot commented Jul 27, 2020

roberthbailey commented Jul 27, 2020

markmandel left a comment

Choose a reason for hiding this comment

markmandel Jul 27, 2020

Choose a reason for hiding this comment

yoshd Jul 28, 2020

Choose a reason for hiding this comment

yoshd Jul 28, 2020

Choose a reason for hiding this comment

markmandel Jul 27, 2020

Choose a reason for hiding this comment

yoshd Jul 28, 2020

Choose a reason for hiding this comment

yoshd Jul 28, 2020

Choose a reason for hiding this comment

agones-bot commented Jul 28, 2020

yoshd commented Jul 28, 2020

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Jul 28, 2020

google-oss-robot commented Jul 28, 2020

agones-bot commented Jul 29, 2020

yoshd commented Jul 25, 2020 •

edited

Loading