CI: website htmltest fix returning error from the loop

[aLekSer]

Previously htmltest 5-iterations loop returned the error code of the sleep 60 call, which is always 0.
Ideally we should remove last one minute sleep also.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #1712.

Special notes for your reviewer:
A separate PR with all 404 errors fixes. And this will help to identify that now htmltest does not give false positive results always. Merge PR #1716 first. As you can see this PR would fail without website fix merged.

[agones-bot]

Build Failed 😱

Build Id: 59a0be80-4b12-4517-a4cb-06d07966a60f

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[aLekSer]

An easy and fast way to test the fix:

hugo-test2:
	for i in 1 2; \
		do echo "Html Test: Attempt $$i" && \
		  docker run --rm -t -e "TERM=xterm-256color" $(common_mounts) $(DOCKER_RUN_ARGS) $(build_tag) bash -c \
			"ssl && errorCode=$? && echo $(errorCode)" && \
	break || sleep 1 && false ; done; 

hugo-test3:
	for i in 1 2; \
		do echo "Html Test: Attempt $$i" && \
		  docker run --rm -t -e "TERM=xterm-256color" $(common_mounts) $(DOCKER_RUN_ARGS) $(build_tag) bash -c \
			"ls && errorCode=$? && echo $(errorCode)" && \
	break || sleep 1 && false ; done; 

make hugo-test2 would return echo $? 1 while hugo-test3 - 0.

[agones-bot]

Build Failed 😱

Build Id: 70a00cbe-dfac-426b-8908-09fc8ba6e5eb

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[markmandel]

Super mega minor nit: drop the extra space before -c

But otherwise looks good 👍

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[agones-bot]

Build Succeeded 👏

Build Id: 78d5fb2f-5dbc-482d-af34-455d8afe85f3

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.8.0-d9a8cd1
• image: gcr.io/agones-images/agones-sdk:1.8.0-d9a8cd1
• image: gcr.io/agones-images/agones-ping:1.8.0-d9a8cd1
• Linux C++ SDK (build): agonessdk-1.8.0-d9a8cd1-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.8.0-d9a8cd1.zip

A preview of the website (the last 30 builds are retained):

• https://d9a8cd1-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/1715/head:pr_1715 && git checkout pr_1715
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-d9a8cd1

[agones-bot]

Build Failed 😱

Build Id: 8201ae36-a578-4b48-bfdb-30333b69a0c1

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.