Integrated Helm into the build and development system
#170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the `sed` based templating and replaces it with a helm based workflow. All the `make` commands have stayed exactly the same. This also moves the existing 0.1 release helm chat to the 0.2 development chart, and includes the features that were otherwise missing for 0.2 If you have an existing development cluster, it may be easiest to delete them and recreate them, as the tooling will install helm automatically now on cluster creation. I also snuck in some small Kubernetes 1.9.x upgrades as well. Parent ticket: googleforgames#101
markmandel
added
the
area/build-tools
|
/cc @fooock |
|
Build Succeeded 👏 Build Id: e66af0ab-4b49-4ee6-a1e1-1601c477bdcd The following development artifacts have been built, and will exist for the next 30 days:
|
markmandel
added a commit
to markmandel/agones
that referenced
this pull request
Apr 9, 2018
This implements a `make gen-install` target that will generate the install.yaml via `helm template`. This also extends `make test` to have a test to ensure that the `install.yaml` is always kept up to sync with the Helm chart, otehrwise the build will fail. This does remove the explicit permissions for RBAC, but we don't have a specific need for them right now, so I feel it's worth the sacrifice to ensure these two configuration options stay in sync. Blocks on googleforgames#170, Parent ticket: googleforgames#101
cyriltovena
approved these changes
Apr 10, 2018
markmandel
added a commit
to markmandel/agones
that referenced
this pull request
Apr 10, 2018
This implements a `make gen-install` target that will generate the install.yaml via `helm template`. This also extends `make test` to have a test to ensure that the `install.yaml` is always kept up to sync with the Helm chart, otehrwise the build will fail. This does remove the explicit permissions for RBAC, but we don't have a specific need for them right now, so I feel it's worth the sacrifice to ensure these two configuration options stay in sync. Blocks on googleforgames#170, Parent ticket: googleforgames#101
markmandel
added a commit
to markmandel/agones
that referenced
this pull request
Apr 10, 2018
This implements a `make gen-install` target that will generate the install.yaml via `helm template`. This also extends `make test` to have a test to ensure that the `install.yaml` is always kept up to sync with the Helm chart, otehrwise the build will fail. This does remove the explicit permissions for RBAC, but we don't have a specific need for them right now, so I feel it's worth the sacrifice to ensure these two configuration options stay in sync. Blocks on googleforgames#170, Parent ticket: googleforgames#101
markmandel
added a commit
to markmandel/agones
that referenced
this pull request
Apr 10, 2018
This implements a `make gen-install` target that will generate the install.yaml via `helm template`. This also extends `make test` to have a test to ensure that the `install.yaml` is always kept up to sync with the Helm chart, otehrwise the build will fail. This does remove the explicit permissions for RBAC, but we don't have a specific need for them right now, so I feel it's worth the sacrifice to ensure these two configuration options stay in sync. Blocks on googleforgames#170, Parent ticket: googleforgames#101
markmandel
added a commit
to markmandel/agones
that referenced
this pull request
Apr 10, 2018
This implements a `make gen-install` target that will generate the install.yaml via `helm template`. This also extends `make test` to have a test to ensure that the `install.yaml` is always kept up to sync with the Helm chart, otehrwise the build will fail. This does remove the explicit permissions for RBAC, but we don't have a specific need for them right now, so I feel it's worth the sacrifice to ensure these two configuration options stay in sync. Blocks on googleforgames#170, Parent ticket: googleforgames#101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
sedbased templating and replaces it with a helm based workflow. All themakecommands have stayed exactly the same.This also moves the existing 0.1 release helm chat to the 0.2 development chart, and includes the features that were otherwise missing for 0.2
If you have an existing development cluster, it may be easiest to delete them and recreate them, as the tooling will install helm automatically now on cluster creation.
I also snuck in some small Kubernetes 1.9.x upgrades as well.
Parent ticket: #101