add gameserver values as configurable in helm terraform modules #1693

comerford · 2020-07-15T11:15:10Z

What type of PR is this?

/kind feature

What this PR does / Why we need it:

As described in Issue 1692 - this PR aims to add the gameserver variables (port range, namespaces) to the terraform module

Which issue(s) this PR fixes:

#1692

Closes #

Special notes for your reviewer:

install/terraform/modules/helm/helm.tf

install/terraform/modules/helm/variables.tf

install/terraform/modules/helm3/helm.tf

aLekSer

Thanks for the PR. We actually need these fields to be configurable, please consider applying comments.

agones-bot · 2020-07-15T11:35:54Z

Build Succeeded 👏

Build Id: 73c65a95-20de-46c7-9c78-a2b08da72df0

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.8.0-4f77bd2
image: gcr.io/agones-images/agones-sdk:1.8.0-4f77bd2
image: gcr.io/agones-images/agones-ping:1.8.0-4f77bd2
Linux C++ SDK (build): agonessdk-1.8.0-4f77bd2-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.8.0-4f77bd2.zip

A preview of the website (the last 30 builds are retained):

https://4f77bd2-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1693/head:pr_1693 && git checkout pr_1693
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-4f77bd2

Co-authored-by: Alexander Apalikov <[email protected]>

agones-bot · 2020-07-15T13:31:15Z

Build Succeeded 👏

Build Id: 94be3bbd-839e-4820-b271-bf946bd425ff

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.8.0-acd6817
image: gcr.io/agones-images/agones-sdk:1.8.0-acd6817
image: gcr.io/agones-images/agones-ping:1.8.0-acd6817
Linux C++ SDK (build): agonessdk-1.8.0-acd6817-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.8.0-acd6817.zip

A preview of the website (the last 30 builds are retained):

https://acd6817-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1693/head:pr_1693 && git checkout pr_1693
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-acd6817

agones-bot · 2020-07-15T13:37:04Z

Build Succeeded 👏

Build Id: a7d60c49-1ceb-4db3-a54f-cda6350517af

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.8.0-61abf22
image: gcr.io/agones-images/agones-sdk:1.8.0-61abf22
image: gcr.io/agones-images/agones-ping:1.8.0-61abf22
Linux C++ SDK (build): agonessdk-1.8.0-61abf22-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.8.0-61abf22.zip

A preview of the website (the last 30 builds are retained):

https://61abf22-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1693/head:pr_1693 && git checkout pr_1693
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-61abf22

install/terraform/modules/helm/helm.tf

install/terraform/modules/helm3/helm.tf

install/terraform/modules/helm/helm.tf

install/terraform/modules/helm3/helm.tf

Co-authored-by: Alexander Apalikov <[email protected]>

agones-bot · 2020-07-15T15:31:19Z

Build Failed 😱

Build Id: f5289ec0-8846-4c92-9aff-22fa065d3f44

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-07-15T15:40:18Z

Build Failed 😱

Build Id: 7354a4f4-de80-4fdc-b2ce-5a2203e8f18e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2020-07-27T21:31:28Z

Just confirming - this looks like it's waiting on a couple of small tweaks from @roberthbailey - is that correct?

roberthbailey · 2020-07-27T21:48:59Z

this looks like it's waiting on a couple of small tweaks from @roberthbailey - is that correct?

If you mean waiting on @comerford making small tweaks to address my feedback, then yes, that is my understanding.

markmandel

SGTM! Just putting this under "Request changes", so I don't forget and merge it accidentally.

comerford · 2020-07-30T23:37:28Z

Hey all - apologies for lack of action, I am on vacation at the moment, so having to make edits in the Github web interface rather than from a command line. I think I addressed the minor tweaks requested.

agones-bot · 2020-07-30T23:49:36Z

Build Failed 😱

Build Id: 7a63cf5d-4742-4b1f-ac3a-71efcb0df4e3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-07-30T23:57:01Z

Build Succeeded 👏

Build Id: b6d678cd-b894-442f-8381-d2470c1b0c0e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.8.0-8268872
image: gcr.io/agones-images/agones-sdk:1.8.0-8268872
image: gcr.io/agones-images/agones-ping:1.8.0-8268872
Linux C++ SDK (build): agonessdk-1.8.0-8268872-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.8.0-8268872.zip

A preview of the website (the last 30 builds are retained):

https://8268872-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1693/head:pr_1693 && git checkout pr_1693
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-8268872

agones-bot · 2020-07-31T00:06:48Z

Build Succeeded 👏

Build Id: 05cf83d0-2a29-44cc-9ccb-db20ed901ac6

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.8.0-94d1d3e
image: gcr.io/agones-images/agones-sdk:1.8.0-94d1d3e
image: gcr.io/agones-images/agones-ping:1.8.0-94d1d3e
Linux C++ SDK (build): agonessdk-1.8.0-94d1d3e-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.8.0-94d1d3e.zip

A preview of the website (the last 30 builds are retained):

https://94d1d3e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1693/head:pr_1693 && git checkout pr_1693
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-94d1d3e

agones-bot · 2020-07-31T00:12:59Z

Build Failed 😱

Build Id: 25f32712-acfc-45f4-ba0c-584bd03331f3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-07-31T00:17:51Z

Build Succeeded 👏

Build Id: 69c69622-c7c6-4dec-85e3-5dfbb0a76a88

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.8.0-6ee438d
image: gcr.io/agones-images/agones-sdk:1.8.0-6ee438d
image: gcr.io/agones-images/agones-ping:1.8.0-6ee438d
Linux C++ SDK (build): agonessdk-1.8.0-6ee438d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.8.0-6ee438d.zip

A preview of the website (the last 30 builds are retained):

https://6ee438d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1693/head:pr_1693 && git checkout pr_1693
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-6ee438d

google-oss-robot · 2020-07-31T19:31:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, comerford, markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…leforgames#1693) * add gameserver values as configurable in helm TF modules * Gating gameserver features for 1.8.0 release Co-authored-by: Alexander Apalikov <[email protected]>

add gameserver values as configurable in helm TF modules

4f77bd2

google-oss-robot requested review from markmandel and roberthbailey July 15, 2020 11:15

googlebot added the cla: yes label Jul 15, 2020

google-oss-robot added the size/M label Jul 15, 2020

aLekSer reviewed Jul 15, 2020

View reviewed changes

install/terraform/modules/helm/helm.tf Outdated Show resolved Hide resolved

aLekSer reviewed Jul 15, 2020

View reviewed changes

install/terraform/modules/helm/helm.tf Outdated Show resolved Hide resolved

aLekSer reviewed Jul 15, 2020

View reviewed changes

install/terraform/modules/helm/variables.tf Show resolved Hide resolved

aLekSer reviewed Jul 15, 2020

View reviewed changes

install/terraform/modules/helm3/helm.tf Show resolved Hide resolved

aLekSer reviewed Jul 15, 2020

View reviewed changes

install/terraform/modules/helm3/helm.tf Outdated Show resolved Hide resolved

aLekSer suggested changes Jul 15, 2020

View reviewed changes

google-oss-robot assigned aLekSer Jul 15, 2020

comerford and others added 3 commits July 15, 2020 14:06

Update install/terraform/modules/helm/helm.tf

61abf22

Co-authored-by: Alexander Apalikov <[email protected]>

Update install/terraform/modules/helm/helm.tf

b25e22f

Co-authored-by: Alexander Apalikov <[email protected]>

Update install/terraform/modules/helm3/helm.tf

acd6817

Co-authored-by: Alexander Apalikov <[email protected]>

aLekSer reviewed Jul 15, 2020

View reviewed changes

install/terraform/modules/helm/helm.tf Outdated Show resolved Hide resolved

aLekSer reviewed Jul 15, 2020

View reviewed changes

install/terraform/modules/helm3/helm.tf Outdated Show resolved Hide resolved

aLekSer reviewed Jul 15, 2020

View reviewed changes

install/terraform/modules/helm/helm.tf Outdated Show resolved Hide resolved

aLekSer reviewed Jul 15, 2020

View reviewed changes

install/terraform/modules/helm3/helm.tf Outdated Show resolved Hide resolved

aLekSer reviewed Jul 15, 2020

View reviewed changes

install/terraform/modules/helm3/helm.tf Outdated Show resolved Hide resolved

comerford and others added 5 commits July 15, 2020 16:17

Update install/terraform/modules/helm3/helm.tf

35d0640

Co-authored-by: Alexander Apalikov <[email protected]>

Update install/terraform/modules/helm3/helm.tf

c0450d6

Co-authored-by: Alexander Apalikov <[email protected]>

Update install/terraform/modules/helm/helm.tf

516a11f

Co-authored-by: Alexander Apalikov <[email protected]>

Update install/terraform/modules/helm3/helm.tf

40ff18d

Co-authored-by: Alexander Apalikov <[email protected]>

Update install/terraform/modules/helm/helm.tf

026be86

Co-authored-by: Alexander Apalikov <[email protected]>

google-oss-robot assigned roberthbailey Jul 21, 2020

roberthbailey removed the request for review from markmandel July 21, 2020 05:57

markmandel requested changes Jul 27, 2020

View reviewed changes

google-oss-robot assigned markmandel Jul 27, 2020

google-oss-robot removed the lgtm label Jul 27, 2020

comerford added 5 commits July 31, 2020 00:28

Remove extraneous blank line

94d1d3e

Gating gameserver settings for 1.8.0 release

a414a90

Gating gameserver features for 1.8.0 release

c82a8bd

Gating gameserver features for 1.8.0 release

8268872

Merge branch 'master' into install_terraform_module_add_helm_settings

6ee438d

comerford requested a review from markmandel July 30, 2020 23:38

roberthbailey approved these changes Jul 31, 2020

View reviewed changes

google-oss-robot added lgtm approved labels Jul 31, 2020

markmandel approved these changes Jul 31, 2020

View reviewed changes

markmandel merged commit 7ee4e1e into googleforgames:master Jul 31, 2020

markmandel added this to the 1.8.0 milestone Jul 31, 2020

markmandel added area/operations Installation, updating, metrics etc kind/feature New features for Agones labels Jul 31, 2020

comerford deleted the install_terraform_module_add_helm_settings branch August 19, 2020 09:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add gameserver values as configurable in helm terraform modules #1693

add gameserver values as configurable in helm terraform modules #1693

comerford commented Jul 15, 2020

aLekSer left a comment

agones-bot commented Jul 15, 2020

agones-bot commented Jul 15, 2020

agones-bot commented Jul 15, 2020

agones-bot commented Jul 15, 2020

agones-bot commented Jul 15, 2020

markmandel commented Jul 27, 2020

roberthbailey commented Jul 27, 2020

markmandel left a comment

comerford commented Jul 30, 2020

agones-bot commented Jul 30, 2020

agones-bot commented Jul 30, 2020

agones-bot commented Jul 31, 2020

agones-bot commented Jul 31, 2020

agones-bot commented Jul 31, 2020

google-oss-robot commented Jul 31, 2020

add gameserver values as configurable in helm terraform modules #1693

add gameserver values as configurable in helm terraform modules #1693

Conversation

comerford commented Jul 15, 2020

aLekSer left a comment

Choose a reason for hiding this comment

agones-bot commented Jul 15, 2020

agones-bot commented Jul 15, 2020

agones-bot commented Jul 15, 2020

agones-bot commented Jul 15, 2020

agones-bot commented Jul 15, 2020

markmandel commented Jul 27, 2020

roberthbailey commented Jul 27, 2020

markmandel left a comment

Choose a reason for hiding this comment

comerford commented Jul 30, 2020

agones-bot commented Jul 30, 2020

agones-bot commented Jul 30, 2020

agones-bot commented Jul 31, 2020

agones-bot commented Jul 31, 2020

agones-bot commented Jul 31, 2020

google-oss-robot commented Jul 31, 2020