Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for gcloud-terraform-cluster make target #1688

Merged
merged 3 commits into from
Jul 16, 2020
Merged

Fix for gcloud-terraform-cluster make target #1688

merged 3 commits into from
Jul 16, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Jul 13, 2020 •
edited
Loading

Update Terraform build config to use helm3 module.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature

/kind hotfix

What this PR does / Why we need it:

make gcloud-terraform-cluster is broken.

There is an issue with old module that in Dockerfile there is no Helm 2
binary and new one fails with meessage: Helm does not support helm init.

Which issue(s) this PR fixes:
none

Special notes for your reviewer:
Needed for the test #1483 to pass .

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 80364962-472f-49f1-9244-9f07883f8124

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer
Update Terraform make commands to use helm3 module
d1063be 
There is an issue with old module that in Dockerfile there is no Helm 2
binary and new one fails with meessage: Helm does not support `helm init`.
@aLekSer aLekSer force-pushed the terraform/update-build-config-to-helm-3 branch from 589ca17 to 9f095bb Compare July 15, 2020 08:42
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 98d1402b-ce47-4e6d-808f-a7bb6244ebc2

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1688/head:pr_1688 && git checkout pr_1688
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-9f095bb

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 60825e82-2d24-4b04-8386-dd6ddb55f5d6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1688/head:pr_1688 && git checkout pr_1688
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-589ca17

@google-oss-robot
Copy link

@akremsa: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aLekSer aLekSer force-pushed the terraform/update-build-config-to-helm-3 branch from 9f095bb to 611a6c9 Compare July 16, 2020 11:54
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 5e396f82-a8d3-46bf-9006-647b82f7dc9d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel
markmandel approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b250c3dc-17a6-4500-b598-fd7125e86da3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member 

--- FAIL: TestGameServerRestartBeforeReadyCrash (298.16s)
    gameserver_test.go:339: 
        	Error Trace:	gameserver_test.go:339
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestGameServerRestartBeforeReadyCrash

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9e1617cb-9f92-4a4b-8b9d-571f2c4aa5f5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1688/head:pr_1688 && git checkout pr_1688
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-6ca09a8

@markmandel markmandel merged commit c487966 into googleforgames:master Jul 16, 2020
@markmandel markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc labels Jul 16, 2020
@markmandel markmandel added this to the 1.8.0 milestone Jul 16, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@aLekSer @markmandel @ilkercelikyilmaz
Fix for gcloud-terraform-cluster make target (googleforgames#1688)
9526895 
* Update Terraform make commands to use helm3 module

There is an issue with old module that in Dockerfile there is no Helm 2
binary and new one fails with meessage: Helm does not support `helm init`.

* Fix helm3 -> helm command in the docs

Co-authored-by: Mark Mandel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akremsa akremsa akremsa approved these changes

@markmandel markmandel markmandel approved these changes

@EricFortin EricFortin Awaiting requested review from EricFortin

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees

@markmandel markmandel

Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
6 participants
@aLekSer @agones-bot @google-oss-robot @markmandel @akremsa @googlebot