Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Invert ContainerPortAllocation FeatureGate #1652

Merged

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Jun 26, 2020

ContainerPortAllocation now turned on by default, switching it off for E2E tests.

An idea behind is to invert all FeatureGates compared to default values for a second E2E test run.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

ContainerPortAllocation now turned on by default, switching it off for
E2E tests.
@aLekSer aLekSer added the area/tests Unit tests, e2e tests, anything to make sure things don't break label Jun 26, 2020
@markmandel
Copy link
Member

That is a very good point! Nice catch!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 94f67237-6097-4890-b179-1a0cff6f6ef0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1652/head:pr_1652 && git checkout pr_1652
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-68aee59

@markmandel markmandel added this to the 1.7.0 milestone Jun 26, 2020
@markmandel markmandel merged commit a02a6fe into googleforgames:master Jun 26, 2020
@aLekSer aLekSer deleted the e2e/switchContainerPortFeatureGate branch June 26, 2020 18:34
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
ContainerPortAllocation now turned on by default, switching it off for
E2E tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break cla: yes lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants