Agones 1641 Terraform GKE - Adding Subnetwork for custom VPC #1648

moesy · 2020-06-25T04:52:52Z

When creating a GKE cluster in Terraform with a non-default (custom) VPC
the subnetwork must be specified otherwise the operation will fail with an expected error.

Expected error when subnetwork isn't set:

"Error: googleapi: Error 400: Network "MY-VPC-NAME" requires specifying a subnetwork., badRequest"

User should follow the instructions in README.md and specify the required fields based on whether
the cluster will run in a default VPC or custom VPC.

Tests performed:

Able to create cluster in default VPC in a backward-compatible way - passed
Able to create cluster in a user-defined non-default network and subnetwork - passed

Reference

What type of PR is this?
/kind bug

What this PR does / Why we need it:
This PR fixes a bug with deploying Agones in a custom VPC and enhances the documentation around terraform deployment.

Which issue(s) this PR fixes:
Closes #1641

Special notes for your reviewer:
When testing locally the source in the gke_cluster module must be changed.

moesy · 2020-06-25T05:11:02Z

/assign @dzlier-gcp

agones-bot · 2020-06-25T05:25:02Z

Build Succeeded 👏

Build Id: 0177fe82-e01a-41e2-9d62-4bed65d151b2

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.7.0-ad7e038
image: gcr.io/agones-images/agones-sdk:1.7.0-ad7e038
image: gcr.io/agones-images/agones-ping:1.7.0-ad7e038
Linux C++ SDK (build): agonessdk-1.7.0-ad7e038-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.7.0-ad7e038.zip

A preview of the website (the last 30 builds are retained):

https://ad7e038-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1648/head:pr_1648 && git checkout pr_1648
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-ad7e038

agones-bot · 2020-06-25T14:53:33Z

Build Succeeded 👏

Build Id: 424da18e-af8f-43de-a621-bc3bdf212419

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.7.0-859d34d
image: gcr.io/agones-images/agones-sdk:1.7.0-859d34d
image: gcr.io/agones-images/agones-ping:1.7.0-859d34d
Linux C++ SDK (build): agonessdk-1.7.0-859d34d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.7.0-859d34d.zip

A preview of the website (the last 30 builds are retained):

https://859d34d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1648/head:pr_1648 && git checkout pr_1648
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-859d34d

agones-bot · 2020-06-25T15:46:09Z

Build Succeeded 👏

Build Id: 8d06c38c-b068-4675-803d-ef37033851ad

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.7.0-5cb4891
image: gcr.io/agones-images/agones-sdk:1.7.0-5cb4891
image: gcr.io/agones-images/agones-ping:1.7.0-5cb4891
Linux C++ SDK (build): agonessdk-1.7.0-5cb4891-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.7.0-5cb4891.zip

A preview of the website (the last 30 builds are retained):

https://5cb4891-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1648/head:pr_1648 && git checkout pr_1648
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-5cb4891

agones-bot · 2020-06-25T16:30:47Z

Build Failed 😱

Build Id: 3ea6722d-843f-41f9-ba4c-dc59876ae94d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

moesy · 2020-06-25T16:37:59Z

agones-bot test seems to be failing because of a race condition when referencing the terraform modules from the master branch as opposed to locally since those changes are not merged yet.

Tests referencing the modules locally succeed.

markmandel

Outside of having the network defaults to default, I can't think of anything else.

No issues on my end of breaking it up into separate files.

@aLekSer any thoughts?

markmandel · 2020-06-25T16:49:40Z

examples/terraform-submodules/gke/README.md

+## Create an Agones cluster in a custom VPC.
+Required fields:
+- project
+- network


Can we make it so that the default value for network & subnetwork is the default one?

So people don't have to specify it if they don't want to worry about networking?

Hi @markmandel it already does.

Create an Agones cluster in a default VPC.

Required fields:

project

OOOH! I didn't read it correctly. Got it. Thanks! 👍

So, the only other comment I would make is - all these docs, should be part of https://agones.dev/site/docs/installation/terraform/gke/

Not as a README in this directory 😄

Have a look at https://agones.dev/site/docs/contribute/ on how to use feature shortcodes so we can hide the new functionality until the next release.

Sg! I will try to find time today for this change.

So, the only other comment I would make is - all these docs, should be part of https://agones.dev/site/docs/installation/terraform/gke/

Agree, that is where we keep all the docs which touch users.

markmandel · 2020-06-25T16:52:59Z

Uh it's this flakiness again /usr/share/dotnet/sdk/2.2.402/NuGet.targets(123,5): error : The file '/go/src/agones.dev/agones/sdks/csharp/sdk/obj/csharp-sdk.csproj.nuget.g.props' already exists. [/go/src/agones.dev/agones/sdks/csharp/test/csharp-sdk-test.csproj] (#1639)

markmandel · 2020-06-26T19:11:16Z

I just did some cleanup on the e2e cluster, I hope I didn't break your build 😬

agones-bot · 2020-06-26T19:21:03Z

Build Succeeded 👏

Build Id: f13eb084-e466-4cf0-9570-854913c09f66

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.7.0-162e3b8
image: gcr.io/agones-images/agones-sdk:1.7.0-162e3b8
image: gcr.io/agones-images/agones-ping:1.7.0-162e3b8
Linux C++ SDK (build): agonessdk-1.7.0-162e3b8-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.7.0-162e3b8.zip

A preview of the website (the last 30 builds are retained):

https://162e3b8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1648/head:pr_1648 && git checkout pr_1648
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-162e3b8

examples/terraform-submodules/gke/variables.tf

examples/terraform-submodules/gke/.gitignore

examples/terraform-submodules/gke/README.md

install/terraform/modules/gke/cluster.tf

aLekSer

@moesy Thanks for an update. There are two changes here:

Splitting out the example code (ideally this can be done as a separate PR)
Please take into account a guide which has an instruction to download only one gke/module.tf file

agones/site/content/en/docs/Installation/Terraform/gke.md

Lines 70 to 73 in 93df9e3

    
           An example configuration can be found here: 
        
            {{< ghlink href="examples/terraform-submodules/gke/module.tf" >}}Terraform configuration with Agones submodule{{< /ghlink >}}.  
        
           Copy this file into a local directory where you will execute the terraform commands.

Adding the subnetwork which should be done, but please apply all the comments, I assume there is no need to extend required parameters.

markmandel · 2020-07-14T20:27:31Z

Just checking in here, to see if this work is still ongoing?

moesy · 2020-07-16T14:25:09Z

Hey @markmandel I will reprioritize this this afternoon.

agones-bot · 2020-07-16T14:46:15Z

Build Succeeded 👏

Build Id: eea21794-b123-466a-a16b-df2a205febf1

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.8.0-72e25f4
image: gcr.io/agones-images/agones-sdk:1.8.0-72e25f4
image: gcr.io/agones-images/agones-ping:1.8.0-72e25f4
Linux C++ SDK (build): agonessdk-1.8.0-72e25f4-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.8.0-72e25f4.zip

A preview of the website (the last 30 builds are retained):

https://72e25f4-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1648/head:pr_1648 && git checkout pr_1648
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-72e25f4

agones-bot · 2020-07-17T05:37:05Z

Build Failed 😱

Build Id: 77e647fa-b2e4-4830-b549-ec2d201dde15

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-07-17T06:05:42Z

Build Failed 😱

Build Id: 15a408e8-40ab-4661-ab31-8450ffc384f3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

google-oss-robot · 2020-07-17T06:14:18Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: moesy
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

moesy · 2020-07-17T06:19:32Z

Reset to master. Not sure why it auto closed it. Will open a separate PR.

google-oss-robot requested review from dzlier-gcp and roberthbailey June 25, 2020 04:52

googlebot added the cla: yes label Jun 25, 2020

google-oss-robot added the size/L label Jun 25, 2020

google-oss-robot assigned dzlier-gcp Jun 25, 2020

markmandel reviewed Jun 25, 2020

View reviewed changes

markmandel requested review from aLekSer and removed request for dzlier-gcp June 25, 2020 16:53

markmandel added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Jun 30, 2020

roberthbailey reviewed Jul 7, 2020

View reviewed changes

examples/terraform-submodules/gke/variables.tf Outdated Show resolved Hide resolved

examples/terraform-submodules/gke/.gitignore Outdated Show resolved Hide resolved

aLekSer reviewed Jul 7, 2020

View reviewed changes

examples/terraform-submodules/gke/README.md Outdated Show resolved Hide resolved

aLekSer reviewed Jul 7, 2020

View reviewed changes

install/terraform/modules/gke/cluster.tf Outdated Show resolved Hide resolved

aLekSer reviewed Jul 7, 2020

View reviewed changes

install/terraform/modules/gke/cluster.tf Outdated Show resolved Hide resolved

aLekSer suggested changes Jul 7, 2020

View reviewed changes

google-oss-robot assigned aLekSer Jul 7, 2020

aLekSer changed the title ~~Agones 1641~~ Agones 1641 Terraform GKE - Adding Subnetwork for custom VPC Jul 7, 2020

markmandel removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Jul 7, 2020

moesy force-pushed the agones-1641 branch from f44f312 to 7ddabe0 Compare July 17, 2020 05:54

google-oss-robot added size/XS and removed size/L labels Jul 17, 2020

moesy closed this Jul 17, 2020

moesy force-pushed the agones-1641 branch from 7ddabe0 to f9f4a26 Compare July 17, 2020 06:14

aLekSer mentioned this pull request Sep 3, 2020

Examples: update Kubernetes version #1787

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Agones 1641 Terraform GKE - Adding Subnetwork for custom VPC #1648

Agones 1641 Terraform GKE - Adding Subnetwork for custom VPC #1648

moesy commented Jun 25, 2020 •

edited

Loading

moesy commented Jun 25, 2020

agones-bot commented Jun 25, 2020

agones-bot commented Jun 25, 2020

agones-bot commented Jun 25, 2020

agones-bot commented Jun 25, 2020

moesy commented Jun 25, 2020 •

edited

Loading

markmandel left a comment

markmandel Jun 25, 2020

moesy Jun 25, 2020 •

edited

Loading

markmandel Jun 25, 2020

moesy Jun 25, 2020

aLekSer Jun 30, 2020 •

edited

Loading

markmandel commented Jun 25, 2020

markmandel commented Jun 26, 2020

agones-bot commented Jun 26, 2020

aLekSer left a comment

markmandel commented Jul 14, 2020

moesy commented Jul 16, 2020

agones-bot commented Jul 16, 2020

agones-bot commented Jul 17, 2020

agones-bot commented Jul 17, 2020

google-oss-robot commented Jul 17, 2020

moesy commented Jul 17, 2020 •

edited

Loading

	An example configuration can be found here:
	{{< ghlink href="examples/terraform-submodules/gke/module.tf" >}}Terraform configuration with Agones submodule{{< /ghlink >}}.

	Copy this file into a local directory where you will execute the terraform commands.

Agones 1641 Terraform GKE - Adding Subnetwork for custom VPC #1648

Agones 1641 Terraform GKE - Adding Subnetwork for custom VPC #1648

Conversation

moesy commented Jun 25, 2020 • edited Loading

moesy commented Jun 25, 2020

agones-bot commented Jun 25, 2020

agones-bot commented Jun 25, 2020

agones-bot commented Jun 25, 2020

agones-bot commented Jun 25, 2020

moesy commented Jun 25, 2020 • edited Loading

markmandel left a comment

Choose a reason for hiding this comment

markmandel Jun 25, 2020

Choose a reason for hiding this comment

moesy Jun 25, 2020 • edited Loading

Choose a reason for hiding this comment

Create an Agones cluster in a default VPC.

markmandel Jun 25, 2020

Choose a reason for hiding this comment

moesy Jun 25, 2020

Choose a reason for hiding this comment

aLekSer Jun 30, 2020 • edited Loading

Choose a reason for hiding this comment

markmandel commented Jun 25, 2020

markmandel commented Jun 26, 2020

agones-bot commented Jun 26, 2020

aLekSer left a comment

Choose a reason for hiding this comment

markmandel commented Jul 14, 2020

moesy commented Jul 16, 2020

agones-bot commented Jul 16, 2020

agones-bot commented Jul 17, 2020

agones-bot commented Jul 17, 2020

google-oss-robot commented Jul 17, 2020

moesy commented Jul 17, 2020 • edited Loading

moesy commented Jun 25, 2020 •

edited

Loading

moesy commented Jun 25, 2020 •

edited

Loading

moesy Jun 25, 2020 •

edited

Loading

aLekSer Jun 30, 2020 •

edited

Loading

moesy commented Jul 17, 2020 •

edited

Loading