Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateNamespace: delete dangling namespaces #1632

Merged
merged 3 commits into from
Jun 22, 2020
Merged

CreateNamespace: delete dangling namespaces #1632

merged 3 commits into from
Jun 22, 2020

Conversation

akremsa
Copy link
Contributor

@akremsa akremsa commented Jun 18, 2020

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:
Previously, in case of an error in CreateNamespace function on the step where a namespace has already been created, test fails, and recently created namespace remains.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d88cf04e-adb6-43ba-8c67-b601daf1d63e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1632/head:pr_1632 && git checkout pr_1632
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-2c95714

@akremsa akremsa force-pushed the delete-namespaces branch from 2c95714 to 55cf726 Compare June 22, 2020 10:27
@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4a2f2151-9a39-49af-875c-49048d1114d0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1632/head:pr_1632 && git checkout pr_1632
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-55cf726

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: cbec678f-967f-4336-9904-e1c30dc94ec1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1632/head:pr_1632 && git checkout pr_1632
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-e2cf77c

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 54ce4a56-dc8f-4e4e-8f54-1b3a8dbb8e1f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1632/head:pr_1632 && git checkout pr_1632
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-d885a11

@markmandel markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc labels Jun 22, 2020
@markmandel markmandel added this to the 1.7.0 milestone Jun 22, 2020
@markmandel markmandel merged commit 2d9e583 into googleforgames:master Jun 22, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@alexey-kremsa-globant @pooneh-m
@markmandel @ilkercelikyilmaz
e2e tests: delete dangling namespaces on CreateNamespace (googleforga…
f6b3223 
…mes#1632)

Co-authored-by: pooneh-m <[email protected]>
Co-authored-by: Mark Mandel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pooneh-m pooneh-m pooneh-m approved these changes

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

Assignees

@pooneh-m pooneh-m

Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/S
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
7 participants
@akremsa @agones-bot @google-oss-robot @pooneh-m @markmandel @googlebot @alexey-kremsa-globant