-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add port flag to example allocator-client #1618
Add port flag to example allocator-client #1618
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Thanks for the change @robbieheywood. Please also include the flag in the example here: https://github.com/googleforgames/agones/blob/master/site/content/en/docs/Advanced/allocator-service.md |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pooneh-m, robbieheywood The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Succeeded 👏 Build Id: fa6a0cf3-acbf-44bc-b927-59f34f975ef9 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
9bea142
to
ca50303
Compare
New changes are detected. LGTM label has been removed. |
Thanks for the review @pooneh-m - hopefully this is now good to go 👍 |
Build Failed 😱 Build Id: 3cbc1278-63a7-422c-85b4-89659f1fabac To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: f9d64c54-ea6c-42ff-b55a-f498b04fb544 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
That's a new flaky one I haven't seen before:
Never gets to Ready and times out. |
Build Succeeded 👏 Build Id: 830c5324-d0fa-49bb-bba6-55441f97eb40 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Thanks @robbieheywood! |
* Add port flag to example allocator-client * Add to docs Co-authored-by: Mark Mandel <[email protected]>
What type of PR is this?
/kind feature
What this PR does / Why we need it:
It adds the ability to specify
--port <port>
when using the allocator-client in examples/allocator-client. Without this, you can only use this allocator-client to hit allocators exposed on port 443. We expose our allocator through istio on a non-443 port, so this change is required to use the client to test our allocator.Which issue(s) this PR fixes:
n/a - haven't raised a corresponding issue (but I'm happy to if required).
Special notes for your reviewer:
I've tested this by running
go run examples/allocator-client/main.go --ip <allocator-ip> --namespace game-scavengers --key tls.key --cert tls.crt --cacert ca.crt --port <port>
against a v1.6 allocator running in GKE, exposed on a non-443 port, and it succeeded. Let me know if you feel this needs any more testing.