Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add port flag to example allocator-client #1618

Conversation

robbieheywood
Copy link
Contributor

@robbieheywood robbieheywood commented Jun 6, 2020

What type of PR is this?
/kind feature

What this PR does / Why we need it:
It adds the ability to specify --port <port> when using the allocator-client in examples/allocator-client. Without this, you can only use this allocator-client to hit allocators exposed on port 443. We expose our allocator through istio on a non-443 port, so this change is required to use the client to test our allocator.

Which issue(s) this PR fixes:

n/a - haven't raised a corresponding issue (but I'm happy to if required).

Special notes for your reviewer:
I've tested this by running go run examples/allocator-client/main.go --ip <allocator-ip> --namespace game-scavengers --key tls.key --cert tls.crt --cacert ca.crt --port <port> against a v1.6 allocator running in GKE, exposed on a non-443 port, and it succeeded. Let me know if you feel this needs any more testing.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@robbieheywood
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@pooneh-m
Copy link
Contributor

pooneh-m commented Jun 6, 2020

Thanks for the change @robbieheywood. Please also include the flag in the example here: https://github.com/googleforgames/agones/blob/master/site/content/en/docs/Advanced/allocator-service.md

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pooneh-m, robbieheywood

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fa6a0cf3-acbf-44bc-b927-59f34f975ef9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1618/head:pr_1618 && git checkout pr_1618
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-9bea142

@robbieheywood robbieheywood force-pushed the feature/allocation-client-port-flag branch from 9bea142 to ca50303 Compare June 7, 2020 21:53
@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@robbieheywood
Copy link
Contributor Author

Thanks for the review @pooneh-m - hopefully this is now good to go 👍

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 3cbc1278-63a7-422c-85b4-89659f1fabac

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f9d64c54-ea6c-42ff-b55a-f498b04fb544

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

That's a new flaky one I haven't seen before:

time="2020-06-07 22:29:37.009" level=info msg="sent UDP packet" address="34.82.230.193:7320" test=TestGameServerUnhealthyAfterReadyCrash
time="2020-06-07 22:29:37.225" level=info msg="Waiting for states to match" awaitingState=Ready currentState=Unhealthy gs=udp-servernpl27
time="2020-06-07 22:29:38.221" level=info msg="Waiting for states to match" awaitingState=Ready currentState=Unhealthy gs=udp-servernpl27
time="2020-06-07 22:29:39.222" level=info msg="Waiting for states to match" awaitingState=Ready currentState=Unhealthy gs=udp-servernpl27
time="2020-06-07 22:29:40.222" level=info msg="Waiting for states to match" awaitingState=Ready currentState=Unhealthy gs=udp-servernpl2

Never gets to Ready and times out.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 830c5324-d0fa-49bb-bba6-55441f97eb40

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1618/head:pr_1618 && git checkout pr_1618
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-c7897f2

@pooneh-m
Copy link
Contributor

pooneh-m commented Jun 8, 2020

Thanks @robbieheywood!

@pooneh-m pooneh-m merged commit 6cacbf7 into googleforgames:master Jun 8, 2020
@robbieheywood robbieheywood deleted the feature/allocation-client-port-flag branch June 8, 2020 21:28
@markmandel markmandel added this to the 1.7.0 milestone Jun 30, 2020
@markmandel markmandel added area/examples Examples. Usually found in the `examples` directory kind/feature New features for Agones labels Jun 30, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
* Add port flag to example allocator-client

* Add to docs

Co-authored-by: Mark Mandel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/examples Examples. Usually found in the `examples` directory kind/feature New features for Agones size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants