Release 1.6.0-rc #1574

markmandel · 2020-05-19T23:45:55Z

What type of PR is this?
/kind release

What this PR does / Why we need it:
Release of 1.6.0 Release Candidate!

Which issue(s) this PR fixes:
None.

Special notes for your reviewer:

Also needed to fix some publishExpiry values, and update the featureGate of the Allocation system.

markmandel · 2020-05-19T23:46:25Z

site/content/en/blog/releases/1.6.0-rc.md

+This release includes **several breaking changes** to be aware of:
+
+- Upgrade to required Kubernetes version to 1.15
+- Alpha Multi Cluster allocator has been renamed, refactored slightly and moved to Stable.


@pooneh-m just confirming language here on MC allocation -- this sound good to you?

Sounds great. Thanks! 🙏 Please see my note on changing the version to beta instead of stable.

Cool. Reworded things slightly here to reflect below, PTAL.

markmandel · 2020-05-19T23:46:38Z

site/content/en/docs/Guides/feature-stages.md

@@ -35,7 +35,7 @@ The current set of `alpha` and `beta` feature gates are:
 {{% feature publishVersion="1.6.0" %}}
 | Feature Name | Gate    | Default | Stage | Since |
 |--------------|---------|---------|-------|-------|
-| Multicluster Allocation<sup>*</sup> | N/A | Enabled | `Alpha` | 0.11.0 |
+| Multicluster Allocation<sup>*</sup> | N/A | Enabled | `Stable` | 1.6.0 |


@pooneh-m also confirming this change is good?

How about keep the feature at the Beta stage for one release? The APIs are at the stable version. Nothing is expected to change in terms of functionality between beta and stable. However, we mark the feature as a stable candidate, in case there are more feedback.

Also, please remove "Multicluster Allocation was started before this process was in place, and therefore is enabled by default"

The footnote still partly applies. New features are supposed to have a feature gate and be disableable in beta, but since we started MCA before the process was in place it doesn't have a feature gate and can't be turned off. So maybe updating to "Multicluster Allocation was started before this process was in place, and therefore does not have a feature gate and cannot be disabled" would be the most accurate.

@pooneh-m - I like keeping it at Beta - that's a good call.
@roberthbailey - I also like that language, I've dropped that in.

agones-bot · 2020-05-20T00:03:38Z

Build Succeeded 👏

Build Id: 888e0a55-2fb9-41ed-a2c2-31d9743af45e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-f93153c
image: gcr.io/agones-images/agones-sdk:1.6.0-f93153c
image: gcr.io/agones-images/agones-ping:1.6.0-f93153c
Linux C++ SDK (build): agonessdk-1.6.0-f93153c-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-f93153c.zip

A preview of the website (the last 30 builds are retained):

https://f93153c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1574/head:pr_1574 && git checkout pr_1574
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-f93153c

roberthbailey · 2020-05-20T00:33:21Z

You had a few questions for @pooneh-m so I'm not going to merge this yet.

markmandel · 2020-05-20T01:02:54Z

Thanks - will wrap this up tomorrow.

Also needed to fix some publishExpiry values, and update the featureGate of the Allocation system.

agones-bot · 2020-05-20T15:07:39Z

Build Failed 😱

Build Id: 7d5b011a-8721-4cfc-a45d-e3c6c9f40217

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-05-20T16:02:03Z

Build Succeeded 👏

Build Id: 42342c8a-040e-4570-9005-c5fb3cf0427e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-d183884
image: gcr.io/agones-images/agones-sdk:1.6.0-d183884
image: gcr.io/agones-images/agones-ping:1.6.0-d183884
Linux C++ SDK (build): agonessdk-1.6.0-d183884-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-d183884.zip

A preview of the website (the last 30 builds are retained):

https://d183884-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1574/head:pr_1574 && git checkout pr_1574
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-d183884

markmandel · 2020-05-20T16:09:41Z

I had to include a fix for retrying site-test since it was failing, because of github rate limiting, and well -- not retrying like it should 🙂

roberthbailey

lgtm

google-oss-robot · 2020-05-20T16:22:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel,pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2020-05-20T16:22:39Z

Build Succeeded 👏

Build Id: 08c19bff-08bd-43be-9e2a-7f07041095d4

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-019352f
image: gcr.io/agones-images/agones-sdk:1.6.0-019352f
image: gcr.io/agones-images/agones-ping:1.6.0-019352f
Linux C++ SDK (build): agonessdk-1.6.0-019352f-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-019352f.zip

A preview of the website (the last 30 builds are retained):

https://019352f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1574/head:pr_1574 && git checkout pr_1574
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-019352f

pooneh-m · 2020-05-20T16:23:21Z

Looks great. Go 1.6-rc... \o/

* Release 1.6.0-rc Also needed to fix some publishExpiry values, and update the featureGate of the Allocation system.

markmandel added the kind/release Checklist for a release label May 19, 2020

google-oss-robot requested review from pooneh-m and steven-supersolid May 19, 2020 23:46

google-oss-robot added approved size/L labels May 19, 2020

markmandel commented May 19, 2020

View reviewed changes

markmandel requested review from aLekSer and roberthbailey and removed request for steven-supersolid May 19, 2020 23:48

roberthbailey approved these changes May 20, 2020

View reviewed changes

google-oss-robot assigned roberthbailey May 20, 2020

google-oss-robot added the lgtm label May 20, 2020

Release 1.6.0-rc

a6ac852

Also needed to fix some publishExpiry values, and update the featureGate of the Allocation system.

markmandel force-pushed the release/1.6.0-rc branch from f93153c to a6ac852 Compare May 20, 2020 14:56

google-oss-robot removed the lgtm label May 20, 2020

Fix for htmltest retry

019352f

markmandel force-pushed the release/1.6.0-rc branch from d183884 to 019352f Compare May 20, 2020 16:02

roberthbailey approved these changes May 20, 2020

View reviewed changes

google-oss-robot added the lgtm label May 20, 2020

pooneh-m approved these changes May 20, 2020

View reviewed changes

google-oss-robot assigned pooneh-m May 20, 2020

roberthbailey merged commit 7e02d6f into googleforgames:master May 20, 2020

markmandel deleted the release/1.6.0-rc branch May 20, 2020 16:33

markmandel added this to the 1.6.0 milestone May 26, 2020

ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020

Release 1.6.0-rc (googleforgames#1574)

e164231

* Release 1.6.0-rc Also needed to fix some publishExpiry values, and update the featureGate of the Allocation system.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 1.6.0-rc #1574

Release 1.6.0-rc #1574

markmandel commented May 19, 2020

markmandel May 19, 2020

pooneh-m May 20, 2020 •

edited

Loading

markmandel May 20, 2020

markmandel May 19, 2020

pooneh-m May 20, 2020 •

edited

Loading

roberthbailey May 20, 2020

markmandel May 20, 2020

agones-bot commented May 20, 2020

roberthbailey commented May 20, 2020

markmandel commented May 20, 2020

agones-bot commented May 20, 2020

agones-bot commented May 20, 2020

markmandel commented May 20, 2020

roberthbailey left a comment

google-oss-robot commented May 20, 2020

agones-bot commented May 20, 2020

pooneh-m commented May 20, 2020

Release 1.6.0-rc #1574

Release 1.6.0-rc #1574

Conversation

markmandel commented May 19, 2020

markmandel May 19, 2020

Choose a reason for hiding this comment

pooneh-m May 20, 2020 • edited Loading

Choose a reason for hiding this comment

markmandel May 20, 2020

Choose a reason for hiding this comment

markmandel May 19, 2020

Choose a reason for hiding this comment

pooneh-m May 20, 2020 • edited Loading

Choose a reason for hiding this comment

roberthbailey May 20, 2020

Choose a reason for hiding this comment

markmandel May 20, 2020

Choose a reason for hiding this comment

agones-bot commented May 20, 2020

roberthbailey commented May 20, 2020

markmandel commented May 20, 2020

agones-bot commented May 20, 2020

agones-bot commented May 20, 2020

markmandel commented May 20, 2020

roberthbailey left a comment

Choose a reason for hiding this comment

google-oss-robot commented May 20, 2020

agones-bot commented May 20, 2020

pooneh-m commented May 20, 2020

pooneh-m May 20, 2020 •

edited

Loading

pooneh-m May 20, 2020 •

edited

Loading