-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Player Tracking SDK Reference #1564
Player Tracking SDK Reference #1564
Conversation
Build Succeeded 👏 Build Id: 756deb48-a200-46e0-83aa-07fb30551b21 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
site/layouts/shortcodes/alpha.html
Outdated
<p>The {{ $title }} feature is currently <strong><a href="{{ ref . "/docs/Guides/feature-stages.md#alpha" }}">Alpha</a></strong>, | ||
not enabled by default, and may change in the future.</p> | ||
<p>Use the Feature Gate <code>{{- $gate }}</code> to enable and test this feature.</p> | ||
<p>See the <a href="{{ ref . "/docs/Guides/feature-stages.md#alpha" }}">Feature Gate documentation</a> for details on how to enable features.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two links here go to the same place. I'm not sure that page actually helps me if I want to enable this feature gate (indicating that we might need some more documentation around that particular scenario).
Also, I noticed that player tracking isn't in the table at the top of that page: https://773f473-dot-preview-dot-agones-images.appspot.com/site/docs/guides/feature-stages/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link might be more useful for the second case:
https://773f473-dot-preview-dot-agones-images.appspot.com/site/docs/guides/feature-stages/#feature-gates
Alpha and Beta features can be enabled or disabled through the agones.featureGates configuration option that can be found in the Helm configuration documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I noticed that player tracking isn't in the table at the top of that page: https://773f473-dot-preview-dot-agones-images.appspot.com/site/docs/guides/feature-stages/
That's the next PR. I have a Player Tracking actual guide that I wanted to link from there, but also wanted this page first to point to. This one seemed long enough on it's own to review.
The two links here go to the same place.
Ah! Good catch both of you. I think I meant that to go to #feature-gates and fumbled it. Making that change.
Reference for the general Player Tracking SDK API. This included some slight reorganising, to make it less cluttered as we add more functionality. To come, is a full player tracking guide, and updates to the GameServer reference. Work on googleforgames#1033
773f473
to
f71ef10
Compare
Build Failed 😱 Build Id: 84fab3f2-2286-4809-adcb-612467f16336 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: c46fa7e1-e4e7-4c16-bd5b-80f3ba391959 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Build Succeeded 👏 Build Id: 49dff430-6acc-4ec3-b788-46864fd61978 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Reference for the general Player Tracking SDK API. This included some slight reorganising, to make it less cluttered as we add more functionality. To come, is a full player tracking guide, and updates to the GameServer reference. Work on googleforgames#1033
What type of PR is this?
/kind documentation
What this PR does / Why we need it:
Reference for the general Player Tracking SDK API.
This included some slight reorganising, to make it less cluttered as we
add more functionality.
Which issue(s) this PR fixes:
Work on #1033
Special notes for your reviewer:
To come, is a full player tracking guide, and updates to the GameServer
reference.