-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add one more E2E tests run with all feature gates disabled #1546
CI: Add one more E2E tests run with all feature gates disabled #1546
Conversation
cloudbuild.yaml
Outdated
- name: 'e2e-runner-release' | ||
args: [''] | ||
waitFor: | ||
- e2e-runner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line could be redundant, as consul lock
should not allow this to happen simultaneously.
baff8dd
to
7c03e36
Compare
Build Failed 😱 Build Id: 5bc7f20f-8946-476d-8035-08399e4976b2 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
7c03e36
to
5668c28
Compare
Build Failed 😱 Build Id: 386e0fc2-e9b9-4079-942b-f0a68b80f3e1 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
5668c28
to
4000600
Compare
The downside of this PR, that now a probability of flaky tests appearance would roughly about twice times much than before (for small appearance chance or for test success |
Build Succeeded 👏 Build Id: 2a0f190d-3be9-409b-ab9a-b081c3741c8d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
4000600
to
c1cf998
Compare
Build Failed 😱 Build Id: be641b53-b6e9-4f36-8d65-c29d1745bb8c To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
c1cf998
to
96c0ba5
Compare
set -e | ||
echo "installing current release" | ||
DOCKER_RUN= make install | ||
DOCKER_RUN= make install FEATURE_GATES='"'$FEATURES'"' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This '"'
is needed to prevent &featureGate
from being used as new command:
helm upgrade --install --wait --namespace=agones-system\
--set agones.featureGates=123&saf \
agones /go/src/agones.dev/agones/install/helm/agones/
bin/sh: saf: command not found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory you could also use something like "none=false", or something else nonsensical. Just an idea.
Build Failed 😱 Build Id: 0b709056-3a72-42ef-9a28-c488ae30a7a9 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
96c0ba5
to
b62ed24
Compare
Build Failed 😱 Build Id: c45f2165-d25f-443b-a6f2-25f6e703626c To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Today there are a bunch of errors on loading some binaries:
Similar error on loading helm with agones/build/e2e-image/Dockerfile Line 26 in 37e6fa6
|
b62ed24
to
5df2245
Compare
Build Succeeded 👏 Build Id: f971f306-cf53-4311-a671-05cb2da1becb The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Time of CI build with 2 E2E tests steps (each about 5 min) is 19 min 41 sec compared to previous 15 min 51 sec. |
@markmandel This change makes |
Build Failed 😱 Build Id: cf85b712-f741-4642-8b01-9145aab60764 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
E2E test fail in:
One more strange message:
|
Build Failed 😱 Build Id: 712078ca-9039-4096-9de4-e1a7750ec954 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
New E2E test fail, @pooneh-m this might be interesting to you:
|
set -e | ||
echo "installing current release" | ||
DOCKER_RUN= make install | ||
DOCKER_RUN= make install FEATURE_GATES='"'$FEATURES'"' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory you could also use something like "none=false", or something else nonsensical. Just an idea.
waitFor: | ||
- push-images | ||
- build-e2e | ||
|
||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would run one after the other, yes?
Is this where we should be looking at prow, so we can run this in parallel? @roberthbailey ?
Build Failed 😱 Build Id: 94a01cd2-275c-41be-9a1e-15ff912f63ec To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Maybe we update our e2e scripts so that we can pass in the name of the cluster - then we could spin up more thank 1 cluster, so we could do this in parralel? WDYT? |
Yes, I will add an ability to select a cluster. |
Build Succeeded 👏 Build Id: 49a9e8f3-c399-4c7e-ab33-6f38f226a8a2 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aLekSer I'm going to approve this PR.
Let's add the ability to select a cluster, and running the e2e tests in another cluster as part of a separate PR. Sound good?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aLekSer, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Build Failed 😱 Build Id: 8f00dbc7-f8ad-4b6f-ab32-ce93a08a7042 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Seems like this shows up from time to time, or is it just me? (Wondering if we should file a flaky bug on it) Of course the downside of this is that we're twice as likely to get e2e flakes 🙁 |
Build Failed 😱 Build Id: 89267cc5-ffc0-437e-946b-df9501abe9b5 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 227d25db-ecbf-4369-b960-3c0494e5903f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Add one more E2E tests step with FeatureGates disabled - stable version. Add parameter to e2e-runner step to switch between FeatureGates. Co-authored-by: Mark Mandel <[email protected]>
Run E2E tests with FeatureGates disabled.
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Which issue(s) this PR fixes:
For #1411
Special notes for your reviewer: