Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: add Grafana version explicitly #1487

Merged
merged 2 commits into from
Apr 24, 2020
Merged

Docs: add Grafana version explicitly #1487

merged 2 commits into from
Apr 24, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Apr 23, 2020

Set Grafana version to the docs.
Add new make target helm-repo-update.

What type of PR is this?
/kind documentation

What this PR does / Why we need it:
User can install previous version of the Grafana 6.2 which does not support new GameServers dashboard. This could lead to an error, which is hard to debug (but this error caused by missing bargauge):

undefined is not iterable (cannot read property Symbol(Symbol.iterator)) in grafana

Which issue(s) this PR fixes:

Leftover of #1465.
Met in #1479.

Special notes for your reviewer:

BarGauge

@aLekSer aLekSer requested a review from cyriltovena April 23, 2020 11:15
@aLekSer aLekSer force-pushed the docs/grafana-version branch from 2a4fe32 to 390f124 Compare April 23, 2020 11:15
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b40f1cc2-a87e-45d1-b7da-b4f01127f6e9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1487/head:pr_1487 && git checkout pr_1487
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-2a4fe32

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c09d3f18-58f8-4d1d-8a85-56217b6c8548

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1487/head:pr_1487 && git checkout pr_1487
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-390f124

@roberthbailey roberthbailey requested review from markmandel and removed request for EricFortin and roberthbailey April 23, 2020 16:39
markmandel
markmandel reviewed Apr 23, 2020
View reviewed changes
site/content/en/docs/Guides/metrics.md Outdated
@@ -190,8 +190,8 @@ kubectl apply -f ./build/grafana/
Now we can install [grafana chart](https://github.com/helm/charts/tree/master/stable/grafana) from stable repository. (Replace `<your-admin-password>` with the admin password of your choice)

```bash
helm install --wait --name grafana stable/grafana --namespace metrics \
--set adminPassword=<your-admin-password> -f ../build/grafana.yaml
helm install --wait --name grafana stable/grafana --version=5.0.11 --namespace metrics \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyriltovena any issue with specifying a specific version?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No you can even make it latest. We release 6.7.3. Always good to be up to date.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which is 5.0.13 btw

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.0.13 chart is still appVersion 6.7.1:
https://github.com/helm/charts/blob/866bf2f655ede9aa1bb6f4145db5862035cf49ad/stable/grafana/Chart.yaml#L4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.0.13 is the latest helm chart too. 👍

cyriltovena
cyriltovena approved these changes Apr 24, 2020
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can even make it 5.0.13 if you want.

LGTM

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, cyriltovena

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aLekSer
Docs: add Grafana version explicitly
7fd5c85 
Add new make target `helm-repo-update`.
@aLekSer aLekSer force-pushed the docs/grafana-version branch from 390f124 to baf967e Compare April 24, 2020 12:45
@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@aLekSer aLekSer force-pushed the docs/grafana-version branch from baf967e to 3d501f4 Compare April 24, 2020 12:56
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ad6ec15e-c19b-4458-beed-b4a6ee9cf6e3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1487/head:pr_1487 && git checkout pr_1487
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-baf967e

@aLekSer
Update Grafana chart to 5.0.13
8fed988 
Grafana version still 6.7.1 but Helm chart got changes.
Make target and website, add license header.
@aLekSer aLekSer force-pushed the docs/grafana-version branch from 3d501f4 to 8fed988 Compare April 24, 2020 13:05
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7915638c-8e4c-4b46-8a45-f7f98e593d12

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1487/head:pr_1487 && git checkout pr_1487
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-3d501f4

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 385e8d1a-e087-47f3-8eea-f07e896ae6fd

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1487/head:pr_1487 && git checkout pr_1487
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-8fed988

@markmandel markmandel merged commit b134abb into googleforgames:master Apr 24, 2020
@markmandel markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Apr 24, 2020
@markmandel markmandel added this to the 1.6.0 milestone May 19, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@aLekSer @ilkercelikyilmaz
Docs: add Grafana version explicitly (googleforgames#1487)
360983d 
* Docs: add Grafana version explicitly

Add new make target `helm-repo-update`.

* Update Grafana chart to 5.0.13

Grafana version still 6.7.1 but Helm chart got changes.
Make target and website, add license header.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel left review comments

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees

@cyriltovena cyriltovena

Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones size/S
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@aLekSer @agones-bot @google-oss-robot @markmandel @cyriltovena