Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.5.0 #1473

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Release 1.5.0 #1473

merged 1 commit into from
Apr 14, 2020

Conversation

markmandel
Copy link
Member

Tweaked the ordering in the release checklist closer to what I usually do as well.

@markmandel markmandel added the kind/release Checklist for a release label Apr 14, 2020
@markmandel markmandel added this to the 1.5.0 milestone Apr 14, 2020
@aLekSer
Copy link
Collaborator

aLekSer commented Apr 14, 2020

Just for curiosity's sake: In the release process, where goes the step make build-images && make push?

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5d29a9ed-c22f-49b4-9250-20d004af9402

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1473/head:pr_1473 && git checkout pr_1473
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-9c1065c

aLekSer
aLekSer reviewed Apr 14, 2020
View reviewed changes
site/content/en/docs/Reference/gameserver.md Outdated
@@ -183,27 +108,6 @@ The `spec` field is the actual GameServer specification and it is composed as fo
- `grpcPort` the port that the SDK Server binds to for gRPC connections
- `httpPort` the port that the SDK Server binds to for HTTP gRPC gateway connections
- `template` the [pod spec template](https://v1-13.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.13/#podtemplatespec-v1-core) to run your GameServer containers, [see](https://kubernetes.io/docs/concepts/workloads/pods/pod-overview/#pod-templates) for more information.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be more recent version:
https://v1-14.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.14/

@aLekSer
Copy link
Collaborator

aLekSer commented Apr 14, 2020 •
edited
Loading

@markmandel please look through the md files if they still contains old version of Kubernetes docs. I got such an error in chrome and Not found page if proceed with wrong certificate:

v1-13.docs.kubernetes.io 
NET::ERR_CERT_COMMON_NAME_INVALID

@markmandel
Release 1.5.0
80aee4d 
Tweaked the ordering in the release checklist closer to what
I usually do as well.
@markmandel
Copy link
Member Author

Nice catch! Fixed.

@markmandel
Copy link
Member Author

Just for curiosity's sake: In the release process, where goes the step make build-images && make push?

All part of make do-release

aLekSer
aLekSer approved these changes Apr 14, 2020
View reviewed changes
Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aLekSer
Copy link
Collaborator

aLekSer commented Apr 14, 2020 •
edited
Loading

I understood why make hugo-test did not catch https://gcr.io/agones-images/agones-controller:1.5.0 - the image is absent, but the link is working.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 24ab3067-0e0a-4fd9-a738-73ee432b44dd

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1473/head:pr_1473 && git checkout pr_1473
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-80aee4d

@markmandel markmandel merged commit 6b737be into googleforgames:master Apr 14, 2020
@markmandel markmandel deleted the release/1.5.0 branch April 14, 2020 21:28
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @ilkercelikyilmaz
Release 1.5.0 (googleforgames#1473)
043043c 
Tweaked the ordering in the release checklist closer to what
I usually do as well.
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @ilkercelikyilmaz
Release 1.5.0 (googleforgames#1473)
f8665c7 
Tweaked the ordering in the release checklist closer to what
I usually do as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aLekSer aLekSer aLekSer approved these changes

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

@steven-supersolid steven-supersolid Awaiting requested review from steven-supersolid

Assignees

@aLekSer aLekSer

Labels
approved kind/release Checklist for a release lgtm size/L
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @aLekSer @agones-bot @google-oss-robot