Update the agones-allocator doc to recommend using cert-manager #1459

pooneh-m · 2020-04-09T18:07:01Z

As the first step towards #1461, updating the documentation.

agones-bot · 2020-04-09T18:26:10Z

Build Succeeded 👏

Build Id: 7dfaedc4-ef8b-4047-8e36-f3a165e03089

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-e32701f
image: gcr.io/agones-images/agones-sdk:1.5.0-e32701f
image: gcr.io/agones-images/agones-ping:1.5.0-e32701f
Linux C++ SDK (build): agonessdk-1.5.0-e32701f-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-e32701f.zip

A preview of the website (the last 30 builds are retained):

https://e32701f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1459/head:pr_1459 && git checkout pr_1459
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-e32701f

site/content/en/docs/Advanced/allocator-service.md

agones-bot · 2020-04-09T19:03:20Z

Build Succeeded 👏

Build Id: 2d043d6b-69cf-4fd9-98c1-9f7431fa4bb9

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-11360d2
image: gcr.io/agones-images/agones-sdk:1.5.0-11360d2
image: gcr.io/agones-images/agones-ping:1.5.0-11360d2
Linux C++ SDK (build): agonessdk-1.5.0-11360d2-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-11360d2.zip

A preview of the website (the last 30 builds are retained):

https://11360d2-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1459/head:pr_1459 && git checkout pr_1459
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-11360d2

markmandel

This is neat! Added a few comments!

site/content/en/docs/Advanced/allocator-service.md

…ssuing the service certificate

agones-bot · 2020-04-10T06:11:54Z

Build Succeeded 👏

Build Id: 376cc1ab-0f01-47a7-82e4-097a1f8ac462

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-10e0a48
image: gcr.io/agones-images/agones-sdk:1.5.0-10e0a48
image: gcr.io/agones-images/agones-ping:1.5.0-10e0a48
Linux C++ SDK (build): agonessdk-1.5.0-10e0a48-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-10e0a48.zip

A preview of the website (the last 30 builds are retained):

https://10e0a48-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1459/head:pr_1459 && git checkout pr_1459
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-10e0a48

markmandel · 2020-04-10T21:36:51Z

site/content/en/docs/Advanced/allocator-service.md

+    kind: ClusterIssuer
+EOF
+
+# Optional: Store the secret ca.crt in a file to be used by the client for the server authentication


markmandel · 2020-04-10T21:38:02Z

I'm not sure - I'm happy to approve this, but should it be merged before the stable comes out next week or after?

I'm thinking after, but I'm open to other arguments?

pooneh-m · 2020-04-10T22:17:02Z

Yes it should be released with 1.5 as it provides a better suggestion on managing server certificates on the cluster vs one time issuing and using a certificate. In the future, we may integrate the solution into Agones #1461 if it makes sense.

markmandel

let's get this live!

google-oss-robot · 2020-04-15T20:54:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel,pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2020-04-15T21:14:18Z

Build Succeeded 👏

Build Id: 51ca7655-c02e-4d81-9e68-9b184ab23df4

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-0f233f8
image: gcr.io/agones-images/agones-sdk:1.6.0-0f233f8
image: gcr.io/agones-images/agones-ping:1.6.0-0f233f8
Linux C++ SDK (build): agonessdk-1.6.0-0f233f8-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-0f233f8.zip

A preview of the website (the last 30 builds are retained):

https://0f233f8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1459/head:pr_1459 && git checkout pr_1459
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-0f233f8

…ssuing the service certificate (googleforgames#1459) Co-authored-by: Mark Mandel <[email protected]>

pooneh-m requested a review from markmandel April 9, 2020 18:07

google-oss-robot requested review from cyriltovena and dzlier-gcp April 9, 2020 18:07

google-oss-robot added approved size/M labels Apr 9, 2020

pooneh-m removed request for cyriltovena and dzlier-gcp April 9, 2020 18:07

aLekSer reviewed Apr 9, 2020

View reviewed changes

site/content/en/docs/Advanced/allocator-service.md Outdated Show resolved Hide resolved

pooneh-m force-pushed the fuzz_fix branch from e32701f to 11360d2 Compare April 9, 2020 18:45

markmandel reviewed Apr 9, 2020

View reviewed changes

site/content/en/docs/Advanced/allocator-service.md Outdated Show resolved Hide resolved

site/content/en/docs/Advanced/allocator-service.md Outdated Show resolved Hide resolved

aLekSer reviewed Apr 9, 2020

View reviewed changes

site/content/en/docs/Advanced/allocator-service.md Outdated Show resolved Hide resolved

Update the agones-allocator doc to recommend using cert-manager for i…

10e0a48

…ssuing the service certificate

pooneh-m force-pushed the fuzz_fix branch from 11360d2 to 10e0a48 Compare April 10, 2020 05:55

markmandel reviewed Apr 10, 2020

View reviewed changes

markmandel added kind/documentation Documentation for Agones kind/feature New features for Agones labels Apr 10, 2020

Merge branch 'master' into fuzz_fix

0f233f8

markmandel approved these changes Apr 15, 2020

View reviewed changes

google-oss-robot assigned markmandel Apr 15, 2020

google-oss-robot added the lgtm label Apr 15, 2020

markmandel merged commit e7c430b into googleforgames:master Apr 15, 2020

markmandel added this to the 1.6.0 milestone Apr 15, 2020

ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020

Update the agones-allocator doc to recommend using cert-manager for i…

55cb21f

…ssuing the service certificate (googleforgames#1459) Co-authored-by: Mark Mandel <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the agones-allocator doc to recommend using cert-manager #1459

Update the agones-allocator doc to recommend using cert-manager #1459

pooneh-m commented Apr 9, 2020 •

edited

Loading

agones-bot commented Apr 9, 2020

agones-bot commented Apr 9, 2020

markmandel left a comment

agones-bot commented Apr 10, 2020

markmandel Apr 10, 2020

markmandel commented Apr 10, 2020

pooneh-m commented Apr 10, 2020 •

edited

Loading

markmandel left a comment

google-oss-robot commented Apr 15, 2020

agones-bot commented Apr 15, 2020

Update the agones-allocator doc to recommend using cert-manager #1459

Update the agones-allocator doc to recommend using cert-manager #1459

Conversation

pooneh-m commented Apr 9, 2020 • edited Loading

agones-bot commented Apr 9, 2020

agones-bot commented Apr 9, 2020

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Apr 10, 2020

markmandel Apr 10, 2020

Choose a reason for hiding this comment

markmandel commented Apr 10, 2020

pooneh-m commented Apr 10, 2020 • edited Loading

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Apr 15, 2020

agones-bot commented Apr 15, 2020

pooneh-m commented Apr 9, 2020 •

edited

Loading

pooneh-m commented Apr 10, 2020 •

edited

Loading