Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry logic in htmltest #1429

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

markmandel
Copy link
Member

Looks like the rate of html requests to Github has been lowered which is causing errors with our CI process.

This will retry the test, to resolve rate issues or intermittent external link issues.

Looks like the rate of html requests to Github has been lowered
which is causing errors with our CI process.

This will retry the test, to resolve rate issues or intermittent
external link issues.
@markmandel markmandel added kind/bug These are bugs. area/tests Unit tests, e2e tests, anything to make sure things don't break labels Mar 26, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4d688993-5b27-44a9-aed8-7c6ea4e08d86

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1429/head:pr_1429 && git checkout pr_1429
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-32d17a9

Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that it solves the issue!
I will just leave the similar ticket from the project itself:
wjdp/htmltest#105
Unfortunately there is no config parameter to rate limit htmltest itself.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aLekSer aLekSer merged commit 04cef7f into googleforgames:master Mar 26, 2020
@markmandel markmandel deleted the tests/retry-htmltest branch March 26, 2020 13:51
@markmandel markmandel added this to the 1.5.0 milestone Mar 26, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Looks like the rate of html requests to Github has been lowered
which is causing errors with our CI process.

This will retry the test, to resolve rate issues or intermittent
external link issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break kind/bug These are bugs. lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants