Add validation for CPU and Memory Resources for GameServers, Fleets and GameServerSets #1423

aLekSer · 2020-03-20T14:37:39Z

Validate Requests and Limits for each PodTemplate Container. Will be
used by GameServer, Fleet and GameServerSet.

aLekSer · 2020-03-20T14:40:59Z

This one should be merged after #1418 as it contains 2 commits from it.
As an example of why I put validateResource() separately.
There is no option to import k8s.io/kubernetes/pkg/apis/core/validation there is a special ticket for it.
See for the reference this ticket:
elastic/cloud-on-k8s#1765 and kubernetes/kubernetes#80316 (comment)

aLekSer · 2020-03-20T14:41:20Z

Example of this working:

$ kubectl apply -f /Users/user/go/src/github.com/agones/agones/examples/simple-udp/fleet.yaml                                                           
The Fleet "" is invalid: container: Request must be less than or equal to memory limit
by-it00060:build user$ kubectl create -f /Users/user/go/src/github.com/agones/agones/examples/cpp-simple/gameserver.yaml                                                     
The GameServer "" is invalid: container: Request must be less than or equal to memory limit
$ kubectl create -f /Users/user/go/src/github.com/agones/agones/examples/cpp-simple/gameserver.yaml                                                     
The GameServer "" is invalid:
* container: Request must be less than or equal to memory limit
* container: Resource memory limit value must be non negative

agones-bot · 2020-03-20T14:53:57Z

Build Succeeded 👏

Build Id: 4d0f7701-cb10-4fad-bc3d-2e7e4971611a

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-11f3e10
image: gcr.io/agones-images/agones-sdk:1.5.0-11f3e10
image: gcr.io/agones-images/agones-ping:1.5.0-11f3e10
Linux C++ SDK (build): agonessdk-1.5.0-11f3e10-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-11f3e10.zip

A preview of the website (the last 30 builds are retained):

https://11f3e10-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1423/head:pr_1423 && git checkout pr_1423
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-11f3e10

agones-bot · 2020-03-24T12:39:31Z

Build Succeeded 👏

Build Id: 363ba691-d55d-4496-8653-8ece2a20a89f

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-30d8dae
image: gcr.io/agones-images/agones-sdk:1.5.0-30d8dae
image: gcr.io/agones-images/agones-ping:1.5.0-30d8dae
Linux C++ SDK (build): agonessdk-1.5.0-30d8dae-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-30d8dae.zip

A preview of the website (the last 30 builds are retained):

https://30d8dae-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1423/head:pr_1423 && git checkout pr_1423
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-30d8dae

agones-bot · 2020-04-06T09:06:30Z

Build Failed 😱

Build Id: 4a9dc021-ccd2-4fb9-9000-2cc5096ffe7a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-04-06T09:35:12Z

Build Succeeded 👏

Build Id: 5ae38b84-3033-4173-85d4-2eb4a797ba94

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-def0219
image: gcr.io/agones-images/agones-sdk:1.5.0-def0219
image: gcr.io/agones-images/agones-ping:1.5.0-def0219
Linux C++ SDK (build): agonessdk-1.5.0-def0219-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-def0219.zip

A preview of the website (the last 30 builds are retained):

https://def0219-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1423/head:pr_1423 && git checkout pr_1423
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-def0219

agones-bot · 2020-04-06T12:00:52Z

Build Succeeded 👏

Build Id: 88df03a2-375c-45b7-88da-5b26ece80ed2

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-719d5da
image: gcr.io/agones-images/agones-sdk:1.5.0-719d5da
image: gcr.io/agones-images/agones-ping:1.5.0-719d5da
Linux C++ SDK (build): agonessdk-1.5.0-719d5da-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-719d5da.zip

A preview of the website (the last 30 builds are retained):

https://719d5da-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1423/head:pr_1423 && git checkout pr_1423
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-719d5da

agones-bot · 2020-04-06T19:58:42Z

Build Succeeded 👏

Build Id: e5166837-7b76-45f0-a926-f443d25f272b

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-aa5c613
image: gcr.io/agones-images/agones-sdk:1.5.0-aa5c613
image: gcr.io/agones-images/agones-ping:1.5.0-aa5c613
Linux C++ SDK (build): agonessdk-1.5.0-aa5c613-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-aa5c613.zip

A preview of the website (the last 30 builds are retained):

https://aa5c613-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1423/head:pr_1423 && git checkout pr_1423
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-aa5c613

Validate Requests and Limits for each PodTemplate Container. Will be used by GameServer, Fleet and GameServerset.

agones-bot · 2020-04-07T07:18:54Z

Build Failed 😱

Build Id: 1e29e312-a7ba-4a36-a22d-3af86627d86c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2020-04-07T07:26:10Z

New E2E test is failing:

Step #22: time="2020-04-07 07:17:18.960" level=info msg="waiting for fleet condition" fleet=simple-fleet-x8b55
Step #22: --- FAIL: TestFleetRecreateGameServers (0.19s)
Step #22:     --- FAIL: TestFleetRecreateGameServers/gameserver_shutdown (106.10s)
Step #22:         fleet_test.go:1087: Could not message GameServer: read udp 192.168.10.3:46528->34.83.149.154:7776: i/o timeout

markmandel

This looks good to me! Will Approve once we're out of feature freeze.

agones-bot · 2020-04-09T18:14:23Z

Build Succeeded 👏

Build Id: 94f78ba0-26ed-4ef4-8f82-3d8d82cb1f3f

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-a47b042
image: gcr.io/agones-images/agones-sdk:1.5.0-a47b042
image: gcr.io/agones-images/agones-ping:1.5.0-a47b042
Linux C++ SDK (build): agonessdk-1.5.0-a47b042-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-a47b042.zip

A preview of the website (the last 30 builds are retained):

https://a47b042-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1423/head:pr_1423 && git checkout pr_1423
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-a47b042

markmandel

Out of feature freeze!

google-oss-robot · 2020-04-15T00:40:04Z

New changes are detected. LGTM label has been removed.

google-oss-robot · 2020-04-15T00:40:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2020-04-15T00:40:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2020-04-15T00:51:01Z

Build Failed 😱

Build Id: f6308130-b65c-4620-a91f-b06a6c9c609a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-04-15T01:52:30Z

Build Succeeded 👏

Build Id: ecf28a44-4bfa-4c1f-8cfe-f2f78e28ec28

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-bfb0dd9
image: gcr.io/agones-images/agones-sdk:1.6.0-bfb0dd9
image: gcr.io/agones-images/agones-ping:1.6.0-bfb0dd9
Linux C++ SDK (build): agonessdk-1.6.0-bfb0dd9-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-bfb0dd9.zip

A preview of the website (the last 30 builds are retained):

https://bfb0dd9-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1423/head:pr_1423 && git checkout pr_1423
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-bfb0dd9

agones-bot · 2020-04-15T03:07:25Z

Build Succeeded 👏

Build Id: 4c4c3ebd-61bb-4276-ba83-fa5844ebb0cd

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-8bc3bec
image: gcr.io/agones-images/agones-sdk:1.6.0-8bc3bec
image: gcr.io/agones-images/agones-ping:1.6.0-8bc3bec
Linux C++ SDK (build): agonessdk-1.6.0-8bc3bec-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-8bc3bec.zip

A preview of the website (the last 30 builds are retained):

https://8bc3bec-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1423/head:pr_1423 && git checkout pr_1423
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-8bc3bec

Validate Requests and Limits for each PodTemplate Container. Will be used by GameServer, Fleet and GameServerset. Co-authored-by: Mark Mandel <[email protected]>

google-oss-robot added the do-not-merge/work-in-progress label Mar 20, 2020

google-oss-robot requested review from cyriltovena and pooneh-m March 20, 2020 14:37

google-oss-robot added the size/L label Mar 20, 2020

aLekSer force-pushed the validate-pod-template branch from 11f3e10 to 30d8dae Compare March 24, 2020 12:21

google-oss-robot added size/S and removed size/L labels Mar 24, 2020

aLekSer force-pushed the validate-pod-template branch from 30d8dae to ea6b138 Compare April 6, 2020 08:58

google-oss-robot added size/L and removed size/S labels Apr 6, 2020

aLekSer force-pushed the validate-pod-template branch from ea6b138 to def0219 Compare April 6, 2020 09:18

aLekSer marked this pull request as ready for review April 6, 2020 09:40

google-oss-robot removed the do-not-merge/work-in-progress label Apr 6, 2020

aLekSer force-pushed the validate-pod-template branch from def0219 to 719d5da Compare April 6, 2020 11:44

Add validation for CPU and Memory resources

f9e9b14

Validate Requests and Limits for each PodTemplate Container. Will be used by GameServer, Fleet and GameServerset.

aLekSer force-pushed the validate-pod-template branch from aa5c613 to f9e9b14 Compare April 7, 2020 07:02

markmandel added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Apr 7, 2020

markmandel reviewed Apr 9, 2020

View reviewed changes

markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones labels Apr 9, 2020

Merge branch 'master' into validate-pod-template

a47b042

markmandel removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Apr 14, 2020

markmandel approved these changes Apr 15, 2020

View reviewed changes

google-oss-robot assigned markmandel Apr 15, 2020

google-oss-robot added the lgtm label Apr 15, 2020

Merge branch 'master' into validate-pod-template

bfb0dd9

google-oss-robot removed the lgtm label Apr 15, 2020

google-oss-robot added the approved label Apr 15, 2020

Merge branch 'master' into validate-pod-template

8bc3bec

markmandel merged commit 84f5eef into googleforgames:master Apr 15, 2020

markmandel added this to the 1.6.0 milestone Apr 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add validation for CPU and Memory Resources for GameServers, Fleets and GameServerSets #1423

Add validation for CPU and Memory Resources for GameServers, Fleets and GameServerSets #1423

aLekSer commented Mar 20, 2020 •

edited

Loading

aLekSer commented Mar 20, 2020 •

edited

Loading

aLekSer commented Mar 20, 2020

agones-bot commented Mar 20, 2020

agones-bot commented Mar 24, 2020

agones-bot commented Apr 6, 2020

agones-bot commented Apr 6, 2020

agones-bot commented Apr 6, 2020

agones-bot commented Apr 6, 2020

agones-bot commented Apr 7, 2020

aLekSer commented Apr 7, 2020

markmandel left a comment

agones-bot commented Apr 9, 2020

markmandel left a comment

google-oss-robot commented Apr 15, 2020

google-oss-robot commented Apr 15, 2020

google-oss-robot commented Apr 15, 2020

agones-bot commented Apr 15, 2020

agones-bot commented Apr 15, 2020

agones-bot commented Apr 15, 2020

Add validation for CPU and Memory Resources for GameServers, Fleets and GameServerSets #1423

Add validation for CPU and Memory Resources for GameServers, Fleets and GameServerSets #1423

Conversation

aLekSer commented Mar 20, 2020 • edited Loading

aLekSer commented Mar 20, 2020 • edited Loading

aLekSer commented Mar 20, 2020

agones-bot commented Mar 20, 2020

agones-bot commented Mar 24, 2020

agones-bot commented Apr 6, 2020

agones-bot commented Apr 6, 2020

agones-bot commented Apr 6, 2020

agones-bot commented Apr 6, 2020

agones-bot commented Apr 7, 2020

aLekSer commented Apr 7, 2020

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Apr 9, 2020

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Apr 15, 2020

google-oss-robot commented Apr 15, 2020

google-oss-robot commented Apr 15, 2020

agones-bot commented Apr 15, 2020

agones-bot commented Apr 15, 2020

agones-bot commented Apr 15, 2020

aLekSer commented Mar 20, 2020 •

edited

Loading

aLekSer commented Mar 20, 2020 •

edited

Loading