Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Build Node.js version to 12 #1405

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Upgrade Build Node.js version to 12 #1405

merged 1 commit into from
Mar 12, 2020

Conversation

akremsa
Copy link
Contributor

@akremsa akremsa commented Mar 10, 2020 •
edited
Loading

PR closes #1272 issue.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5f9e3d31-392e-47a9-b0c3-9c68ccbc6bb4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1405/head:pr_1405 && git checkout pr_1405
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-544c512

@roberthbailey
Copy link
Member

/assign @steven-supersolid

@roberthbailey roberthbailey requested review from steven-supersolid and removed request for cyriltovena and dzlier-gcp March 10, 2020 16:01
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, roberthbailey, steven-supersolid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit ecbdb11 into googleforgames:master Mar 12, 2020
@markmandel markmandel added this to the 1.5.0 milestone Apr 7, 2020
@markmandel markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc labels Apr 7, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@alexey-kremsa-globant @ilkercelikyilmaz
1272 Upgrade Build Node.js version to 12 (googleforgames#1405)
a3efb01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@steven-supersolid steven-supersolid steven-supersolid approved these changes

Assignees

@steven-supersolid steven-supersolid

@roberthbailey roberthbailey

Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

[Deprecation] Upgrade Build Node.js version to 12
7 participants
@akremsa @agones-bot @roberthbailey @google-oss-robot @steven-supersolid @markmandel @alexey-kremsa-globant