Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mangled lists in C++ guide #1393

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Conversation

akremsa
Copy link
Contributor

@akremsa akremsa commented Mar 5, 2020

This PR is related to #1379

Now it looks like this:

image

Closes #1379

@akremsa
Copy link
Contributor Author

akremsa commented Mar 5, 2020

/assign @pooneh-m

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: da6c3958-8a79-4c09-8b60-65f71aad3267

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1393/head:pr_1393 && git checkout pr_1393
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-a5abb95

Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, now it looks much better.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akremsa, aLekSer
To complete the pull request process, please assign pooneh-m
You can assign the PR to them by writing /assign @pooneh-m in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aLekSer aLekSer merged commit ba2656c into googleforgames:master Mar 5, 2020
@markmandel markmandel added this to the 1.5.0 milestone Apr 7, 2020
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Apr 7, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C++ Game Server Client SDK documentation formatting
7 participants