Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add crd-client image to release template #1378

Merged
merged 1 commit into from
Feb 29, 2020
Merged

Add crd-client image to release template #1378

merged 1 commit into from
Feb 29, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Feb 28, 2020

Add crd-client image details.

@aLekSer aLekSer changed the title Add new image to release template Add crd-client image to release template Feb 28, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: af29f4cc-c965-45d8-abc5-795958c9485c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1378/head:pr_1378 && git checkout pr_1378
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-ce512d8

cyriltovena
cyriltovena approved these changes Feb 28, 2020
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, cyriltovena

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit b072354 into googleforgames:master Feb 29, 2020
@markmandel markmandel added area/meta Organisational matters. e.g. Governance, release cycles, etc. kind/cleanup Refactoring code, fixing up documentation, etc labels Feb 29, 2020
@markmandel markmandel added this to the 1.4.0 milestone Feb 29, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@aLekSer @ilkercelikyilmaz
Add new image to release template (googleforgames#1378)
2faf6fa 
Add crd-client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

Assignees

@cyriltovena cyriltovena

Labels
approved area/meta Organisational matters. e.g. Governance, release cycles, etc. kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@aLekSer @agones-bot @google-oss-robot @cyriltovena @markmandel