Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UE4 readme to communicate development information #1360

Merged
merged 2 commits into from
Mar 2, 2020
Merged

UE4 readme to communicate development information #1360

merged 2 commits into from
Mar 2, 2020

Conversation

drichardson
Copy link
Contributor

@domgreen mentioned adding a README in #1358

The purpose of this PR is to create a README that provides developer guidelines for the Agones plugin for UE4.

I intentionally created the PR while it is a work in progress to solicit feedback from the other UE4 plugin developers, who I believe are: @domgreen, @YannickLange, @WVerlaek, @roberthbailey, @markmandel.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b1d03da3-d88a-450e-aacc-375f017b970f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1360/head:pr_1360 && git checkout pr_1360
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-7142c0c

@drichardson
Copy link
Contributor Author

@domgreen and @roberthbailey please take a look and let me know what you think.

@drichardson
Copy link
Contributor Author

/assign @pooneh-m

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d3b5a3d2-3805-491a-b488-2fe98add3ee6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1360/head:pr_1360 && git checkout pr_1360
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-b00b4cf

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f622fc89-08a6-4c2e-b6fc-148a5919b4e6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1360/head:pr_1360 && git checkout pr_1360
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-3be8dc2

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 8b5129df-f399-463e-8fdb-4c99e57bf653

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1360/head:pr_1360 && git checkout pr_1360
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-59a4bf8

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 210e4210-a770-4a13-963f-43787b3a7883

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1360/head:pr_1360 && git checkout pr_1360
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-8dfd68f

@drichardson
Copy link
Contributor Author

drichardson commented Feb 26, 2020 •
edited
Loading

@markmandel While I was in CONTRIBUTING, I made a change to the C++ formatting rules to follow the UE4 coding standards rather than google, but only for the UE4 plugin code.

@drichardson
Copy link
Contributor Author

drichardson commented Feb 26, 2020 •
edited
Loading

Additionally, I changed the PR instructions to build against the latest version of UE4, because:

  1. I don't know what the minimum supported version of UE4 is for the plugin
  2. I don't want to overburden people making PRs

Let me know what you think.

@drichardson
Copy link
Contributor Author

I'm fixing some markdown problems still (which I need to push to see). I'll let you know when it's ready for another review.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3c59f0fe-0d0c-4fb3-b6f6-44164b890552

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1360/head:pr_1360 && git checkout pr_1360
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-62888a8

@drichardson
Copy link
Contributor Author

OK, it's ready for review again.

@drichardson
Copy link
Contributor Author

OK, now it's REALLY ready ;)

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e1ef0c60-e76d-4e82-88ed-360646ce1582

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1360/head:pr_1360 && git checkout pr_1360
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-f06721a

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c5830caa-dfdb-4eaa-ab7b-1e426d31f054

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 24f0e733-1d7c-4f96-8723-546c3a2aeb01

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1360/head:pr_1360 && git checkout pr_1360
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-64b91a3

@drichardson drichardson mentioned this pull request Feb 26, 2020
Closed
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3725326a-0534-48ae-9dda-60ee2846995c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1360/head:pr_1360 && git checkout pr_1360
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-53b5127

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 86e39bbe-ac59-47fc-94b2-dff533dbea62

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1360/head:pr_1360 && git checkout pr_1360
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-4c5759e

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 090f2d68-5b58-4132-bf71-3ac274888582

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c27b3132-1e31-468b-826c-ebb4023f9481

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1360/head:pr_1360 && git checkout pr_1360
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-5836b9a

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: cdceb9ec-80ae-4d79-8dd3-3cee724a23f8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1360/head:pr_1360 && git checkout pr_1360
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-c3b5d93

domgreen
domgreen reviewed Feb 27, 2020
View reviewed changes
CONTRIBUTING.md Show resolved Hide resolved
sdks/unreal/Agones/README.md Outdated Show resolved Hide resolved
@markmandel
Copy link
Member

This looks 👌 . Nice work. If nobody has any objections, I'll approve and merge this on Monday 👍

markmandel
markmandel approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like no objections. Let get this in! 👍

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: drichardson, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 3e6b1da6-57ef-408d-9c24-b2e499cd27d9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@drichardson
Copy link
Contributor Author

Failure is another instance of flaky test #1276.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: bfb6e1bf-c2e9-4d1e-8edf-84409ea2af6c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1360/head:pr_1360 && git checkout pr_1360
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-3fe490d

@markmandel markmandel merged commit 40b5ade into googleforgames:master Mar 2, 2020
@markmandel markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/documentation Documentation for Agones labels Mar 2, 2020
@markmandel markmandel added this to the 1.4.0 milestone Mar 2, 2020
@drichardson drichardson deleted the ue4-plugin-readme branch March 2, 2020 22:16
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@drichardson @markmandel @ilkercelikyilmaz
Add UE4 plugin developer information (googleforgames#1360)
538a748 
Co-authored-by: Mark Mandel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuahuburn joshuahuburn joshuahuburn left review comments

@jared-improbable jared-improbable jared-improbable left review comments

@domgreen domgreen domgreen left review comments

@markmandel markmandel markmandel approved these changes

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees

@markmandel markmandel

@roberthbailey roberthbailey

Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/documentation Documentation for Agones lgtm size/M
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
9 participants
@drichardson @agones-bot @markmandel @google-oss-robot @domgreen @jared-improbable @roberthbailey @joshuahuburn @pooneh-m