Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing dependency to a vendor_fixes #1321

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Feb 5, 2020

Also update vendor directory.
go mod tidy fix.

Closes #1309 .

Also update vendor directory
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 30ed594f-07d9-4381-b5e3-81a288d1ccad

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1321/head:pr_1321 && git checkout pr_1321
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-e0e1daf

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc and removed approved labels Feb 5, 2020
@markmandel markmandel merged commit 3e46172 into googleforgames:master Feb 5, 2020
@markmandel markmandel added this to the 1.4.0 milestone Feb 5, 2020
@aLekSer aLekSer deleted the fix/go-mod-tidy branch February 5, 2020 16:54
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running go mod tidy fails with error
4 participants