Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Interpolation-only expressions #1317

Merged
merged 2 commits into from
Feb 5, 2020

Conversation

chrisst
Copy link
Contributor

@chrisst chrisst commented Feb 4, 2020

Terraform 0.12.14 will start adding deprecation warnings for any strings that
only contain an interpolation as they can be replaced with straight references.

More at https://discuss.hashicorp.com/t/terraform-0-12-14-released/

This syntax has been available since Terraform 0.12 launched and it looks like 0.12 is the preferred version. Just in case I added a version constraint for

Terraform 0.12.14 will start adding deprecation warnings for any strings that
only contain an interpolation as they can be replaced with straight references.

More at https://discuss.hashicorp.com/t/terraform-0-12-14-released/
@chrisst
Copy link
Contributor Author

chrisst commented Feb 4, 2020

/assign @pooneh-m

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 68c079ea-a008-4926-a84b-afcb957398b0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1317/head:pr_1317 && git checkout pr_1317
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-6b178da

@pooneh-m pooneh-m requested review from markmandel and removed request for cyriltovena and dzlier-gcp February 5, 2020 06:30
@pooneh-m
Copy link
Contributor

pooneh-m commented Feb 5, 2020

Thanks for the change. It is good to have a professional terraformer on the project. :)

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisst, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6594c427-ecf8-422c-8204-8350b77d0eaa

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1317/head:pr_1317 && git checkout pr_1317
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-2924517

@pooneh-m pooneh-m merged commit cf8dd0c into googleforgames:master Feb 5, 2020
@markmandel markmandel added area/operations Installation, updating, metrics etc kind/cleanup Refactoring code, fixing up documentation, etc labels Feb 5, 2020
@markmandel markmandel added this to the 1.4.0 milestone Feb 5, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Terraform 0.12.14 will start adding deprecation warnings for any strings that
only contain an interpolation as they can be replaced with straight references.

More at https://discuss.hashicorp.com/t/terraform-0-12-14-released/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/operations Installation, updating, metrics etc kind/cleanup Refactoring code, fixing up documentation, etc size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants