Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fleet: Add validation for Strategy Type #1316

Merged
merged 2 commits into from
Feb 5, 2020
Merged

Fleet: Add validation for Strategy Type #1316

merged 2 commits into from
Feb 5, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Feb 4, 2020

Check Strategy Type on Fleet Update

Closes #1286

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 64ee53ab-a410-42ef-a79a-aa465e03c3fc

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer aLekSer force-pushed the fix/fleet-update-validation branch from 3c62c9e to 5cfffb4 Compare February 4, 2020 16:48
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: e64bcc89-b6bc-4375-b989-d790afea92f8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer aLekSer force-pushed the fix/fleet-update-validation branch from 5cfffb4 to 9190630 Compare February 4, 2020 17:02
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: fed6914f-ce51-4bba-86dd-4bd3e0b6752a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer
Fleet: Add validation for Strategy Type
4819c08 
Check Strategy Type on Fleet Update
@aLekSer aLekSer force-pushed the fix/fleet-update-validation branch from 9190630 to 4819c08 Compare February 4, 2020 18:02
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 085ec200-a18d-4f4b-8ee2-fc8cc36b1fdc

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1316/head:pr_1316 && git checkout pr_1316
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-4819c08

markmandel
markmandel approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f1cde69b-56d2-4762-8604-8740c101c2a1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1316/head:pr_1316 && git checkout pr_1316
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-b6627e1

@markmandel markmandel merged commit 05738e6 into googleforgames:master Feb 5, 2020
@markmandel markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/bug These are bugs. labels Feb 5, 2020
@markmandel markmandel added this to the 1.4.0 milestone Feb 5, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@aLekSer @markmandel @ilkercelikyilmaz
Fleet: Add validation for Strategy Type (googleforgames#1316)
d1f71a8 
Check Strategy Type on Fleet Update

Co-authored-by: Mark Mandel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@markmandel markmandel

Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/bug These are bugs. size/M
Projects
None yet
Milestone
1.4.0
4 participants
@aLekSer @agones-bot @google-oss-robot @markmandel