Changing the allocator API to gRPC #1314

pooneh-m · 2020-02-03T17:52:34Z

Changing the allocator API from REST to gRPC.
The API is still in alpha version; so breaking changes are OK.
#597

agones-bot · 2020-02-03T17:57:50Z

Build Failed 😱

Build Id: 203bb724-c6ff-47ef-a3b7-912e90514fd7

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-02-03T20:56:49Z

Build Succeeded 👏

Build Id: ceee219e-d26d-49a4-ad1b-292f0f3afb63

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-fe1c693
image: gcr.io/agones-images/agones-sdk:1.4.0-fe1c693
image: gcr.io/agones-images/agones-ping:1.4.0-fe1c693
Linux C++ SDK (build): agonessdk-1.4.0-fe1c693-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-fe1c693.zip

A preview of the website (the last 30 builds are retained):

https://fe1c693-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1314/head:pr_1314 && git checkout pr_1314
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-fe1c693

markmandel

Overall, looks good - just some general comments 👍

markmandel · 2020-02-03T22:30:05Z

cmd/allocator/main.go

@@ -54,7 +58,7 @@ import (
 )

 var (
-	logger = runtime.NewLoggerWithSource("main")
+	logger = runtime.NewLoggerWithSource("allocator-service")


I think this should stay as "main" so as to be inline with all our other main packages.

The package is there, so it's identifiable.

I see. So the source is the source file. That's replacing the stack trace? :) I'll follow the guideline then.

cmd/allocator/main.go

markmandel · 2020-02-03T22:59:14Z

cmd/allocator/main.go

 	go func() {
-		// The certs are set on the config so passing empty as the cert path
-		err := srv.ListenAndServeTLS("", "")
+		err := grpcServer.Serve(listener)


Not for this PR, but eventually, should we do a REST interface as well via grpc-gateway?

The annotations are there in the proto file 😄

Let's support REST, only if there is an ask.

agones-bot · 2020-02-05T18:17:57Z

Build Succeeded 👏

Build Id: 0cf84da6-e1c2-4b0d-9101-1f458e5afa3d

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-49eca7d
image: gcr.io/agones-images/agones-sdk:1.4.0-49eca7d
image: gcr.io/agones-images/agones-ping:1.4.0-49eca7d
Linux C++ SDK (build): agonessdk-1.4.0-49eca7d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-49eca7d.zip

A preview of the website (the last 30 builds are retained):

https://49eca7d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1314/head:pr_1314 && git checkout pr_1314
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-49eca7d

pooneh-m · 2020-02-10T17:42:22Z

Ping! :)

markmandel

Looks good! Nice work!

google-oss-robot · 2020-02-10T21:43:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel,pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2020-02-10T21:43:44Z

New changes are detected. LGTM label has been removed.

agones-bot · 2020-02-10T21:59:23Z

Build Failed 😱

Build Id: 7a2c5234-393a-4ec3-bf8a-fcc61e985bfe

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-02-10T22:33:38Z

Build Succeeded 👏

Build Id: aad9e295-bd1b-4da6-804e-2d5e99b332bf

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-c4c9de8
image: gcr.io/agones-images/agones-sdk:1.4.0-c4c9de8
image: gcr.io/agones-images/agones-ping:1.4.0-c4c9de8
Linux C++ SDK (build): agonessdk-1.4.0-c4c9de8-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-c4c9de8.zip

A preview of the website (the last 30 builds are retained):

https://c4c9de8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1314/head:pr_1314 && git checkout pr_1314
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-c4c9de8

agones-bot · 2020-02-10T22:46:38Z

Build Failed 😱

Build Id: 5f7bb5fd-6ca1-4bce-8ea0-930c0c7a94b8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Co-authored-by: Mark Mandel <[email protected]>

pooneh-m requested review from markmandel and roberthbailey February 3, 2020 17:52

google-oss-robot requested a review from cyriltovena February 3, 2020 17:52

google-oss-robot added approved size/XL labels Feb 3, 2020

pooneh-m removed the request for review from cyriltovena February 3, 2020 17:52

pooneh-m force-pushed the grpc branch from 6c5254e to fe1c693 Compare February 3, 2020 20:43

markmandel reviewed Feb 3, 2020

View reviewed changes

markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones labels Feb 3, 2020

Changing the allocator API to gRPC

49eca7d

pooneh-m force-pushed the grpc branch from fe1c693 to 49eca7d Compare February 5, 2020 18:03

roberthbailey removed their request for review February 7, 2020 19:33

markmandel added the kind/breaking Breaking change label Feb 10, 2020

markmandel mentioned this pull request Feb 10, 2020

Rename PostAllocate to Allocate in Multi Cluster Allocation Service #1331

Closed

markmandel approved these changes Feb 10, 2020

View reviewed changes

google-oss-robot assigned markmandel Feb 10, 2020

google-oss-robot added the lgtm label Feb 10, 2020

Merge branch 'master' into grpc

c4c9de8

google-oss-robot removed the lgtm label Feb 10, 2020

pooneh-m merged commit 8da5d31 into googleforgames:master Feb 10, 2020

markmandel added this to the 1.4.0 milestone Feb 26, 2020

ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020

Changing the allocator API to gRPC (googleforgames#1314)

6a48cb2

Co-authored-by: Mark Mandel <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changing the allocator API to gRPC #1314

Changing the allocator API to gRPC #1314

pooneh-m commented Feb 3, 2020 •

edited

Loading

agones-bot commented Feb 3, 2020

agones-bot commented Feb 3, 2020

markmandel left a comment

markmandel Feb 3, 2020

pooneh-m Feb 5, 2020

markmandel Feb 3, 2020

pooneh-m Feb 5, 2020 •

edited

Loading

agones-bot commented Feb 5, 2020

pooneh-m commented Feb 10, 2020

markmandel left a comment

google-oss-robot commented Feb 10, 2020

google-oss-robot commented Feb 10, 2020

agones-bot commented Feb 10, 2020

agones-bot commented Feb 10, 2020

agones-bot commented Feb 10, 2020

Changing the allocator API to gRPC #1314

Changing the allocator API to gRPC #1314

Conversation

pooneh-m commented Feb 3, 2020 • edited Loading

agones-bot commented Feb 3, 2020

agones-bot commented Feb 3, 2020

markmandel left a comment

Choose a reason for hiding this comment

markmandel Feb 3, 2020

Choose a reason for hiding this comment

pooneh-m Feb 5, 2020

Choose a reason for hiding this comment

markmandel Feb 3, 2020

Choose a reason for hiding this comment

pooneh-m Feb 5, 2020 • edited Loading

Choose a reason for hiding this comment

agones-bot commented Feb 5, 2020

pooneh-m commented Feb 10, 2020

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Feb 10, 2020

google-oss-robot commented Feb 10, 2020

agones-bot commented Feb 10, 2020

agones-bot commented Feb 10, 2020

agones-bot commented Feb 10, 2020

pooneh-m commented Feb 3, 2020 •

edited

Loading

pooneh-m Feb 5, 2020 •

edited

Loading