-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deep copy for multi-cluster allocation policy CRD #1308
Conversation
Build Failed 😱 Build Id: aa6e1056-d002-4a74-95da-19b43433b898 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
@pooneh-m thanks for this PR.
I will review more accurately tomorrow. |
Thanks for catching the issue through fuzz testing. I added the change. |
Build Failed 😱 Build Id: 1c133788-62a9-43bf-9c93-3f3c91d407e2 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: c485b0ff-a520-4a96-888e-8a667f92f849 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 089b44de-af55-4d79-8d65-5999e873e45a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, pooneh-m The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Build Succeeded 👏 Build Id: 2f20cb8b-02f5-4eec-a27d-8c8a760cf2a6 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All is fine, that was a pleasure and a fortune to find something through roundTrip fuzz test.
…#1308) Co-authored-by: Mark Mandel <[email protected]>
Added doc.go file to multicluster:v1alpha1 to get the deepcopy file regenerated.
This is to address the fuzz test issue for GameServerAllocationPolicy in #1098
Other files are updated due to running
make gen-crd-client
closes #1098