Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deep copy for multi-cluster allocation policy CRD #1308

Merged
merged 2 commits into from
Jan 31, 2020

Conversation

pooneh-m
Copy link
Contributor

@pooneh-m pooneh-m commented Jan 30, 2020

Added doc.go file to multicluster:v1alpha1 to get the deepcopy file regenerated.
This is to address the fuzz test issue for GameServerAllocationPolicy in #1098
Other files are updated due to running make gen-crd-client

closes #1098

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: aa6e1056-d002-4a74-95da-19b43433b898

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer
Copy link
Collaborator

aLekSer commented Jan 30, 2020

@pooneh-m thanks for this PR.
For now can you please add multicluster scheme here ?


I will review more accurately tomorrow.

@pooneh-m
Copy link
Contributor Author

pooneh-m commented Jan 30, 2020

@pooneh-m thanks for this PR.
For now can you please add multicluster scheme here ?

I will review more accurately tomorrow.

Thanks for catching the issue through fuzz testing. I added the change.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 1c133788-62a9-43bf-9c93-3f3c91d407e2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c485b0ff-a520-4a96-888e-8a667f92f849

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 089b44de-af55-4d79-8d65-5999e873e45a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1308/head:pr_1308 && git checkout pr_1308
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-c2b508f

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2f20cb8b-02f5-4eec-a27d-8c8a760cf2a6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1308/head:pr_1308 && git checkout pr_1308
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-d80cb0d

@markmandel markmandel merged commit 9323f9c into googleforgames:master Jan 31, 2020
Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is fine, that was a pleasure and a fortune to find something through roundTrip fuzz test.

@markmandel markmandel added this to the 1.4.0 milestone Feb 26, 2020
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Feb 26, 2020
@markmandel markmandel added the kind/bug These are bugs. label Feb 26, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/bug These are bugs. kind/cleanup Refactoring code, fixing up documentation, etc size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Fuzz Tests
5 participants