Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup Helm Configuration table #1255

Merged
merged 2 commits into from
Jan 6, 2020
Merged

Fixup Helm Configuration table #1255

merged 2 commits into from
Jan 6, 2020

Conversation

markmandel
Copy link
Member

Can't put feature flags in the middle of a markdown table, bad things happen.

@markmandel
Fixup Helm Configuration table
d0e9249 
Can't put feature flags in the middle of a markdown table,
bad things happen.
@markmandel markmandel added kind/bug These are bugs. kind/documentation Documentation for Agones labels Jan 2, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d6ea45e4-1e7f-43be-86e0-db3960ffafa0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1255/head:pr_1255 && git checkout pr_1255
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-d0e9249

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f4a5716c-2e74-4026-a640-314ab00ce1ef

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1255/head:pr_1255 && git checkout pr_1255
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-115a01b

@roberthbailey roberthbailey merged commit 9ae72ea into googleforgames:master Jan 6, 2020
@markmandel markmandel deleted the site/helm-config branch January 6, 2020 18:33
@markmandel markmandel added this to the 1.3.0 milestone Jan 10, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @roberthbailey @ilkercelikyilmaz
Fixup Helm Configuration table (googleforgames#1255)
5df30ee 
Can't put feature flags in the middle of a markdown table,
bad things happen.

Co-authored-by: Robert Bailey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@roberthbailey roberthbailey

Labels
approved kind/bug These are bugs. kind/documentation Documentation for Agones size/XS
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey