Docs Fleet add section about RollingUpdate fields #1228

aLekSer · 2019-12-11T17:29:13Z

RollingUpdate is not working when replicas number is updated.

aLekSer · 2019-12-11T17:35:46Z

Requested and more details and logs here:
#1156

agones-bot · 2019-12-11T17:42:21Z

Build Succeeded 👏

Build Id: 08d3be35-737e-4e35-bcfd-2a677d5dc1da

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.2.0-b042525
image: gcr.io/agones-images/agones-sdk:1.2.0-b042525
image: gcr.io/agones-images/agones-ping:1.2.0-b042525
Linux C++ SDK (build): agonessdk-1.2.0-b042525-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.2.0-b042525.zip

A preview of the website (the last 30 builds are retained):

https://b042525-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1228/head:pr_1228 && git checkout pr_1228
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-b042525

markmandel · 2019-12-11T18:15:19Z

site/content/en/docs/Guides/fleet-updates.md


 1. Adds the `maxSurge` number of `GameServers` to the Fleet.
 1. Shutdown the `maxUnavailable` number of `GameServers` in the Fleet, skipping `Allocated` `GameServers`.
 1. Repeat above steps until all the previous `GameServer` configurations have been `Shutdown` and deleted.

+{{< alert title="Note" color="info">}}
+When fleet update contains changes of `replicas` parameter, than new gameservers would be created/deleted straight away,


Just making a note from a conversation in chat - looks like this isn't 100% accurate, since you can get rolling updates even with a replica change.

yes, if there is only replicas change then there would be fast scale up, say from 3 to 30. If replicas + label then it would go stepwise.

Gentle bump on this - should we be adding some changes to the above to document the chat conversation we had?

Yes, definitely. Editing this

agones-bot · 2019-12-19T14:58:35Z

Build Succeeded 👏

Build Id: abdc41df-54a6-4e81-a1af-1403c91964f0

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-e24a408
image: gcr.io/agones-images/agones-sdk:1.3.0-e24a408
image: gcr.io/agones-images/agones-ping:1.3.0-e24a408
Linux C++ SDK (build): agonessdk-1.3.0-e24a408-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-e24a408.zip

A preview of the website (the last 30 builds are retained):

https://e24a408-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1228/head:pr_1228 && git checkout pr_1228
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-e24a408

markmandel

Looks good, just some suggested editing.

markmandel · 2019-12-19T22:55:54Z

site/content/en/docs/Guides/fleet-updates.md

+{{< alert title="Note" color="info">}}
+When `Fleet` update contains only changes to `replicas` parameter, than new gameservers would be created/deleted straight away,
+which means in that case `maxSurge` and `maxUnavailable` steps parameters will not be used. 
+Thus RollingUpdate strategy takes place when you update only not `replicas` parameters. If you update `replicas` parameter and some other parameters, then it could be a case when more than `maxSurge` parameters GameServers would be created.


Suggested change

Thus RollingUpdate strategy takes place when you update only not `replicas` parameters. If you update `replicas` parameter and some other parameters, then it could be a case when more than `maxSurge` parameters GameServers would be created.

The RollingUpdate strategy takes place when you update `spec` parameters other than `replicas`.

markmandel · 2019-12-19T22:56:31Z

site/content/en/docs/Guides/fleet-updates.md


 1. Adds the `maxSurge` number of `GameServers` to the Fleet.
 1. Shutdown the `maxUnavailable` number of `GameServers` in the Fleet, skipping `Allocated` `GameServers`.
 1. Repeat above steps until all the previous `GameServer` configurations have been `Shutdown` and deleted.

+{{< alert title="Note" color="info">}}
+When `Fleet` update contains only changes to `replicas` parameter, than new gameservers would be created/deleted straight away,


Suggested change

When `Fleet` update contains only changes to `replicas` parameter, than new gameservers would be created/deleted straight away,

When `Fleet` update contains only changes to the `replicas` parameter, then new GameServers will be created/deleted straight away,

markmandel · 2019-12-19T22:57:10Z

site/content/en/docs/Guides/fleet-updates.md


 1. Adds the `maxSurge` number of `GameServers` to the Fleet.
 1. Shutdown the `maxUnavailable` number of `GameServers` in the Fleet, skipping `Allocated` `GameServers`.
 1. Repeat above steps until all the previous `GameServer` configurations have been `Shutdown` and deleted.

+{{< alert title="Note" color="info">}}
+When `Fleet` update contains only changes to `replicas` parameter, than new gameservers would be created/deleted straight away,
+which means in that case `maxSurge` and `maxUnavailable` steps parameters will not be used. 


Suggested change

which means in that case `maxSurge` and `maxUnavailable` steps parameters will not be used.

which means in that case `maxSurge` and `maxUnavailable` parameters for a RollingUpdate will not be used.

markmandel · 2019-12-19T22:57:34Z

site/content/en/docs/Guides/fleet-updates.md

+which means in that case `maxSurge` and `maxUnavailable` steps parameters will not be used. 
+Thus RollingUpdate strategy takes place when you update only not `replicas` parameters. If you update `replicas` parameter and some other parameters, then it could be a case when more than `maxSurge` parameters GameServers would be created.
+
+For the case when you want to be flexible on Fleet size, Fleetautoscaler and your prefer `kubectl apply` Fleet config with omitted `replicas` parameter should be used with.


Suggested change

For the case when you want to be flexible on Fleet size, Fleetautoscaler and your prefer `kubectl apply` Fleet config with omitted `replicas` parameter should be used with.

For the case when you want to be flexible on Fleet size, Fleetautoscaler and your prefer `kubectl apply` Fleet config with omitted `replicas` parameter should be used.

markmandel · 2019-12-19T22:57:52Z

site/content/en/docs/Guides/fleet-updates.md

+Thus RollingUpdate strategy takes place when you update only not `replicas` parameters. If you update `replicas` parameter and some other parameters, then it could be a case when more than `maxSurge` parameters GameServers would be created.
+
+For the case when you want to be flexible on Fleet size, Fleetautoscaler and your prefer `kubectl apply` Fleet config with omitted `replicas` parameter should be used with.
+Do not change `replicas` field manually when you use `kubectl edit fleet` for a fleet which is controlled by a Fleetautoscaler.


Suggested change

Do not change `replicas` field manually when you use `kubectl edit fleet` for a fleet which is controlled by a Fleetautoscaler.

Do not change the `replicas` field manually when you use `kubectl edit fleet` for a fleet which is controlled by a Fleetautoscaler.

markmandel · 2019-12-19T23:00:28Z

site/content/en/docs/Getting Started/create-fleetautoscaler.md

-If you want to update a `Fleet`, which has `RollingUpdate` replacement strategy and is controlled by a `FleetAutoscaler`, you could omit `Replicas` parameter in a `Fleet` Spec.
-Otherwise fleet would be scaled according to Fleet `Replicas` parameter first and only after certain amount of time it would be rescaled to fit `FleetAutoscaler` `BufferSize` parameter.
+If you want to update a `Fleet` which has `RollingUpdate` replacement strategy and is controlled by a `FleetAutoscaler`:
+1. With `kubectl apply`: you should omit `replicas` parameter in a `Fleet` Spec before creating this `Fleet`.


Suggested change

1. With `kubectl apply`: you should omit `replicas` parameter in a `Fleet` Spec before creating this `Fleet`.

1. With `kubectl apply`: you should omit `replicas` parameter in a `Fleet` Spec before re-applying the `Fleet` configuration.

Used your suggestion.

site/content/en/docs/Getting Started/create-fleetautoscaler.md

markmandel · 2019-12-19T23:02:12Z

site/content/en/docs/Getting Started/create-fleetautoscaler.md

+1. With `kubectl apply`: you should omit `replicas` parameter in a `Fleet` Spec before creating this `Fleet`.
+1. With `kubectl edit`: you should not change `replicas` parameter in a `Fleet` Spec when updating other field parameter.
+
+If you follow both rules above, then `maxSurge` and `maxUnavaiable` parameters would be used and update would actually be a RollingUpdate.


Suggested change

If you follow both rules above, then `maxSurge` and `maxUnavaiable` parameters would be used and update would actually be a RollingUpdate.

If you follow the rules above, then `maxSurge` and `maxUnavaiable` parameters will be used as the RollingUpdate strategy updates your Fleet.

markmandel · 2019-12-19T23:02:27Z

site/content/en/docs/Getting Started/create-fleetautoscaler.md

+1. With `kubectl edit`: you should not change `replicas` parameter in a `Fleet` Spec when updating other field parameter.
+
+If you follow both rules above, then `maxSurge` and `maxUnavaiable` parameters would be used and update would actually be a RollingUpdate.
+Otherwise fleet would be scaled according to Fleet `replicas` parameter first and only after certain amount of time it would be rescaled to fit `FleetAutoscaler` `BufferSize` parameter.


Suggested change

Otherwise fleet would be scaled according to Fleet `replicas` parameter first and only after certain amount of time it would be rescaled to fit `FleetAutoscaler` `BufferSize` parameter.

Otherwise the Fleet would be scaled according to Fleet `replicas` parameter first and only after certain amount of time it would be rescaled to fit `FleetAutoscaler` `BufferSize` parameter.

markmandel · 2019-12-19T23:02:49Z

site/content/en/docs/Getting Started/create-fleetautoscaler.md

+If you follow both rules above, then `maxSurge` and `maxUnavaiable` parameters would be used and update would actually be a RollingUpdate.
+Otherwise fleet would be scaled according to Fleet `replicas` parameter first and only after certain amount of time it would be rescaled to fit `FleetAutoscaler` `BufferSize` parameter.
+
+You could also check the behaviour of the Fleet with Fleetautoscaler on a test `Fleet` to see what you would get on your production environment.


Suggested change

You could also check the behaviour of the Fleet with Fleetautoscaler on a test `Fleet` to see what you would get on your production environment.

You could also check the behaviour of the Fleet with Fleetautoscaler on a test `Fleet` to preview what would occur on your production environment.

agones-bot · 2019-12-20T11:49:00Z

Build Succeeded 👏

Build Id: 5f98a027-d3c1-4247-9127-a81f1fdcedee

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-c631361
image: gcr.io/agones-images/agones-sdk:1.3.0-c631361
image: gcr.io/agones-images/agones-ping:1.3.0-c631361
Linux C++ SDK (build): agonessdk-1.3.0-c631361-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-c631361.zip

A preview of the website (the last 30 builds are retained):

https://c631361-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1228/head:pr_1228 && git checkout pr_1228
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-c631361

aLekSer · 2019-12-20T11:53:26Z

Resolved all the comments. The most tricky one was:

With `kubectl apply`: you should omit `replicas` parameter in a `Fleet` Spec before creating (suuggested : before re-applying) this `Fleet`.

I also think that should be like this.
Small concern is in two different behaviours:

if we remove replicas and change other parameter - all is as you describe
if we only remove replicas on second apply - scale down immediately to 0 and then scaled up to BufferPolicy.
2nd is covered by fleet_updates.md so both are covered.

When `Fleet` update contains only changes to the `replicas` parameter, then new GameServers will be created/deleted straight away,
which means in that case `maxSurge` and `maxUnavailable` parameters for a RollingUpdate will not be used.

agones-bot · 2019-12-20T11:56:15Z

Build Failed 😱

Build Id: 06cfcf1a-03b0-4519-a59d-2f46927a8d32

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-12-20T12:10:40Z

Build Succeeded 👏

Build Id: 03dfb967-eca5-4205-b8a9-3082beb1606a

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-afaa2c1
image: gcr.io/agones-images/agones-sdk:1.3.0-afaa2c1
image: gcr.io/agones-images/agones-ping:1.3.0-afaa2c1
Linux C++ SDK (build): agonessdk-1.3.0-afaa2c1-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-afaa2c1.zip

A preview of the website (the last 30 builds are retained):

https://afaa2c1-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1228/head:pr_1228 && git checkout pr_1228
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-afaa2c1

aLekSer · 2019-12-20T12:13:13Z

Issue in website check:

Get https://v1-12.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.12/#podtemplatespec-v1-core: x509: certificate is valid for *.netlify.com, netlify.com, not v1-12.docs.kubernetes.io --- site/docs/reference/gameserver/index.html --> https://v1-12.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.12/#podtemplatespec-v1-core

agones-bot · 2019-12-20T12:31:29Z

Build Succeeded 👏

Build Id: 5ed57b2f-1ab0-468d-b2d7-bd4302ce7315

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-b4c6556
image: gcr.io/agones-images/agones-sdk:1.3.0-b4c6556
image: gcr.io/agones-images/agones-ping:1.3.0-b4c6556
Linux C++ SDK (build): agonessdk-1.3.0-b4c6556-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-b4c6556.zip

A preview of the website (the last 30 builds are retained):

https://b4c6556-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1228/head:pr_1228 && git checkout pr_1228
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-b4c6556

agones-bot · 2019-12-21T00:21:29Z

Build Succeeded 👏

Build Id: d05747c5-8de0-4226-a658-12b827c97ef8

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-65b944e
image: gcr.io/agones-images/agones-sdk:1.3.0-65b944e
image: gcr.io/agones-images/agones-ping:1.3.0-65b944e
Linux C++ SDK (build): agonessdk-1.3.0-65b944e-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-65b944e.zip

A preview of the website (the last 30 builds are retained):

https://65b944e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1228/head:pr_1228 && git checkout pr_1228
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-65b944e

agones-bot · 2019-12-21T08:59:40Z

Build Succeeded 👏

Build Id: 08436151-aaa7-4a55-9716-9f20311a9c1a

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-6df259f
image: gcr.io/agones-images/agones-sdk:1.3.0-6df259f
image: gcr.io/agones-images/agones-ping:1.3.0-6df259f
Linux C++ SDK (build): agonessdk-1.3.0-6df259f-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-6df259f.zip

A preview of the website (the last 30 builds are retained):

https://6df259f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1228/head:pr_1228 && git checkout pr_1228
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-6df259f

markmandel

Like this much better!

markmandel · 2019-12-30T20:56:06Z

site/content/en/docs/Guides/fleet-updates.md

+For the case when you want to be flexible on Fleet size, Fleetautoscaler and your prefer `kubectl apply` Fleet config with omitted `replicas` parameter should be used.
+Do not change the `replicas` field manually when you use `kubectl edit fleet` for a fleet which is controlled by a Fleetautoscaler.
+
+[Read Fleetautoscaler guide]({{< relref "../Getting Started/create-fleetautoscaler.md#7-change-autoscaling-parameters" >}}) for more details.


Suggested change

[Read Fleetautoscaler guide]({{< relref "../Getting Started/create-fleetautoscaler.md#7-change-autoscaling-parameters" >}}) for more details.

[Read the Fleetautoscaler guide]({{< relref "../Getting Started/create-fleetautoscaler.md#7-change-autoscaling-parameters" >}}) for more details.

markmandel · 2019-12-30T20:56:22Z

site/content/en/docs/Guides/fleet-updates.md

+
+[Read Fleetautoscaler guide]({{< relref "../Getting Started/create-fleetautoscaler.md#7-change-autoscaling-parameters" >}}) for more details.
+
+You could also check the behaviour of the Fleet with RollingUpdate strategy on a test `Fleet` to preview your upcoming updates.


Suggested change

You could also check the behaviour of the Fleet with RollingUpdate strategy on a test `Fleet` to preview your upcoming updates.

You could also check the behaviour of the Fleet with a RollingUpdate strategy on a test `Fleet` to preview your upcoming updates.

markmandel · 2019-12-30T20:56:36Z

site/content/en/docs/Guides/fleet-updates.md

+[Read Fleetautoscaler guide]({{< relref "../Getting Started/create-fleetautoscaler.md#7-change-autoscaling-parameters" >}}) for more details.
+
+You could also check the behaviour of the Fleet with RollingUpdate strategy on a test `Fleet` to preview your upcoming updates.
+Use `kubectl describe fleet` to track scaling events in a fleet.


Suggested change

Use `kubectl describe fleet` to track scaling events in a fleet.

Use `kubectl describe fleet` to track scaling events in a Fleet.

Changing this throughout a file

markmandel · 2019-12-30T21:00:53Z

site/content/en/docs/Guides/fleet-updates.md

+which means in that case `maxSurge` and `maxUnavailable` parameters for a RollingUpdate will not be used.
+The RollingUpdate strategy takes place when you update `spec` parameters other than `replicas`.
+
+For the case when you want to be flexible on Fleet size, Fleetautoscaler and your prefer `kubectl apply` Fleet config with omitted `replicas` parameter should be used.


Not sure I understand this sentence (and maybe the next one)

Could this be something more like:

If you are using a Fleet which is scaled by a FleetAutoscaler, [read the Fleetautoscaler guide]({{< relref "../Getting Started/create-fleetautoscaler.md#7-change-autoscaling-parameters" >}}) for more details on how RollingUpdates with FleetAutoscalers need to implemented.

Rather than writing the same documentation twice?
(If I'm hitting the idea of what you were trying to say)

markmandel · 2020-01-07T21:00:44Z

Gentle bump on this - would be good to have this in next week's RC release.

aLekSer · 2020-01-08T12:11:51Z

Thanks @markmandel on updates.
Sorry for the delay, long holidays.
Happy to update this PR according to your comments.

agones-bot · 2020-01-08T12:23:12Z

Build Succeeded 👏

Build Id: a0a39eba-85d7-47de-b446-fe8ea5e57449

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-6f3fa20
image: gcr.io/agones-images/agones-sdk:1.3.0-6f3fa20
image: gcr.io/agones-images/agones-ping:1.3.0-6f3fa20
Linux C++ SDK (build): agonessdk-1.3.0-6f3fa20-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-6f3fa20.zip

A preview of the website (the last 30 builds are retained):

https://6f3fa20-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1228/head:pr_1228 && git checkout pr_1228
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-6f3fa20

RollingUpdate is not working when replicas number is updated.

agones-bot · 2020-01-08T17:30:26Z

Build Succeeded 👏

Build Id: 4f91fb34-3a6c-4f68-8c53-207c6e3e3b4b

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-8c81cbb
image: gcr.io/agones-images/agones-sdk:1.3.0-8c81cbb
image: gcr.io/agones-images/agones-ping:1.3.0-8c81cbb
Linux C++ SDK (build): agonessdk-1.3.0-8c81cbb-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-8c81cbb.zip

A preview of the website (the last 30 builds are retained):

https://8c81cbb-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1228/head:pr_1228 && git checkout pr_1228
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-8c81cbb

markmandel

🔥

google-oss-robot · 2020-01-09T01:30:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2020-01-09T01:30:42Z

New changes are detected. LGTM label has been removed.

agones-bot · 2020-01-09T01:43:59Z

Build Succeeded 👏

Build Id: 06c88139-f6ae-4574-8904-07455ecc43d2

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-cd6d354
image: gcr.io/agones-images/agones-sdk:1.3.0-cd6d354
image: gcr.io/agones-images/agones-ping:1.3.0-cd6d354
Linux C++ SDK (build): agonessdk-1.3.0-cd6d354-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-cd6d354.zip

A preview of the website (the last 30 builds are retained):

https://cd6d354-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1228/head:pr_1228 && git checkout pr_1228
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-cd6d354

RollingUpdate is not working when replicas number is updated. Co-authored-by: Mark Mandel <[email protected]>

google-oss-robot requested review from cyriltovena and markmandel December 11, 2019 17:29

google-oss-robot added the size/S label Dec 11, 2019

markmandel reviewed Dec 11, 2019

View reviewed changes

aLekSer force-pushed the fix/rollingupdate branch from b042525 to e24a408 Compare December 19, 2019 14:44

markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Dec 19, 2019

markmandel reviewed Dec 19, 2019

View reviewed changes

aLekSer force-pushed the fix/rollingupdate branch 2 times, most recently from c631361 to 813e0bf Compare December 20, 2019 11:42

aLekSer force-pushed the fix/rollingupdate branch from 813e0bf to afaa2c1 Compare December 20, 2019 11:57

aLekSer force-pushed the fix/rollingupdate branch from afaa2c1 to b4c6556 Compare December 20, 2019 12:18

aLekSer force-pushed the fix/rollingupdate branch from b4c6556 to 65b944e Compare December 21, 2019 00:05

aLekSer force-pushed the fix/rollingupdate branch from 65b944e to 6df259f Compare December 21, 2019 08:38

markmandel reviewed Dec 30, 2019

View reviewed changes

aLekSer force-pushed the fix/rollingupdate branch from 6df259f to 6f3fa20 Compare January 8, 2020 12:09

Docs Fleet add section about RollingUpdate fields

8c81cbb

RollingUpdate is not working when replicas number is updated.

aLekSer force-pushed the fix/rollingupdate branch from 6f3fa20 to 8c81cbb Compare January 8, 2020 17:15

markmandel approved these changes Jan 9, 2020

View reviewed changes

google-oss-robot assigned markmandel Jan 9, 2020

google-oss-robot added the lgtm label Jan 9, 2020

google-oss-robot added the approved label Jan 9, 2020

Merge branch 'master' into fix/rollingupdate

cd6d354

google-oss-robot removed the lgtm label Jan 9, 2020

markmandel merged commit c439d4b into googleforgames:master Jan 9, 2020

markmandel added this to the 1.3.0 milestone Jan 9, 2020

aLekSer deleted the fix/rollingupdate branch January 13, 2020 15:25

	Thus RollingUpdate strategy takes place when you update only not `replicas` parameters. If you update `replicas` parameter and some other parameters, then it could be a case when more than `maxSurge` parameters GameServers would be created.
	The RollingUpdate strategy takes place when you update `spec` parameters other than `replicas`.

	When `Fleet` update contains only changes to `replicas` parameter, than new gameservers would be created/deleted straight away,
	When `Fleet` update contains only changes to the `replicas` parameter, then new GameServers will be created/deleted straight away,

	which means in that case `maxSurge` and `maxUnavailable` steps parameters will not be used.
	which means in that case `maxSurge` and `maxUnavailable` parameters for a RollingUpdate will not be used.

	For the case when you want to be flexible on Fleet size, Fleetautoscaler and your prefer `kubectl apply` Fleet config with omitted `replicas` parameter should be used with.
	For the case when you want to be flexible on Fleet size, Fleetautoscaler and your prefer `kubectl apply` Fleet config with omitted `replicas` parameter should be used.

	Do not change `replicas` field manually when you use `kubectl edit fleet` for a fleet which is controlled by a Fleetautoscaler.
	Do not change the `replicas` field manually when you use `kubectl edit fleet` for a fleet which is controlled by a Fleetautoscaler.

	1. With `kubectl apply`: you should omit `replicas` parameter in a `Fleet` Spec before creating this `Fleet`.
	1. With `kubectl apply`: you should omit `replicas` parameter in a `Fleet` Spec before re-applying the `Fleet` configuration.

	If you follow both rules above, then `maxSurge` and `maxUnavaiable` parameters would be used and update would actually be a RollingUpdate.
	If you follow the rules above, then `maxSurge` and `maxUnavaiable` parameters will be used as the RollingUpdate strategy updates your Fleet.

	Otherwise fleet would be scaled according to Fleet `replicas` parameter first and only after certain amount of time it would be rescaled to fit `FleetAutoscaler` `BufferSize` parameter.
	Otherwise the Fleet would be scaled according to Fleet `replicas` parameter first and only after certain amount of time it would be rescaled to fit `FleetAutoscaler` `BufferSize` parameter.

	You could also check the behaviour of the Fleet with Fleetautoscaler on a test `Fleet` to see what you would get on your production environment.
	You could also check the behaviour of the Fleet with Fleetautoscaler on a test `Fleet` to preview what would occur on your production environment.

	[Read Fleetautoscaler guide]({{< relref "../Getting Started/create-fleetautoscaler.md#7-change-autoscaling-parameters" >}}) for more details.
	[Read the Fleetautoscaler guide]({{< relref "../Getting Started/create-fleetautoscaler.md#7-change-autoscaling-parameters" >}}) for more details.

	Use `kubectl describe fleet` to track scaling events in a fleet.
	Use `kubectl describe fleet` to track scaling events in a Fleet.

Docs Fleet add section about RollingUpdate fields #1228

Docs Fleet add section about RollingUpdate fields #1228

Conversation

aLekSer commented Dec 11, 2019

aLekSer commented Dec 11, 2019

agones-bot commented Dec 11, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aLekSer Dec 19, 2019 • edited Loading

Choose a reason for hiding this comment

agones-bot commented Dec 19, 2019

markmandel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Dec 20, 2019

aLekSer commented Dec 20, 2019 • edited Loading

agones-bot commented Dec 20, 2019

agones-bot commented Dec 20, 2019

aLekSer commented Dec 20, 2019

agones-bot commented Dec 20, 2019

agones-bot commented Dec 21, 2019

agones-bot commented Dec 21, 2019

markmandel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markmandel commented Jan 7, 2020

aLekSer commented Jan 8, 2020

agones-bot commented Jan 8, 2020

agones-bot commented Jan 8, 2020

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Jan 9, 2020

google-oss-robot commented Jan 9, 2020

agones-bot commented Jan 9, 2020

aLekSer Dec 19, 2019 •

edited

Loading

aLekSer commented Dec 20, 2019 •

edited

Loading