Update the default gRPC and HTTP ports for the sdkserver for the 1.2.0 release #1180

roberthbailey · 2019-11-07T06:46:01Z

Fixes #851.

roberthbailey · 2019-11-07T06:48:56Z

This needs to have a big release note with 1.2.

In the 1.1 release we warned folks that this was coming and made it possible to configure the port (which makes it easy to keep using the old port as long as you are using the 1.1 SDK) but we need to mention it again. I've labeled this with kind/breaking since this changes default settings, which is a breaking change.

agones-bot · 2019-11-07T06:59:33Z

Build Succeeded 👏

Build Id: 76cf05f9-819d-47ca-bd47-aed784fb18b1

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.2.0-2fbecec
image: gcr.io/agones-images/agones-sdk:1.2.0-2fbecec
image: gcr.io/agones-images/agones-ping:1.2.0-2fbecec
Linux C++ SDK (build): agonessdk-1.2.0-2fbecec-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.2.0-2fbecec.zip

A preview of the website (the last 30 builds are retained):

https://2fbecec-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1180/head:pr_1180 && git checkout pr_1180
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-2fbecec

steven-supersolid

Node.js parts OK!

markmandel · 2019-11-07T22:02:54Z

Overall this looks good - do we want to add some documentation on the GameServer reference (I can't think of a better place) that explicitly shows how to setup the ports for the old version of the SDK?

roberthbailey · 2019-11-07T23:15:01Z

do we want to add some documentation on the GameServer reference

Good catch. I should update the comments in https://github.com/googleforgames/agones/blob/master/examples/gameserver.yaml and https://agones.dev/site/docs/reference/gameserver/. Both of those show examples of how to set the port, and we can point to them from the release notes.

roberthbailey · 2019-11-07T23:49:18Z

I've updated those two files.

agones-bot · 2019-11-08T00:02:49Z

Build Succeeded 👏

Build Id: c35cf9f5-3c4b-4e6e-86af-61a0fa5dda0b

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.2.0-7e25f28
image: gcr.io/agones-images/agones-sdk:1.2.0-7e25f28
image: gcr.io/agones-images/agones-ping:1.2.0-7e25f28
Linux C++ SDK (build): agonessdk-1.2.0-7e25f28-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.2.0-7e25f28.zip

A preview of the website (the last 30 builds are retained):

https://7e25f28-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1180/head:pr_1180 && git checkout pr_1180
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-7e25f28

google-oss-robot · 2019-11-14T23:54:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey, steven-supersolid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2019-11-14T23:54:39Z

New changes are detected. LGTM label has been removed.

agones-bot · 2019-11-15T00:02:52Z

Build Failed 😱

Build Id: ca910839-7451-43e5-b9e4-2a070b96cbd5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2019-11-15T00:18:41Z

docker run --rm -t -e "TERM=xterm-256color" -v /workspace/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.helm:/root/.helm -v /workspace:/go/src/agones.dev/agones -v /workspace/build//.gomod:/go/pkg/mod -v /workspace/build//.gocache:/root/.cache/go-build  agones-build:6be2be177f bash -c \
	"mkdir -p /tmp/website && cp -r /go/src/agones.dev/agones/site/public /tmp/website/site && htmltest -c /go/src/agones.dev/agones/site/htmltest.yaml /tmp/website"
htmltest started at 12:01:35 on /tmp/website
========================================================================
site/docs/installation/upgrading/index.html
  Non-OK status: 404 --- site/docs/installation/upgrading/index.html --> https://helm.sh/docs/helm/#helm-upgrade
========================================================================
✘✘✘ failed in 970.155526ms
1 errors in 81 documents

roberthbailey · 2019-11-15T00:19:07Z

Looks like the helm documentation has been rearranged (maybe with the release of helm 3?).

markmandel · 2019-11-15T00:19:38Z

Just submitted #1187 👍

roberthbailey · 2019-11-15T00:21:27Z

It looks like the old docs are available at https://v2.helm.sh/docs/helm/#helm-upgrade. I've added a commit to point to that page for now (since we are still using helm 2).

roberthbailey · 2019-11-15T00:21:53Z

Your commit is the same as my new commit. :)

roberthbailey · 2019-11-15T00:24:12Z

We can merge yours and I'll rebase.

agones-bot · 2019-11-15T00:25:57Z

Build Failed 😱

Build Id: 4f8694cc-3028-4f14-9b2b-303ef040e686

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

…0 release.

roberthbailey · 2019-11-15T00:33:48Z

Rebased. Tests should pass now.

agones-bot · 2019-11-15T00:37:03Z

Build Succeeded 👏

Build Id: ec8782f3-5115-4e32-a28f-e68de1f72a44

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.2.0-17e59c6
image: gcr.io/agones-images/agones-sdk:1.2.0-17e59c6
image: gcr.io/agones-images/agones-ping:1.2.0-17e59c6
Linux C++ SDK (build): agonessdk-1.2.0-17e59c6-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.2.0-17e59c6.zip

A preview of the website (the last 30 builds are retained):

https://17e59c6-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1180/head:pr_1180 && git checkout pr_1180
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-17e59c6

agones-bot · 2019-11-15T00:49:50Z

Build Failed 😱

Build Id: 540948d0-fe73-43dc-a970-999f8dea479d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2019-11-15T00:53:17Z

time="2019-11-15 00:46:21.102" level=info msg="failing http request" error="Post https://34.82.102.232:443/v1alpha1/gameserverallocation: x509: cannot validate certificate for 34.82.102.232 because it doesn't contain any IP SANs"
--- FAIL: TestAllocatorCrossNamespace (2.72s)
    allocator_test.go:128: Allocator TLS is refreshed with public CA: -----BEGIN CERTIFICATE-----
        MIIDMjCCAhqgAwIBAgIRAM7Ub8/tebzqLmRVvrtlbnYwDQYJKoZIhvcNAQEFBQAw
        KjEQMA4GA1UEChMHdGVzdGluZzEWMBQGA1UEAxMNMzQuODIuMTAyLjIzMjAeFw0x
        OTExMTUwMDQ2MjNaFw0xOTExMTUwMTQ2MjNaMCoxEDAOBgNVBAoTB3Rlc3Rpbmcx
        FjAUBgNVBAMTDTM0LjgyLjEwMi4yMzIwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAw
        ggEKAoIBAQDJrGkE3L477JWQXLrV+Jq9pb7k5VoLuJR2GMAo80BJyIqI2WRWNUCh
        HIuBVnmy2ysAyQAPXbPAmZAHXEG4c9gjEfx/L+7XAuaPhTo4L3JU6d6fqPGC55Nq
        qUEvWNgHUQR7CXIyeevsEn8byDDRaE0SfSE0RuHpntN1OcdOM10b1LB5AR/E060W
        5N7jxzVF+pfd1CLErqMUBxGNb9lmuiNyKKV33KTeL/TLE7mRaKbGizSwDjKKJWaZ
        fOVwT4GewJftpk/UsNoEisF3sMEPoz33/iekiVC0225aWHM85elWS+gq6roppaJr
        SqiqL8TCPNjvgfuuM0pJpysUtPAxMySnAgMBAAGjUzBRMA4GA1UdDwEB/wQEAwIC
        pDAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwEwDwYDVR0TAQH/BAUwAwEB
        /zAPBgNVHREECDAGhwQiUmboMA0GCSqGSIb3DQEBBQUAA4IBAQBCDPSpKjTwEwno
        Ammc/V4NHK8yToJGyaTPtf+uw92xJouUQRpSHivEml/vqesr4lM7YjZoOee5HLvo
        2iujwRXdi1ybFUb5TGPWbvMcS+TYeYr0jET8lAvLKanGf8HxVun7+Cw0SN3qRQkK
        d7kuOQlQcY7DCDQKB4r+rqS0KcWBDmsz/d4WoHCyLLTJzIRrsiMfwGijYCce++AY
        1e7ZLXVfycASMePlfNzfCxksy/6aYpuz/RAEeh1dAghxOeELPR5TMKygAswc1oJv
        vg8SFPo3ui7BPdnjqo7DzE0Xmc4cvHEk7uiBTbhNIlnGE1u/seI6Zw7N0uYXIxLq
        xO8dqqQg
        -----END CERTIFICATE-----
         for endpoint 34.82.102.232
    allocator_test.go:129: deleting pods failed: pods "agones-allocator-75bd56646b-cnjj7" not found

That's a new one?

Hitting restart.

agones-bot · 2019-11-15T01:05:40Z

Build Succeeded 👏

Build Id: 49f37b88-ca8f-46d6-a67f-b63d6c787bc7

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.2.0-f6b7712
image: gcr.io/agones-images/agones-sdk:1.2.0-f6b7712
image: gcr.io/agones-images/agones-ping:1.2.0-f6b7712
Linux C++ SDK (build): agonessdk-1.2.0-f6b7712-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.2.0-f6b7712.zip

A preview of the website (the last 30 builds are retained):

https://f6b7712-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1180/head:pr_1180 && git checkout pr_1180
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-f6b7712

agones-bot · 2019-11-15T01:22:13Z

Build Succeeded 👏

Build Id: c41aa006-c8d0-4507-9210-98e5fba85fce

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.2.0-b983387
image: gcr.io/agones-images/agones-sdk:1.2.0-b983387
image: gcr.io/agones-images/agones-ping:1.2.0-b983387
Linux C++ SDK (build): agonessdk-1.2.0-b983387-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.2.0-b983387.zip

A preview of the website (the last 30 builds are retained):

https://b983387-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1180/head:pr_1180 && git checkout pr_1180
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-b983387

as of googleforgames/agones#1180

…0 release. (googleforgames#1180)

google-oss-robot requested review from cyriltovena, devjgm and steven-supersolid November 7, 2019 06:46

google-oss-robot added the approved label Nov 7, 2019

roberthbailey added kind/breaking Breaking change and removed approved labels Nov 7, 2019

google-oss-robot added the size/L label Nov 7, 2019

roberthbailey added this to the 1.2.0 milestone Nov 7, 2019

steven-supersolid approved these changes Nov 7, 2019

View reviewed changes

google-oss-robot assigned steven-supersolid Nov 7, 2019

google-oss-robot added lgtm approved labels Nov 7, 2019

roberthbailey force-pushed the update-default-sdkserver-ports branch from 2fbecec to 7e25f28 Compare November 7, 2019 23:48

google-oss-robot removed the lgtm label Nov 7, 2019

roberthbailey assigned markmandel Nov 12, 2019

roberthbailey requested a review from markmandel November 12, 2019 19:03

markmandel approved these changes Nov 14, 2019

View reviewed changes

google-oss-robot added the lgtm label Nov 14, 2019

google-oss-robot removed the lgtm label Nov 14, 2019

roberthbailey force-pushed the update-default-sdkserver-ports branch from 88c6895 to 63e5580 Compare November 15, 2019 00:17

Update the default gRPC and HTTP ports for the sdkserver for the 1.2.…

f6b7712

…0 release.

roberthbailey force-pushed the update-default-sdkserver-ports branch from 17e59c6 to f6b7712 Compare November 15, 2019 00:33

Merge branch 'master' into update-default-sdkserver-ports

b983387

markmandel merged commit 71383df into googleforgames:master Nov 15, 2019

guitarrapc added a commit to guitarrapc/agones-udp-server-csharp that referenced this pull request Dec 26, 2019

fix; AgonesSdk Rest Port to 9358

16aa1f7

as of googleforgames/agones#1180

steven-supersolid mentioned this pull request Jan 30, 2020

Gameservers using nodejs sdk die with GOAWAY ENHANCE_YOUR_CALM too_many_pings #1299

Closed

roberthbailey deleted the update-default-sdkserver-ports branch August 24, 2020 23:01

ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020

Update the default gRPC and HTTP ports for the sdkserver for the 1.2.…

517aaf2

…0 release. (googleforgames#1180)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the default gRPC and HTTP ports for the sdkserver for the 1.2.0 release #1180

Update the default gRPC and HTTP ports for the sdkserver for the 1.2.0 release #1180

roberthbailey commented Nov 7, 2019

roberthbailey commented Nov 7, 2019

agones-bot commented Nov 7, 2019

steven-supersolid left a comment

markmandel commented Nov 7, 2019 •

edited

Loading

roberthbailey commented Nov 7, 2019

roberthbailey commented Nov 7, 2019

agones-bot commented Nov 8, 2019

google-oss-robot commented Nov 14, 2019

google-oss-robot commented Nov 14, 2019

agones-bot commented Nov 15, 2019

roberthbailey commented Nov 15, 2019

roberthbailey commented Nov 15, 2019

markmandel commented Nov 15, 2019

roberthbailey commented Nov 15, 2019

roberthbailey commented Nov 15, 2019

roberthbailey commented Nov 15, 2019

agones-bot commented Nov 15, 2019

roberthbailey commented Nov 15, 2019

agones-bot commented Nov 15, 2019

agones-bot commented Nov 15, 2019

markmandel commented Nov 15, 2019

agones-bot commented Nov 15, 2019

agones-bot commented Nov 15, 2019

Update the default gRPC and HTTP ports for the sdkserver for the 1.2.0 release #1180

Update the default gRPC and HTTP ports for the sdkserver for the 1.2.0 release #1180

Conversation

roberthbailey commented Nov 7, 2019

roberthbailey commented Nov 7, 2019

agones-bot commented Nov 7, 2019

steven-supersolid left a comment

Choose a reason for hiding this comment

markmandel commented Nov 7, 2019 • edited Loading

roberthbailey commented Nov 7, 2019

roberthbailey commented Nov 7, 2019

agones-bot commented Nov 8, 2019

google-oss-robot commented Nov 14, 2019

google-oss-robot commented Nov 14, 2019

agones-bot commented Nov 15, 2019

roberthbailey commented Nov 15, 2019

roberthbailey commented Nov 15, 2019

markmandel commented Nov 15, 2019

roberthbailey commented Nov 15, 2019

roberthbailey commented Nov 15, 2019

roberthbailey commented Nov 15, 2019

agones-bot commented Nov 15, 2019

roberthbailey commented Nov 15, 2019

agones-bot commented Nov 15, 2019

agones-bot commented Nov 15, 2019

markmandel commented Nov 15, 2019

agones-bot commented Nov 15, 2019

agones-bot commented Nov 15, 2019

markmandel commented Nov 7, 2019 •

edited

Loading