Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terraform configs to use Kubernetes 1.13 #1179

Merged
merged 2 commits into from
Nov 7, 2019

Conversation

roberthbailey
Copy link
Member

Part of #1044

/hold

Adding a hold until #1167 is merged.

/assign @aLekSer

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 6e3739a9-28cc-418c-b77b-3a6ec2e56e81

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member Author

--- FAIL: TestGameServerRestartBeforeReadyCrash (268.32s)
    gameserver_test.go:304: 
        	Error Trace:	gameserver_test.go:304
        	Error:      	Could not make GameServer Ready: %v
        	Test:       	TestGameServerRestartBeforeReadyCrash
        	Messages:   	timed out waiting for the condition
FAIL

This is #1173.

@aLekSer
Copy link
Collaborator

aLekSer commented Nov 7, 2019

PR looks good, I will verify this with E2E tests once #1167 would be merged.

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @aLekSer says it's good, I believe him 😄

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1960a34e-6443-4e4f-8596-ce47356a89e8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1179/head:pr_1179 && git checkout pr_1179
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-56499cd

@markmandel markmandel merged commit 6a45982 into googleforgames:master Nov 7, 2019
@roberthbailey
Copy link
Member Author

@aLekSer and I were waiting on #1167 to merge first as I was hoping to save @amitlevy21 from having to rebase.

@markmandel
Copy link
Member

Doh! I didn't see the hold!

@roberthbailey roberthbailey added this to the 1.2.0 milestone Nov 8, 2019
@markmandel markmandel added area/operations Installation, updating, metrics etc kind/breaking Breaking change labels Dec 4, 2019
@roberthbailey roberthbailey deleted the terraform-to-1-13 branch August 24, 2020 23:01
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/operations Installation, updating, metrics etc kind/breaking Breaking change size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants