-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update terraform configs to use Kubernetes 1.13 #1179
Update terraform configs to use Kubernetes 1.13 #1179
Conversation
Build Failed 😱 Build Id: 6e3739a9-28cc-418c-b77b-3a6ec2e56e81 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
This is #1173. |
PR looks good, I will verify this with E2E tests once #1167 would be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If @aLekSer says it's good, I believe him 😄
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Build Succeeded 👏 Build Id: 1960a34e-6443-4e4f-8596-ce47356a89e8 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
@aLekSer and I were waiting on #1167 to merge first as I was hoping to save @amitlevy21 from having to rebase. |
Doh! I didn't see the hold! |
Part of #1044
/hold
Adding a hold until #1167 is merged.
/assign @aLekSer